Skip to content

Implement getInAppUrl definition for rules saved object#252782

Merged
MichelLosier merged 7 commits intoelastic:mainfrom
MichelLosier:impl-app-url-for-rule-so
Feb 17, 2026
Merged

Implement getInAppUrl definition for rules saved object#252782
MichelLosier merged 7 commits intoelastic:mainfrom
MichelLosier:impl-app-url-for-rule-so

Conversation

@MichelLosier
Copy link
Copy Markdown
Contributor

@MichelLosier MichelLosier commented Feb 11, 2026 •
edited
Loading

Summary

Resolves: https://github.com/elastic/ingest-dev/issues/6716

Adds a getInAppUrl definition for the rule saved object, which defines where to view the rule in the UI. This is used by the Saved Objects management view, and the integrations assets view.

This relies on the re-routing behavior from /app/management/insightsAndAlerting/triggersActions to /app/rules controlled by the unifiedRulesPage flag as implemented in: #250493

To test:

With both the unifiedRulesPage flag on and off

xpack.trigger_actions_ui.enableExperimental:
  - unifiedRulesPage

Saved Objects management:

  • Have at least one alert rule defined
  • Go to app/management/kibana/objects
  • Find the saved object for the alert rule, and click the link.

Integration assets:

  • Go to app/integrations/detail/elastic_agent-2.7.0/overview
  • Install the Elastic Agent integration
  • Go to the assets tab, and scroll to the Rules section
  • Click any of think links

All links should route to the detail view of the rule.

Before
Screenshot 2026-02-11 at 2 01 39 PM

Screenshot 2026-02-11 at 2 02 14 PM

After
Screenshot 2026-02-11 at 1 59 41 PM

Screenshot 2026-02-11 at 2 02 53 PM

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@MichelLosier MichelLosier requested review from a team as code owners February 11, 2026 22:12
@MichelLosier MichelLosier added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Feb 11, 2026
@MichelLosier MichelLosier changed the title Impl app url for rule so Implement getInAppUrl definition for rules saved object Feb 11, 2026
@pmuellr
Copy link
Copy Markdown
Contributor

pmuellr commented Feb 11, 2026

This could use some function tests:

  • does it work on a rule in the default space
  • does it work on a rule in a non-default space (a common problem we've run into!)

@jasonrhodes
Copy link
Copy Markdown
Member

jasonrhodes commented Feb 11, 2026

@baileycash-elastic @dominiqueclarke something for us to keep track of that we will now need to update when we yank the rule UI consolidation feature flag soon

@darnautov darnautov added Feature:Alerting Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Feb 12, 2026
jeramysoucy
jeramysoucy approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested the SO management page and confirmed the behavior as expected.

@MichelLosier MichelLosier requested review from a team as code owners February 12, 2026 18:03
@MichelLosier
Copy link
Copy Markdown
Contributor Author

MichelLosier commented Feb 12, 2026

Added those tests @pmuellr in 0266af6

pmuellr
pmuellr approved these changes Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benakansara
benakansara approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@MichelLosier MichelLosier enabled auto-merge (squash) February 17, 2026 16:37
@MichelLosier MichelLosier merged commit a319a17 into elastic:main Feb 17, 2026
16 checks passed
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Feb 19, 2026
@MichelLosier @patrykkopycinski
Implement getInAppUrl definition for rules saved object (elastic#252782)
e50a7d5 
Resolves: elastic/ingest-dev#6716

Adds a `getInAppUrl` definition for the rule saved object, which defines
where to view the rule in the UI. This is used by the Saved Objects
management view, and the integrations assets view.

This relies on the re-routing behavior from
`/app/management/insightsAndAlerting/triggersActions` to `/app/rules`
controlled by the `unifiedRulesPage` flag as implemented in:
elastic#250493
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
@MichelLosier @ersin-erdal
Implement getInAppUrl definition for rules saved object (elastic#252782)
c64ec6a 
Resolves: elastic/ingest-dev#6716

Adds a `getInAppUrl` definition for the rule saved object, which defines
where to view the rule in the UI. This is used by the Saved Objects
management view, and the integrations assets view.

This relies on the re-routing behavior from
`/app/management/insightsAndAlerting/triggersActions` to `/app/rules`
controlled by the `unifiedRulesPage` flag as implemented in:
elastic#250493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmuellr pmuellr pmuellr approved these changes

@kapral18 kapral18 kapral18 approved these changes

@benakansara benakansara benakansara approved these changes

@jeramysoucy jeramysoucy jeramysoucy approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@MichelLosier @pmuellr @jasonrhodes @elasticmachine @kapral18 @benakansara @jeramysoucy @darnautov @kibanamachine