[APM] Extend React flow service map test coverage#251624
Merged
jennypavlova merged 4 commits intoelastic:mainfrom Feb 4, 2026
Merged
Conversation
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
crespocarlos
approved these changes
Feb 4, 2026
Contributor
crespocarlos
left a comment
There was a problem hiding this comment.
LGTM. left some nits
| type: MarkerType.ArrowClosed, | ||
| width: DEFAULT_MARKER_SIZE, | ||
| height: DEFAULT_MARKER_SIZE, | ||
| color: '#98A2B3', |
Contributor
There was a problem hiding this comment.
nit: we could create constants for these colors
Member
Author
There was a problem hiding this comment.
Thanks, I moved all the eui mocked theme colors and reused them ✅
Comment on lines
+652
to
+657
| edgeElement.focus(); | ||
|
|
||
| act(() => { | ||
| const event = new KeyboardEvent('keydown', { key: 'Enter', bubbles: true }); | ||
| document.dispatchEvent(event); | ||
| }); |
Contributor
There was a problem hiding this comment.
nit: to prevent repeating this
const pressKeyOnEdge = (key: string) => {
edgeElement.focus();
act(() => {
const event = new KeyboardEvent('keydown', { key, bubbles: true });
document.dispatchEvent(event);
});
};
Member
Author
There was a problem hiding this comment.
Good catch, thanks! Reused ✅
| }); | ||
| }); | ||
|
|
||
| describe('Enter/Space on node elements', () => { |
Contributor
There was a problem hiding this comment.
Should we test screen reader announcement?
Member
Author
There was a problem hiding this comment.
Those announcements will change in a follow up issue after some a11y feedback (also the component used for it) - I added the testing part to the AC there so we can have the test in the final version
Member
Author
|
@crespocarlos Thank you for the review! I added the suggestions and I will merge once the build is ready. |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 5, 2026
* commit '5c0872d56bc0268177cd3c7150a1685481fb5238': (221 commits) Add .cursorignore file (elastic#251709) [Search] Add descriptions to semantic_text field inference endpoint select (elastic#249265) [Agent Builder] Agent skills implementation (elastic#251209) [Lens] [ES|QL] Improve types for ES|QL conversion. (elastic#251042) Update the trace waterfall to make it easy to understand (elastic#250442) [ES|QL] [Lens] Adds query stats (elastic#251029) [Lens] Fix KQL character escaping when query is generated from Top values column (breakdown). (elastic#250925) fix(kbn-elastic-assistant): fix a11y issue with missing label on flyout (elastic#251656) Update dependency @elastic/monaco-esql to v3.1.16 (main) (elastic#251666) [Automatic Import V2] Add langsmith tracing (elastic#251592) [scout] fix duplicated test failure reports in Buildkite annotations (elastic#251455) chore(NA): remove us-central1-b from gcp zones on high load jobs (elastic#251748) skip flaky suite (elastic#250973) [Lens] Allow read only view for users with write permissions but having no write access to the dashboard (elastic#247746) [CI] Increase artifacts disk to 180gb (elastic#251774) [content-list] 1. Provider Foundation (elastic#251344) [AI Infra] Add missing ES|QL commands and functions documentation for inference tasks (elastic#249089) [docs-utils] 4️⃣ pre-req: Prepare for new validations (elastic#250810) [APM] Extend React flow service map test coverage (elastic#251624) [scout] discover tests with custom server configs (elastic#251297) ... # Conflicts: # src/platform/plugins/shared/dashboard/tsconfig.json # x-pack/platform/plugins/shared/agent_builder_platform/server/tools/create_visualization/create_visualization.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #250217
Summary
This PR extends React flow service map test coverage. It adds navigation links e2e and hooks (
useEdgeHighlightinganduseReducedMotion) tests and extendsuseKeyboardNavigationtestsHow to run the scout tests
Start the server with the React Flow feature flag enabled:
Run the React Flow tests:
How to run the service map unit tests