Address @elastic/eui/require-table-caption lint violations across @elastic/ml-ui files#249699
Merged
alexwizp merged 15 commits intoelastic:mainfrom Jan 23, 2026
Merged
Address @elastic/eui/require-table-caption lint violations across @elastic/ml-ui files#249699alexwizp merged 15 commits intoelastic:mainfrom
@elastic/eui/require-table-caption lint violations across @elastic/ml-ui files#249699alexwizp merged 15 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
...s/shared/ml/public/application/components/annotations/annotations_table/annotations_table.js
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/ml/public/application/settings/calendars/list/table/table.js
Outdated
Show resolved
Hide resolved
.../shared/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/ml/public/application/settings/filter_lists/list/table.js
Outdated
Show resolved
Hide resolved
...ins/shared/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap
Outdated
Show resolved
Hide resolved
...ins/shared/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap
Outdated
Show resolved
Hide resolved
...blic/application/supplied_configurations/supplied_configurations_flyout/data_views_table.tsx
Outdated
Show resolved
Hide resolved
…s/annotations/annotations_table/annotations_table.js Co-authored-by: Pete Harverson <pete@elastic.co>
…calendars/list/table/table.js Co-authored-by: Pete Harverson <pete@elastic.co>
…filter_lists/list/table.js Co-authored-by: Pete Harverson <pete@elastic.co>
…filter_lists/list/__snapshots__/table.test.js.snap Co-authored-by: Pete Harverson <pete@elastic.co>
…configurations/supplied_configurations_flyout/data_views_table.tsx Co-authored-by: Pete Harverson <pete@elastic.co>
…filter_lists/list/__snapshots__/table.test.js.snap Co-authored-by: Pete Harverson <pete@elastic.co>
…calendars/list/table/__snapshots__/table.test.js.snap Co-authored-by: Pete Harverson <pete@elastic.co>
peteharverson
approved these changes
Jan 23, 2026
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making these changes @alexwizp !
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 23, 2026
…@elastic/ml-ui` files (elastic#249699) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/require-table-caption`. This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a `tableCaption` prop for accessibility. ## Changes 1. 🎯 Added missing `tableCaption` attributes to elements flagged by `@elastic/eui/require-table-caption` — accessibility leveled up! ## Related - elastic/eui#9168 This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team! --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <pete@elastic.co> (cherry picked from commit 2e91ece)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jan 23, 2026
…@elastic/ml-ui` files (elastic#249699) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/require-table-caption`. This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a `tableCaption` prop for accessibility. ## Changes 1. 🎯 Added missing `tableCaption` attributes to elements flagged by `@elastic/eui/require-table-caption` — accessibility leveled up! ## Related - elastic/eui#9168 This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team! --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <pete@elastic.co> (cherry picked from commit 2e91ece) # Conflicts: # x-pack/platform/plugins/private/data_visualizer/public/application/file_data_visualizer/new/file_status/docs_preview.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
that referenced
this pull request
Jan 26, 2026
…ross `@elastic/ml-ui` files (#249699) (#250250) # Backport This will backport the following commits from `main` to `9.2`: - [Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)](#249699) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-01-23T15:57:46Z","message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>","sha":"2e91ececd77378d4abd5cbb6dfb5dda74eebdfe5","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","backport:version","v9.3.0","v9.4.0","v9.2.5"],"title":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files","number":249699,"url":"https://github.com/elastic/kibana/pull/249699","mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>","sha":"2e91ececd77378d4abd5cbb6dfb5dda74eebdfe5"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/250249","number":250249,"state":"OPEN"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/249699","number":249699,"mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>","sha":"2e91ececd77378d4abd5cbb6dfb5dda74eebdfe5"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jan 30, 2026
…ross `@elastic/ml-ui` files (#249699) (#250249) # Backport This will backport the following commits from `main` to `9.3`: - [Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)](#249699) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2026-01-23T15:57:46Z","message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>","sha":"2e91ececd77378d4abd5cbb6dfb5dda74eebdfe5","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","backport:version","v9.3.0","v9.4.0","v9.2.5"],"title":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files","number":249699,"url":"https://github.com/elastic/kibana/pull/249699","mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>","sha":"2e91ececd77378d4abd5cbb6dfb5dda74eebdfe5"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/249699","number":249699,"mergeCommit":{"message":"Address `@elastic/eui/require-table-caption` lint violations across `@elastic/ml-ui` files (#249699)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/require-table-caption`.\nThis rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a\n`tableCaption` prop for accessibility.\n\n## Changes\n\n1. 🎯 Added missing `tableCaption` attributes to elements flagged by\n`@elastic/eui/require-table-caption` — accessibility leveled up!\n\n## Related\n- https://github.com/elastic/eui/pull/9168\n\nThis time, to avoid annoying approvals collection, we've broken files\ndown by teams. Now, we are waiting a review only from your team!\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>","sha":"2e91ececd77378d4abd5cbb6dfb5dda74eebdfe5"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Pete Harverson <pete@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/require-table-caption.This rule ensure
EuiInMemoryTable,EuiBasicTablehave atableCaptionprop for accessibility.Changes
tableCaptionattributes to elements flagged by@elastic/eui/require-table-caption— accessibility leveled up!Related
@elastic/eslint-plugin-eui] added newrequire-table-captionrule. eui#9168This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team!