[Discover][Traces] Explore trace.id from logs in Discover by tfcmarques · Pull Request #249632 · elastic/kibana

tfcmarques · 2026-01-19T18:39:56Z

Summary

Removes trace.id hyperlinks from log and span summaries, while keeping the trace.id field and value visible
Adds an Open in Discover action button in Traces to enable trace debugging

Note:
Reverted changes that made Open in Discover button open to a new tab, so demo is not accurate
We're keeping the current button behaviour for now, making it open in the current tab
Changes here: 6846f01

Demo

Screen.Recording.2026-01-20.at.14.03.57.mov

…ection

…ed tests

elasticmachine · 2026-01-20T14:12:50Z

Pinging @elastic/obs-exploration-team (Team:obs-exploration)

cauemarcondes · 2026-01-20T14:18:06Z

...ns/shared/unified_doc_viewer/public/components/content_framework/section/section_actions.tsx

 export type Action =
-  | (BaseAction & { onClick: () => void; href?: never })
-  | (BaseAction & { href: string; onClick?: never });
+  | (BaseAction & { onClick: () => void; href?: never; target?: never })


It looks like we're not using the target for onclick, can we remove it?

Yeah, you're right, it's kinda redundant if href is not used, removing it 👍🏻

cauemarcondes · 2026-01-20T14:19:00Z

...d/unified_doc_viewer/public/components/doc_viewer_logs_overview/logs_overview_highlights.tsx

  [fieldConstants.TRACE_ID_FIELD]: {
    title: fieldLabels.TRACE_ID_LABEL,
-    formatter: (value: unknown, formattedValue: string) => (
-      <HighlightField value={value as string} formattedValue={formattedValue}>


I think we want to keep the highlighting and only remove the link?

Ah that's true, I'll quickly revert that, thanks 👍🏻

Done! Friendly reminder that it doesn't change the demo, because we're using ESQL there 🙇🏻

cauemarcondes · 2026-01-20T14:19:14Z

..._doc_viewer/public/components/observability/traces/components/about/field_configurations.tsx

    [TRACE_ID]: {
      title: fieldLabels.TRACE_ID_LABEL,
-      formatter: (value: unknown, formattedValue: string) => (
-        <HighlightField value={value as string} formattedValue={formattedValue}>


cauemarcondes · 2026-01-20T14:21:08Z

...ified_doc_viewer/public/components/observability/traces/components/trace_waterfall/index.tsx

  dataView: DocViewRenderProps['dataView'];
 }

+const openInDiscoverButtonLabel = i18n.translate(


We already have an "open in discover" label here public/components/observability/traces/common/constants.ts

tfcmarques · 2026-01-20T14:51:40Z

...plugins/shared/unified_doc_viewer/public/components/observability/traces/common/constants.ts


-export const OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL = i18n.translate(
-  'unifiedDocViewer.observability.traces.openInDiscoverArialLabel',
+export const OPEN_IN_DISCOVER_ARIA_LABEL = i18n.translate(


Fixing typo ARIAL -> ARIA

cauemarcondes

LGTM

cauemarcondes · 2026-01-20T19:30:11Z

@tfcmarques instead of prefixing the PR title with [Deliverable] which doesn't mean much we usually add the areas involved in the PR, for example [Discover][Traces]...

...ified_doc_viewer/public/components/observability/traces/components/trace_waterfall/index.tsx

…id-from-logs-in-Discover

iblancof

Code changes LGTM, thanks for driving the discussion around the indexes!
I know the button position is still pending, but leaving the approval anyway 👍🏻

…id-from-logs-in-Discover

elasticmachine · 2026-01-30T18:12:10Z

💚 Build Succeeded

Buildkite Build
Commit: 21fa102

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`unifiedDocViewer`	793	792	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`unifiedDocViewer`	381.5KB	380.7KB	-852.0B

History

💛 Build #386775 was flaky 67c7282
💛 Build #384542 was flaky 8260c00
💔 Build #384402 failed c226608
💔 Build #384214 failed 0140d0c
💛 Build #383923 was flaky 6590085
💔 Build #383808 failed 536a51a

cc @tfcmarques

…9632) ## Summary - Removes `trace.id` hyperlinks from log and span summaries, while keeping the `trace.id` field and value visible - Adds an `Open in Discover` action button in Traces to enable trace debugging > Note: > Reverted changes that made Open in Discover button open to a new tab, so demo is not accurate > We're keeping the current button behaviour for now, making it open in the current tab > Changes here: elastic@6846f01 ### Demo https://github.com/user-attachments/assets/e8b144de-d478-483e-a187-e62325afda6c

…iew_cps * commit '32efd9b2fb078ade51073fd2d0068bc74c029d6b': (49 commits) [Security Solution] Rules exceptions subfeatures (elastic#245722) [BK] Upgrade axios (elastic#251150) Fix AI Connector form fields resetting to default value when cleared by user (elastic#251095) deduplicate otel dependencies (elastic#250841) Adds initial agents.md file (elastic#250833) [index management] Faster index list loading (elastic#246276) skip failing test suite (elastic#251086) skip failing test suite (elastic#251048) [Security Solutions] Trial Companion - adjust UX design (elastic#250910) [Traces][Discover] Prevent flyout remount when switching document types in Trace Waterfall (elastic#250406) [DOCS][Cases][9.4 & Serverless]: Doc new `Maximum amount of cases to open` setting for case action (elastic#250993) [Discover][Traces] Explore trace.id from logs in Discover (elastic#249632) Remove ! from SOs docs link (elastic#251097) [ML] Maps: Add telemetry events for file uploads (elastic#247543) [Fleet] Fix dupplicate ids when copying an integration policy or an agent policy (elastic#250971) [Dashboards as Code] Add snake case object keys util (elastic#250962) [Core] Remove URL Overflow & Deprecate `storeInSessionStorage` setting (elastic#242972) [One Workflow] fix: Fix Variable Retrieval in Workflow Execution Engine (elastic#250852) Rework Elastic Managed LLMs page (elastic#251069) [Lens powered by ES|QL] Update Switch to Query mode modal warning message (elastic#251051) ...

…cover Tab on left-click (#251103) ## Summary Closes #241280 Now that we have Discover Tabs, all links from Discover within Discover should open in a new tab. This PR updates all the "Open in Discover" buttons to follow that pattern, as decided by the product team. - On left-click: it will open a new Discover tab. - On right-click: users can select to 'open new tab' in their browser. **Span/Transaction flyout** |Section|Interaction| |-|-| |Similar spans|![similar_spans_f_waterfall](https://github.com/user-attachments/assets/fa5db09d-d81a-4461-b0ff-fdb19cb4038a)| |Trace|~TODO, pending on #249632 to be merged~![Screen Recording 2026-02-03 at 10 50 15](https://github.com/user-attachments/assets/a5c35ab1-c80b-4966-aa06-f00bd47a94c4)| |Errors|![errors](https://github.com/user-attachments/assets/aefed9f3-5a1b-4323-aef3-0936d75322f6)| |Logs|![logs](https://github.com/user-attachments/assets/50c36810-d409-4987-861b-aa98af8c99da)| |Span Links|![span_links](https://github.com/user-attachments/assets/9ec46de9-b5ad-4d35-9b68-0ce567e923ac)| ℹ️ Updated `data-test-subj` for Span Links and Errors sections, which were duplicated and wrong. **Log flyout** |Section|Interaction| |-|-| |Similar errors|![similar_errors](https://github.com/user-attachments/assets/d5e8dd8a-7498-436a-b502-0910ed7a5fe1)|Section only visible for logs with `trace.id`| --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

remove trace id from summary table + add open in discover to traces s…

0d970c6

…ection

tfcmarques self-assigned this Jan 19, 2026

tfcmarques added the Team:obs-exploration Observability Exploration team label Jan 19, 2026

tfcmarques added 2 commits January 20, 2026 12:49

revert summary table trace id removal + remove only hyperlink + updat…

a2301e9

…ed tests

Merge branch 'main' into 5115-explore-trace-id-from-logs-in-Discover

fd594ec

tfcmarques added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Jan 20, 2026

tfcmarques marked this pull request as ready for review January 20, 2026 14:12

tfcmarques requested a review from a team as a code owner January 20, 2026 14:12

iblancof self-requested a review January 20, 2026 14:14

cauemarcondes reviewed Jan 20, 2026

View reviewed changes

tfcmarques added 2 commits January 20, 2026 14:46

revert highlight removal + minor type change

5a6cc78

reuse open in discover label + typo fix

73edc63

tfcmarques commented Jan 20, 2026

View reviewed changes

fix translation files

536a51a

tfcmarques requested a review from cauemarcondes January 20, 2026 15:08

fix trace waterfall test mocks

6590085

cauemarcondes approved these changes Jan 20, 2026

View reviewed changes

iblancof reviewed Jan 21, 2026

View reviewed changes

...ified_doc_viewer/public/components/observability/traces/components/trace_waterfall/index.tsx Show resolved Hide resolved

...ified_doc_viewer/public/components/observability/traces/components/trace_waterfall/index.tsx Outdated Show resolved Hide resolved

tfcmarques changed the title ~~[Deliverable] Explore trace.id from logs in Discover~~ [Discover][Traces] Explore trace.id from logs in Discover Jan 21, 2026

tfcmarques added 7 commits January 21, 2026 10:46

revert target prop from action

6846f01

Merge branch 'main' into 5115-explore-trace-id-from-logs-in-Discover

0140d0c

switch traces section action buttons order

c226608

Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…

8260c00

…id-from-logs-in-Discover

Merge branch 'main' into 5115-explore-trace-id-from-logs-in-Discover

9444701

Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…

47df69f

…id-from-logs-in-Discover

Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…

67c7282

…id-from-logs-in-Discover

iblancof approved these changes Jan 28, 2026

View reviewed changes

iblancof mentioned this pull request Jan 30, 2026

[Discover][Traces] All "Open in Discover" links now open in a new Discover Tab on left-click #251103

Merged

Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…

21fa102

…id-from-logs-in-Discover

tfcmarques enabled auto-merge (squash) January 30, 2026 16:11

tfcmarques merged commit 037abad into elastic:main Jan 30, 2026
16 checks passed

kibanamachine added the v9.4.0 label Jan 30, 2026

iblancof mentioned this pull request Mar 2, 2026

[Traces][Discover] Distributed tracing: Trace ID link redirects to misleading page #227662

Closed

Conversation

tfcmarques commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Demo

Uh oh!

elasticmachine commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

cauemarcondes commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

iblancof left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jan 30, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tfcmarques commented Jan 19, 2026 •

edited

Loading