[ObsPresentation][A11y] Fix asset details flyout header announcement#246872
Merged
MiriamAparicio merged 5 commits intoelastic:mainfrom Dec 22, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
crespocarlos
approved these changes
Dec 18, 2025
jennypavlova
approved these changes
Dec 18, 2025
Member
jennypavlova
left a comment
There was a problem hiding this comment.
Nice ❤️ 
🚀 Thanks for the fix!
|
|
||
| describe(`and using Import API`, function () { | ||
| const buildImportBuffer = (listId: typeof ALL_ENDPOINT_ARTIFACT_LIST_IDS[number]): Buffer => { | ||
| const buildImportBuffer = ( |
Member
There was a problem hiding this comment.
Q: Why is this change added? Was it just a lint fix?
Contributor
Author
There was a problem hiding this comment.
ah good question, I did not opened that file, let me check
Contributor
Author
There was a problem hiding this comment.
Yeah, seems that the eslint automatic commit 42f1712
Contributor
Author
There was a problem hiding this comment.
fixed after updating with main
…tails-flyout-announcement
83800d1 to
aaa7056
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 22, 2025
…lastic#246872) Closes elastic#221910 ### Summary Flyout should be announced with a name, in this case asset name https://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360 (cherry picked from commit 8460ecc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 22, 2025
…lastic#246872) Closes elastic#221910 ### Summary Flyout should be announced with a name, in this case asset name https://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360 (cherry picked from commit 8460ecc)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 22, 2025
…d_step_back * commit '51756d2722200a991607658d48ecda50aeb04a7d': (76 commits) [Synthetics] Fix SyncGlobalParamsSpaces flaky test (elastic#246487) [Synthetics] Fix useSyntheticsRules test (elastic#247259) [ES|QL] Fix index editor flaky test (elastic#247233) [ResponseOps][Reporting] Fix "failed to decrypt apiKey" error while disabling/enabling scheduled reports (elastic#247236) [Console] Update console definitions (main) (elastic#247214) [ES|QL] Esql indentation shortcut on the editor (elastic#247234) [Streams] Use original request for rules client when in default space (elastic#247014) Consolidate and improve unflattenObject (elastic#246725) [scout] use svl mode to run api-int tests (elastic#247223) SIEM Readiness V2 (elastic#245776) [ObsPresentation][A11y] Fix asset details flyout header announcement (elastic#246872) [Streams] Add abort support and silent mode for stream description generation (elastic#247082) [SLO] Add environment context to SLO feedback button (elastic#247221) Ignore the reason and retry systematically (elastic#246830) Update dependency @types/moment-duration-format to ^2.2.7 (main) (elastic#242221) [Streams 🌊 ] Add explicit waits for data grid rows before clicking expand button (elastic#246919) [Security Solution][Entity Analytics][Risk Scoring] Handle special characters in ESQL query for risk scoring (elastic#247060) [ML] Data frame analytics: Updates page headers (elastic#247097) [ES|QL] Build function arguments suggestions from hints (elastic#246736) Update dependency @hey-api/openapi-ts to v0.88.1 (main) (elastic#247210) ...
kibanamachine
added a commit
that referenced
this pull request
Dec 23, 2025
…ement (#246872) (#247262) # Backport This will backport the following commits from `main` to `9.2`: - [[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)](#246872) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"31922082+MiriamAparicio@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-22T13:35:53Z","message":"[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)\n\nCloses https://github.com/elastic/kibana/issues/221910\n\n### Summary\n\nFlyout should be announced with a name, in this case asset name\n\n\nhttps://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360","sha":"8460ecc79d0da6040b7ca87a601812805b0eedbd","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0","v9.4.0","Team:obs-presentation"],"title":"[ObsPresentation][A11y] Fix asset details flyout header announcement","number":246872,"url":"https://github.com/elastic/kibana/pull/246872","mergeCommit":{"message":"[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)\n\nCloses https://github.com/elastic/kibana/issues/221910\n\n### Summary\n\nFlyout should be announced with a name, in this case asset name\n\n\nhttps://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360","sha":"8460ecc79d0da6040b7ca87a601812805b0eedbd"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246872","number":246872,"mergeCommit":{"message":"[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)\n\nCloses https://github.com/elastic/kibana/issues/221910\n\n### Summary\n\nFlyout should be announced with a name, in this case asset name\n\n\nhttps://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360","sha":"8460ecc79d0da6040b7ca87a601812805b0eedbd"}}]}] BACKPORT--> Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Dec 23, 2025
…ement (#246872) (#247263) # Backport This will backport the following commits from `main` to `9.3`: - [[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)](#246872) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"31922082+MiriamAparicio@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-22T13:35:53Z","message":"[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)\n\nCloses https://github.com/elastic/kibana/issues/221910\n\n### Summary\n\nFlyout should be announced with a name, in this case asset name\n\n\nhttps://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360","sha":"8460ecc79d0da6040b7ca87a601812805b0eedbd","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.3.0","v9.4.0","Team:obs-presentation"],"title":"[ObsPresentation][A11y] Fix asset details flyout header announcement","number":246872,"url":"https://github.com/elastic/kibana/pull/246872","mergeCommit":{"message":"[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)\n\nCloses https://github.com/elastic/kibana/issues/221910\n\n### Summary\n\nFlyout should be announced with a name, in this case asset name\n\n\nhttps://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360","sha":"8460ecc79d0da6040b7ca87a601812805b0eedbd"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/246872","number":246872,"mergeCommit":{"message":"[ObsPresentation][A11y] Fix asset details flyout header announcement (#246872)\n\nCloses https://github.com/elastic/kibana/issues/221910\n\n### Summary\n\nFlyout should be announced with a name, in this case asset name\n\n\nhttps://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360","sha":"8460ecc79d0da6040b7ca87a601812805b0eedbd"}}]}] BACKPORT--> Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 6, 2026
…lastic#246872) Closes elastic#221910 ### Summary Flyout should be announced with a name, in this case asset name https://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Jan 8, 2026
…lastic#246872) Closes elastic#221910 ### Summary Flyout should be announced with a name, in this case asset name https://github.com/user-attachments/assets/593d55dc-5dc4-48cf-a944-84731035c360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221910
Summary
Flyout should be announced with a name, in this case asset name
Screen.Recording.2025-12-18.at.12.21.53.mov