🌊 Fix validation for partially invalid streamlang steps#245367
Merged
flash1293 merged 1 commit intoelastic:mainfrom Dec 5, 2025
Merged
🌊 Fix validation for partially invalid streamlang steps#245367flash1293 merged 1 commit intoelastic:mainfrom
flash1293 merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-onboarding-team (Team:obs-onboarding) |
mykolaharmash
approved these changes
Dec 5, 2025
Contributor
mykolaharmash
left a comment
There was a problem hiding this comment.
Tested locally, the issue is gone ✨
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @flash1293 |
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Dec 5, 2025
This PR fixes the problem that after adding a condition, it's not possible to add more processors anymore. This happened because `isWhereBlockSchema` would return false for a well-formed where-block if it contains an invalid processor, which is the case when adding a new processor (because the default grok state has an empty field name, which is not valid as per the schema). This broke the validation logic. By using `isWhereBlock` it makes the check cheaper and also doesn't fail on invalid children. Also added a test for this.
This was referenced Dec 5, 2025
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
This PR fixes the problem that after adding a condition, it's not possible to add more processors anymore. This happened because `isWhereBlockSchema` would return false for a well-formed where-block if it contains an invalid processor, which is the case when adding a new processor (because the default grok state has an empty field name, which is not valid as per the schema). This broke the validation logic. By using `isWhereBlock` it makes the check cheaper and also doesn't fail on invalid children. Also added a test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that after adding a condition, it's not possible to add more processors anymore.
This happened because
isWhereBlockSchemawould return false for a well-formed where-block if it contains an invalid processor, which is the case when adding a new processor (because the default grok state has an empty field name, which is not valid as per the schema). This broke the validation logic.By using
isWhereBlockit makes the check cheaper and also doesn't fail on invalid children. Also added a test for this.