Update offset of EuiPopover usages with hover behavior#245260
Merged
mgadewoll merged 1 commit intoelastic:mainfrom Dec 5, 2025
Merged
Update offset of EuiPopover usages with hover behavior#245260mgadewoll merged 1 commit intoelastic:mainfrom
offset of EuiPopover usages with hover behavior#245260mgadewoll merged 1 commit intoelastic:mainfrom
Conversation
- reducing the offset for popovers with hover ensures that the popovers don't close unexpectedly
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
cc @mgadewoll |
Contributor
|
Pinging @elastic/eui-team (EUI) |
PhilippeOberti
approved these changes
Dec 4, 2025
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Just FYI for other reviewers, this is the same fix that I implemented here for the kbn-cell-actions package yesterday
KDKHD
approved these changes
Dec 5, 2025
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
) ## Summary This PR is a follow-up to changes added in elastic#244032 EUI updated the default `offset` value for `EuiPopover` to `4` when `hasArrow=false` (set as default). This results in the popover closing unexpectedly when the popover has custom closing behavior on `onMouseLeave` due to the `4px` gap between the trigger and the panel elements. >[!NOTE] `EuiPopover` currently does not support open/close behavior on mouseenter/mouseleave due to general accessibility concerns ([docs](https://eui.elastic.co/v109.1.0/docs/components/containers/popover/)). The implementations use custom functionality which is not considered by the default `offset` value. ### Changes - updates `offset` to `0` for `EuiPopover` usages that apply custom open/close behavior on mouseenter/mouseleave ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to changes added in #244032
EUI updated the default
offsetvalue forEuiPopoverto4whenhasArrow=false(set as default).This results in the popover closing unexpectedly when the popover has custom closing behavior on
onMouseLeavedue to the4pxgap between the trigger and the panel elements.Note
EuiPopovercurrently does not support open/close behavior on mouseenter/mouseleave due to general accessibility concerns (docs).The implementations use custom functionality which is not considered by the default
offsetvalue.Changes
offsetto0forEuiPopoverusages that apply custom open/close behavior on mouseenter/mouseleaveChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.