Conversation
- EUI updated the type and the query might be null for text searches
…o "combobox" in DataView list component
|
Pinging @elastic/eui-team (EUI) |
sabarasaba
left a comment
There was a problem hiding this comment.
kibana management changes lgtm
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
PhilippeOberti
left a comment
There was a problem hiding this comment.
Code review only, LGTM for the @elastic/security-threat-hunting-investigations team
peteharverson
left a comment
There was a problem hiding this comment.
ML changes LGTM (tested the 3 tables with noItemsMessage changes).
consulthys
left a comment
There was a problem hiding this comment.
LGT Stack Monitoring
Thanks for the updates
rylnd
left a comment
There was a problem hiding this comment.
Detection Engine changes LGTM.
ThomThomson
left a comment
There was a problem hiding this comment.
Presentation team changes LGTM!
TinaHeiligers
left a comment
There was a problem hiding this comment.
saved objects management snapshot update LGTM
mashhurs
left a comment
There was a problem hiding this comment.
Logstash pipelines view LGTM!
jeramysoucy
left a comment
There was a problem hiding this comment.
LGTM - code review and manually checked each modified page
|
@elasticmachine merge upstream |
- prevents background color differences due to the spacing resulting from the max-width style
| margin: auto; | ||
| border-bottom: none; | ||
|
|
||
| .euiPageHeaderContent { |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @mgadewoll |
## Dependency updates - `@elastic/eui`: `v109.2.0` ⏩ `v110.0.0` --- ## Changes - Updates usages of the `message` prop on `EuiInMemoryTable` to `noItemsMessage` - Updates usages of `EuiSearchBar`'s `onChange` prop to check for the `query` argument, as it may be `null` now - Removes obsolete `color` props on implementations of `EuiPageTemplate` and `EuiPageTemplate.Header` (`color` prop wasn't applied before either) ## Package updates ### `@elastic/eui` v110.0.0 - Updated `EuiSuperDatePicker` to expose plain text `utcOffset` and `timeZoneName` in `timeZoneDisplayProps.customRender` render function ([elastic#9245](elastic/eui#9245)) - Updated `EuiHeaderLogo` to add a hover style ([elastic#9240](elastic/eui#9240)) - Made `EuiQuickSelectPanel` available for importing from the `@elastic/eui` package ([elastic#9239](elastic/eui#9239)) - Updated `EuiAvatar` to support Emoji Sequence ("advanced") in the `initials` prop ([elastic#9227](elastic/eui#9227)) - Added `color` prop on `EuiPageHeader` to support `transparent` (default) and `plain` backgrounds. ([elastic#9220](elastic/eui#9220)) - Added `color` prop on `EuiPage` to support `transparent` (default) and `plain` backgrounds. ([elastic#9220](elastic/eui#9220)) - Updated `EuiPageTemplate` to ensure `panelled=true` renders a `EuiPageHeader` with a plain background by default ([elastic#9220](elastic/eui#9220)) - Removed the default background style on `EuiPageTemplate`'s outer wrapper ([elastic#9220](elastic/eui#9220)) **Bug fixes** - Fixed icon size in `EuiSuperDatePicker`'s time window buttons when `compressed={true}` ([elastic#9245](elastic/eui#9245)) - Fixed `EuiIcon` visibility issue with `logoElastic` when `color` is set to `text` or `ghost` in light mode ([elastic#9247](elastic/eui#9247)) - Fixed `EuiInMemoryTable` support for controlled search for plain text (when `searchFormat="text"`) by properly handling `search.query` and `search.defaulQuery` ([elastic#9142](elastic/eui#9142)) **Breaking changes** - Removed deprecated `message` prop from `EuiInMemoryTable`, use `noItemsMessage` instead ([elastic#9234](elastic/eui#9234)) **Accessibility** - Improved the accessibility of input fields in the popover of `EuiSuperDatePicker` by properly labeling them ([elastic#9239](elastic/eui#9239)) - Improved the accessibility of `EuiSelectable` by removing empty `aria-activedescendant` attribute when no option is active to ensure the search input is perceivable by screen readers ([elastic#9223](elastic/eui#9223)) --------- Co-authored-by: Weronika Olejniczak <weronika.olejniczak@elastic.co> Co-authored-by: Jorge Oliveira <jorge.oliveira@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>


Dependency updates
@elastic/eui:v109.2.0⏩v110.0.0Changes
messageprop onEuiInMemoryTabletonoItemsMessageEuiSearchBar'sonChangeprop to check for thequeryargument, as it may benullnowcolorprops on implementations ofEuiPageTemplateandEuiPageTemplate.Header(colorprop wasn't applied before either)Package updates
@elastic/euiv110.0.0EuiSuperDatePickerto expose plain textutcOffsetandtimeZoneNameintimeZoneDisplayProps.customRenderrender function (#9245)EuiHeaderLogoto add a hover style (#9240)EuiQuickSelectPanelavailable for importing from the@elastic/euipackage (#9239)EuiAvatarto support Emoji Sequence ("advanced") in theinitialsprop (#9227)colorprop onEuiPageHeaderto supporttransparent(default) andplainbackgrounds. (#9220)colorprop onEuiPageto supporttransparent(default) andplainbackgrounds. (#9220)EuiPageTemplateto ensurepanelled=truerenders aEuiPageHeaderwith a plain background by default (#9220)EuiPageTemplate's outer wrapper (#9220)Bug fixes
EuiSuperDatePicker's time window buttons whencompressed={true}(#9245)EuiIconvisibility issue withlogoElasticwhencoloris set totextorghostin light mode (#9247)EuiInMemoryTablesupport for controlled search for plain text (whensearchFormat="text") by properly handlingsearch.queryandsearch.defaulQuery(#9142)Breaking changes
messageprop fromEuiInMemoryTable, usenoItemsMessageinstead (#9234)Accessibility
EuiSuperDatePickerby properly labeling them (#9239)EuiSelectableby removing emptyaria-activedescendantattribute when no option is active to ensure the search input is perceivable by screen readers (#9223)