Skip to content

move stats overview embeddable references to server#244240

Merged
nreese merged 11 commits intoelastic:mainfrom
nreese:stats_overview
Dec 4, 2025
Merged

move stats overview embeddable references to server#244240
nreese merged 11 commits intoelastic:mainfrom
nreese:stats_overview

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Nov 25, 2025

Part of #222615

Part of "Dashboards as code" project involves moving reference handling from client to server. References add complexity to dashboard REST API. Moving reference handling to server removes references from dashboard REST API.

This PR registers transformIn and transformOut methods for stats overview embeddable. On write, dashboard uses transformIn to extract drilldown references. On read, dashboard users transformOut to inject drilldown references. In this way, the REST API and stats overview embeddable client code no longer need to account for references as all reference handling is done on the server.

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 25, 2025

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 25, 2025

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 25, 2025

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 25, 2025

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 26, 2025

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 26, 2025

/ci

@nreese nreese marked this pull request as ready for review November 26, 2025 18:40
@nreese nreese requested a review from a team as a code owner November 26, 2025 18:40
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Dashboards API v9.3.0 labels Nov 26, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Dec 1, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Dec 3, 2025

@elasticmachine merge upstream

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Dec 4, 2025

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@baileycash-elastic baileycash-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synthetics embeddables and drilldown work as expected

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / should render about section for signal document
  • [job] [logs] Jest Tests #16 / AssetDocumentTab should select json tab when clicked
  • [job] [logs] FTR Configs #2 / discover/tabs tabs saving and loading multi-tab Discover sessions should locally persist unsaved changes to a multi-tab Discover session

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1375 1377 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.0MB 1.0MB +490.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 28.8KB 29.0KB +215.0B
Unknown metric groups

async chunk count

id before after diff
synthetics 16 17 +1

History

@nreese nreese merged commit 523e05b into elastic:main Dec 4, 2025
12 checks passed
wildemat pushed a commit to wildemat/kibana that referenced this pull request Dec 5, 2025
Part of elastic#222615

Part of "Dashboards as code" project involves moving reference handling
from client to server. References add complexity to dashboard REST API.
Moving reference handling to server removes references from dashboard
REST API.

This PR registers transformIn and transformOut methods for stats
overview embeddable. On write, dashboard uses `transformIn` to extract
drilldown references. On read, dashboard users `transformOut` to inject
drilldown references. In this way, the REST API and stats overview
embeddable client code no longer need to account for references as all
reference handling is done on the server.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
Part of elastic#222615

Part of "Dashboards as code" project involves moving reference handling
from client to server. References add complexity to dashboard REST API.
Moving reference handling to server removes references from dashboard
REST API.

This PR registers transformIn and transformOut methods for stats
overview embeddable. On write, dashboard uses `transformIn` to extract
drilldown references. On read, dashboard users `transformOut` to inject
drilldown references. In this way, the REST API and stats overview
embeddable client code no longer need to account for references as all
reference handling is done on the server.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Project:Dashboards API release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants