Skip to content

console: ingest node - add tag and update pipeline processor parameter#24400

Merged
jakelandis merged 4 commits intoelastic:masterfrom
jakelandis:more_ingest_node_console
Oct 23, 2018
Merged

console: ingest node - add tag and update pipeline processor parameter#24400
jakelandis merged 4 commits intoelastic:masterfrom
jakelandis:more_ingest_node_console

Conversation

@jakelandis
Copy link
Copy Markdown
Contributor

@jakelandis jakelandis commented Oct 23, 2018

The pipeline processor parameter had a last minute change: elastic/elasticsearch#34733
Also, including the tag as part of the common parameters as I forgot about it on the last PR.

EDIT: also included a fix for the script processor to autocomplete the non-deprecated parameter: https://www.elastic.co/guide/en/elasticsearch/reference/current/script-processor.html

@jakelandis jakelandis requested a review from bmcconaghy October 23, 2018 14:09
Copy link
Copy Markdown
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@bmcconaghy
Copy link
Copy Markdown
Contributor

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jakelandis jakelandis merged commit fcbeb02 into elastic:master Oct 23, 2018
bmcconaghy pushed a commit to bmcconaghy/kibana that referenced this pull request Oct 23, 2018
elastic#24400)

* console: ingest node - add tag and update pipeline processor parameter
bmcconaghy added a commit that referenced this pull request Oct 24, 2018
#24400) (#24445)

* console: ingest node - add tag and update pipeline processor parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants