[Controls Anywhere] Cleanup types#242044
Merged
Zacqary merged 58 commits intoelastic:controlsAnywherefrom Nov 12, 2025
Merged
Conversation
…tion_tests/ci_checks
…/kibana into controlsAnywhere-typefix
…sAnywhere-typefix # Conflicts: # src/platform/packages/shared/controls/controls-schemas/src/controls_group_schema.ts # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/get_options_list_control_factory.tsx # x-pack/platform/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/use_esql_variables.ts
Heenawter
reviewed
Nov 12, 2025
src/platform/plugins/shared/dashboard/public/dashboard_api/merge_control_group_states.test.ts
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
src/platform/plugins/shared/dashboard/public/dashboard_api/merge_control_group_states.ts
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
src/platform/plugins/shared/dashboard/public/dashboard_api/unified_search_manager.ts
Show resolved
Hide resolved
…/kibana into controlsAnywhere-typefix
…sAnywhere-typefix # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_api/merge_control_group_states.test.ts # src/platform/plugins/shared/dashboard/public/dashboard_api/merge_control_group_states.ts # x-pack/platform/plugins/shared/lens/public/app_plugin/save_modal_container_helpers.ts # x-pack/platform/plugins/shared/lens/tsconfig.json
Heenawter
reviewed
Nov 12, 2025
x-pack/platform/test/functional_with_es_ssl/apps/triggers_actions_ui/stack_alerts_page.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/lens/public/app_plugin/save_modal_container_helpers.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/dashboard/server/usage/register_collector.ts
Show resolved
Hide resolved
src/platform/plugins/shared/dashboard_markdown/public/create_markdown_action.tsx
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
src/platform/plugins/shared/dashboard/public/dashboard_api/unified_search_manager.ts
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
...lugins/shared/dashboard/server/content_management/v1/transforms/out/transform_options_out.ts
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
src/platform/plugins/shared/dashboard/public/dashboard_app/url/search_sessions_integration.ts
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
...latform/plugins/shared/dashboard/public/dashboard_app/url/bwc/extract_control_group_state.ts
Show resolved
Hide resolved
Heenawter
reviewed
Nov 12, 2025
...latform/plugins/shared/dashboard/public/dashboard_app/url/bwc/extract_control_group_state.ts
Show resolved
Hide resolved
Heenawter
approved these changes
Nov 12, 2025
Contributor
Heenawter
left a comment
There was a problem hiding this comment.
LGTM - thanks so much for tackling all the typing issues 🙇
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Zacqary
added a commit
that referenced
this pull request
Nov 13, 2025
## Summary Followup to #242044 Fixes some type failures that slipped through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This work is being merged into a feature branch, not main!
Because of this, we only need a review from @elastic/kibana-presentation for now.
Type failures are expected because the feature branch is currently in an incomplete state, where the controls that have not yet been converted are dependent on things that no longer exist.
Summary
Closes #241853
Fixes typecheck errors.
This PR exclusively focuses on getting a green typecheck, and NOT on getting all tests to pass. Jest and functional tests are still failing, and will be dealt with in a future PR.