[Controls Anywhere] Section-scoped controls#239221
Merged
Heenawter merged 30 commits intoelastic:controlsAnywherefrom Nov 4, 2025
Merged
[Controls Anywhere] Section-scoped controls#239221Heenawter merged 30 commits intoelastic:controlsAnywherefrom
Heenawter merged 30 commits intoelastic:controlsAnywherefrom
Conversation
c16b929 to
d93a829
Compare
d93a829 to
7caf5f3
Compare
…trolsAnywhere-filter-sections-only_2025-10-15
Heenawter
commented
Nov 3, 2025
Comment on lines
+93
to
+97
| // update the ES|QL query with new variables, if necessary | ||
| if (pendingQueryUpdate.current) { | ||
| onUpdateESQLQuery(pendingQueryUpdate.current); | ||
| pendingQueryUpdate.current = undefined; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This was somehow removed in a bad merge 🫠 So I'm re-adding it because it allows the query to update when a new variable control is added
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
…tion_tests/ci_checks
Zacqary
approved these changes
Nov 4, 2025
| apiIsPresentationContainer, | ||
| combineCompatibleChildrenApis, | ||
| getContainerParentFromAPI, | ||
| listenForCompatibleApi, |
Contributor
There was a problem hiding this comment.
We should remove this function entirely since nothing else is using it, or at least deprecate it if that's out of scope.
Contributor
Author
There was a problem hiding this comment.
Oops! I actually didn't mean to remove this. It's still used in an example embeddable 😄 Thanks for catching that
…thub.com:heenawter/kibana into controlsAnywhere-filter-sections-only_2025-10-15
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This work is being merged into a feature branch, not main!
Because of this, we only need a review from @elastic/kibana-presentation for now.
Closes #233124
Summary
This PR makes it so that controls only publish their filters and/or variables to panels within their sections. In order to do this, I had to add
metadata to variables, just like we have with filters. All of the filtering is happening via thefetch$observable, so I also had to do some work to ensure embeddables were using it as expected.Filters
Screen.Recording.2025-11-03.at.3.26.01.PM.mov
Variables
Screen.Recording.2025-11-03.at.3.23.18.PM.mov