Merged
Conversation
…urce-definitions/scripts/fix-location-collection.ts'
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update'
… into markov-2025_10_13-update_vega_6
dd9445b to
fd08d83
Compare
Contributor
💔 Build Failed
Failed CI StepsHistory
cc @markov00 |
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Dec 5, 2025
## Summary Update Vega dependencies to 6.x. This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions. **Dependency Upgrades and Import Handling** - Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and related libraries to their latest major versions in `package.json`, and updated their import paths throughout the codebase. - Removed legacy Webpack and Storybook configuration for the old `vega` build, including `noParse` rules and aliases, and updated the import resolver to point to the new `vega-lite` and `vega-tooltip` build directories. **Testing and TypeScript Support** - Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages. - Updated `tsconfig.base.json` to include type definitions for `vega-lite` and `vega-tooltip`. **Babel and Build Tools** - Added `@babel/plugin-syntax-import-attributes` to dependencies and Babel preset to enable the new import attributes syntax. **Test Snapshots** - Updated Vega visualization test snapshots to reflect the new rendering/output from upgraded dependencies. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit d8c23ae) # Conflicts: # package.json # src/platform/packages/shared/kbn-test/jest-preset.js
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Dec 5, 2025
## Summary Update Vega dependencies to 6.x. This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions. **Dependency Upgrades and Import Handling** - Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and related libraries to their latest major versions in `package.json`, and updated their import paths throughout the codebase. - Removed legacy Webpack and Storybook configuration for the old `vega` build, including `noParse` rules and aliases, and updated the import resolver to point to the new `vega-lite` and `vega-tooltip` build directories. **Testing and TypeScript Support** - Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages. - Updated `tsconfig.base.json` to include type definitions for `vega-lite` and `vega-tooltip`. **Babel and Build Tools** - Added `@babel/plugin-syntax-import-attributes` to dependencies and Babel preset to enable the new import attributes syntax. **Test Snapshots** - Updated Vega visualization test snapshots to reflect the new rendering/output from upgraded dependencies. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit d8c23ae) # Conflicts: # package.json # packages/kbn-babel-preset/common_preset.js # src/platform/packages/shared/kbn-test/jest-preset.js
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Dec 5, 2025
## Summary Update Vega dependencies to 6.x. This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions. **Dependency Upgrades and Import Handling** - Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and related libraries to their latest major versions in `package.json`, and updated their import paths throughout the codebase. - Removed legacy Webpack and Storybook configuration for the old `vega` build, including `noParse` rules and aliases, and updated the import resolver to point to the new `vega-lite` and `vega-tooltip` build directories. **Testing and TypeScript Support** - Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages. - Updated `tsconfig.base.json` to include type definitions for `vega-lite` and `vega-tooltip`. **Babel and Build Tools** - Added `@babel/plugin-syntax-import-attributes` to dependencies and Babel preset to enable the new import attributes syntax. **Test Snapshots** - Updated Vega visualization test snapshots to reflect the new rendering/output from upgraded dependencies. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit d8c23ae) # Conflicts: # .github/CODEOWNERS # package.json # packages/kbn-babel-preset/common_preset.js # packages/kbn-optimizer/src/worker/webpack.config.ts # src/platform/packages/shared/kbn-test/jest-preset.js # src/platform/plugins/private/vis_types/vega/public/__snapshots__/vega_visualization.test.tsx.snap
markov00
added a commit
that referenced
this pull request
Dec 5, 2025
# Backport This will backport the following commits from `main` to `9.2`: - [[deps] Update vega to 6.x (#238618)](#238618) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-12-05T11:23:58Z","message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","dependencies","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8"],"title":"[deps] Update vega to 6.x","number":238618,"url":"https://github.com/elastic/kibana/pull/238618","mergeCommit":{"message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238618","number":238618,"mergeCommit":{"message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
markov00
added a commit
that referenced
this pull request
Dec 5, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[deps] Update vega to 6.x (#238618)](#238618) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-12-05T11:23:58Z","message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","dependencies","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8"],"title":"[deps] Update vega to 6.x","number":238618,"url":"https://github.com/elastic/kibana/pull/238618","mergeCommit":{"message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238618","number":238618,"mergeCommit":{"message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Dec 5, 2025
## Summary Update Vega dependencies to 6.x. This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions. **Dependency Upgrades and Import Handling** - Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and related libraries to their latest major versions in `package.json`, and updated their import paths throughout the codebase. - Removed legacy Webpack and Storybook configuration for the old `vega` build, including `noParse` rules and aliases, and updated the import resolver to point to the new `vega-lite` and `vega-tooltip` build directories. **Testing and TypeScript Support** - Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages. - Updated `tsconfig.base.json` to include type definitions for `vega-lite` and `vega-tooltip`. **Babel and Build Tools** - Added `@babel/plugin-syntax-import-attributes` to dependencies and Babel preset to enable the new import attributes syntax. **Test Snapshots** - Updated Vega visualization test snapshots to reflect the new rendering/output from upgraded dependencies. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
This was referenced Dec 5, 2025
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
## Summary Update Vega dependencies to 6.x. This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions. **Dependency Upgrades and Import Handling** - Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and related libraries to their latest major versions in `package.json`, and updated their import paths throughout the codebase. - Removed legacy Webpack and Storybook configuration for the old `vega` build, including `noParse` rules and aliases, and updated the import resolver to point to the new `vega-lite` and `vega-tooltip` build directories. **Testing and TypeScript Support** - Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages. - Updated `tsconfig.base.json` to include type definitions for `vega-lite` and `vega-tooltip`. **Babel and Build Tools** - Added `@babel/plugin-syntax-import-attributes` to dependencies and Babel preset to enable the new import attributes syntax. **Test Snapshots** - Updated Vega visualization test snapshots to reflect the new rendering/output from upgraded dependencies. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
markov00
added a commit
that referenced
this pull request
Dec 9, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[deps] Update vega to 6.x (#238618)](#238618) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-12-05T11:23:58Z","message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Vega","Team:Visualizations","release_note:skip","dependencies","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8"],"title":"[deps] Update vega to 6.x","number":238618,"url":"https://github.com/elastic/kibana/pull/238618","mergeCommit":{"message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238618","number":238618,"mergeCommit":{"message":"[deps] Update vega to 6.x (#238618)\n\n## Summary\n\nUpdate Vega dependencies to 6.x.\n\nThis pull request updates the project's Vega and Vega-Lite dependencies\nto their latest major versions.\n\n**Dependency Upgrades and Import Handling**\n\n- Upgraded `vega`, `vega-lite`, `vega-interpreter`, `vega-tooltip`, and\nrelated libraries to their latest major versions in `package.json`, and\nupdated their import paths throughout the codebase.\n\n- Removed legacy Webpack and Storybook configuration for the old `vega`\nbuild, including `noParse` rules and aliases, and updated the import\nresolver to point to the new `vega-lite` and `vega-tooltip` build\ndirectories.\n\n**Testing and TypeScript Support**\n\n- Added a Jest setup mock for `vega` and `vega-lite` to ensure tests run\ncorrectly with the new versions, and updated Jest transform ignore\npatterns to support new Vega-related packages.\n- Updated `tsconfig.base.json` to include type definitions for\n`vega-lite` and `vega-tooltip`.\n\n**Babel and Build Tools**\n\n- Added `@babel/plugin-syntax-import-attributes` to dependencies and\nBabel preset to enable the new import attributes syntax.\n\n**Test Snapshots**\n\n- Updated Vega visualization test snapshots to reflect the new\nrendering/output from upgraded dependencies.\n\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"d8c23ae52c5b34b837ca89a4f49bd6d18b1ea324"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Vega dependencies to 6.x.
This pull request updates the project's Vega and Vega-Lite dependencies to their latest major versions.
Dependency Upgrades and Import Handling
Upgraded
vega,vega-lite,vega-interpreter,vega-tooltip, and related libraries to their latest major versions inpackage.json, and updated their import paths throughout the codebase.Removed legacy Webpack and Storybook configuration for the old
vegabuild, includingnoParserules and aliases, and updated the import resolver to point to the newvega-liteandvega-tooltipbuild directories.Testing and TypeScript Support
vegaandvega-liteto ensure tests run correctly with the new versions, and updated Jest transform ignore patterns to support new Vega-related packages.tsconfig.base.jsonto include type definitions forvega-liteandvega-tooltip.Babel and Build Tools
@babel/plugin-syntax-import-attributesto dependencies and Babel preset to enable the new import attributes syntax.Test Snapshots
### Dependency added@babel/plugin-syntax-import-attributes- [x] Purpose: This plugin allows Babel to parse the JavaScript Import Attributes syntax without transforming it.- [x] Justification: Vega 6 and Vega-Lite uses this import attribute syntax in multiple places, for examplehttps://github.com/vega/vega/blob/b89378d5b8ac3af85a2c2f51112345a1ba50db99/packages/vega/index.js#L24
- [x] Alternatives explored: I was trying using@babel/generator's as suggested here but wasn't able to properly make it working.- [x] Existing dependencies: As described above, it can probably be possible to use babel generators for that but it was not working.The initial use of
@babel/plugin-syntax-import-attributeswas replace with the use of@babel/generatoras suggested here