fix some voilations of @elastic/eui/consistent-is-invalid-props eslint rule#236763
Merged
alexwizp merged 3 commits intoelastic:mainfrom Sep 30, 2025
Merged
fix some voilations of @elastic/eui/consistent-is-invalid-props eslint rule#236763alexwizp merged 3 commits intoelastic:mainfrom
@elastic/eui/consistent-is-invalid-props eslint rule#236763alexwizp merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
@elastic/eui/no-unnamed-radio-group eslint rule
Contributor
damian-polewski
left a comment
There was a problem hiding this comment.
Hi @alexwizp, I think the PR description is not reflecting the changes made - I can see that you fixed two eslint(@elastic/eui/consistent-is-invalid-props) warnings. Is this some mixup?
@elastic/eui/no-unnamed-radio-group eslint rule@elastic/eui/consistent-is-invalid-props eslint rule
Contributor
Author
|
@damian-polewski thanks, my mistake, fixed description |
damian-polewski
approved these changes
Sep 30, 2025
Contributor
damian-polewski
left a comment
There was a problem hiding this comment.
Thanks for working on this! LGTM!
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed. (cherry picked from commit 25b903b)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
VladimirFilonov
pushed a commit
to VladimirFilonov/kibana
that referenced
this pull request
Sep 30, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed.
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2025
…s` eslint rule (#236763) (#236901) # Backport This will backport the following commits from `main` to `9.1`: - [fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)](#236763) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-09-30T09:07:58Z","message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:version","v9.2.0","v9.1.5"],"title":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule","number":236763,"url":"https://github.com/elastic/kibana/pull/236763","mergeCommit":{"message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236763","number":236763,"mergeCommit":{"message":"fix some voilations of `@elastic/eui/consistent-is-invalid-props` eslint rule (#236763)\n\nMost violations of the `@elastic/eui/consistent-is-invalid-props` ESLint\nrule were addressed in\n[#230068](#226787). This PR just\nresolves two remaining cases that were missed.","sha":"25b903b9cc4a62dc3f12c6b97e9d736e84599466"}},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…int rule (elastic#236763) Most violations of the `@elastic/eui/consistent-is-invalid-props` ESLint rule were addressed in [elastic#230068](elastic#226787). This PR just resolves two remaining cases that were missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most violations of the
@elastic/eui/consistent-is-invalid-propsESLint rule were addressed in #230068. This PR just resolves two remaining cases that were missed.