Skip to content

[Streams] Update Classic/Wired badge and forever ilm badge#235090

Merged
damian-polewski merged 8 commits intoelastic:mainfrom
damian-polewski:streams/update_classic_wired_forever_badges
Sep 23, 2025
Merged

[Streams] Update Classic/Wired badge and forever ilm badge#235090
damian-polewski merged 8 commits intoelastic:mainfrom
damian-polewski:streams/update_classic_wired_forever_badges

Conversation

@damian-polewski
Copy link
Copy Markdown
Contributor

@damian-polewski damian-polewski commented Sep 15, 2025 •
edited
Loading

Summary

Closes #233957

This PR updates Classic/Wired Stream badge and ILM Retention Forever badge.

Changes:

  • Updated Classic Stream badge and ILM Retention Forever badge
  • Added Wired Stream badge
  • Imported icon_stream_classic.svg and icon_stream_wired.svg
Screenshot 2025-09-16 at 09 17 59 Screenshot 2025-09-16 at 09 17 50

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@damian-polewski damian-polewski self-assigned this Sep 15, 2025
@damian-polewski damian-polewski added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project labels Sep 16, 2025
@damian-polewski damian-polewski marked this pull request as ready for review September 16, 2025 07:18
@damian-polewski damian-polewski requested review from a team as code owners September 16, 2025 07:18
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 16, 2025

Pinging @elastic/kibana-management (Team:Kibana Management)

@damian-polewski damian-polewski requested review from a team September 16, 2025 08:57
@damian-polewski damian-polewski mentioned this pull request Sep 17, 2025
Closed
@damian-polewski damian-polewski requested a review from a team September 17, 2025 08:32
@damian-polewski
Copy link
Copy Markdown
Contributor Author

damian-polewski commented Sep 22, 2025

We will import new icons for Classic and Wried stream badge directly until the ongoing mass exploitation of npm packages will end and new version of EUI will be release (containing elastic/eui#9017). After that we will create a follow-up PR to remove imported icons and replace them with EUI versions.

tonyghiani
tonyghiani approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ElenaStoeva
ElenaStoeva approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm (haven't tested locally)

@patpascal
Copy link
Copy Markdown
Contributor

patpascal commented Sep 22, 2025

Hi! The ILM should also have a clock icon on the left side of the badge - otherwise LGTM!

flash1293
flash1293 approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

florent-leborgne
florent-leborgne approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damian-polewski
Copy link
Copy Markdown
Contributor Author

damian-polewski commented Sep 22, 2025

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 22, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #41 / API Keys app Home page querying API keys active/expired filter buttons work as expected

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 682 684 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 756.2KB 762.7KB +6.5KB

History

cc @damian-polewski

@damian-polewski damian-polewski merged commit dc65417 into elastic:main Sep 23, 2025
12 checks passed
@damian-polewski damian-polewski deleted the streams/update_classic_wired_forever_badges branch September 23, 2025 06:44
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
@damian-polewski @CAWilson94
[Streams] Update Classic/Wired badge and forever ilm badge (elastic#2…
3d1a987 
…35090)

## Summary

Closes elastic#233957

This PR updates Classic/Wired Stream badge and ILM Retention Forever
badge.

Changes:

- Updated Classic Stream badge and ILM Retention Forever badge
- Added Wired Stream badge
- Imported `icon_stream_classic.svg` and `icon_stream_wired.svg`
niros1 pushed a commit that referenced this pull request Sep 30, 2025
@damian-polewski @niros1
[Streams] Update Classic/Wired badge and forever ilm badge (#235090)
bf8ccf7 
## Summary

Closes #233957

This PR updates Classic/Wired Stream badge and ILM Retention Forever
badge.

Changes:

- Updated Classic Stream badge and ILM Retention Forever badge
- Added Wired Stream badge
- Imported `icon_stream_classic.svg` and `icon_stream_wired.svg`
@ElenaStoeva ElenaStoeva mentioned this pull request Sep 30, 2025
Closed
@damian-polewski damian-polewski mentioned this pull request Oct 10, 2025
Merged
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
@damian-polewski
[Streams] Update Classic/Wired badge and forever ilm badge (elastic#2…
f79798f 
…35090)

## Summary

Closes elastic#233957

This PR updates Classic/Wired Stream badge and ILM Retention Forever
badge.

Changes:

- Updated Classic Stream badge and ILM Retention Forever badge
- Added Wired Stream badge
- Imported `icon_stream_classic.svg` and `icon_stream_wired.svg`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@patpascal patpascal patpascal approved these changes

Assignees

@damian-polewski damian-polewski

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Streams] Add Wired/Classic badge to header and update Forever badge

8 participants

@damian-polewski @elasticmachine @patpascal @flash1293 @florent-leborgne @tonyghiani @ElenaStoeva @kibanamachine