Skip to content

[ML] Fixing various issues when cloning a job using a wizard#23368

Merged
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:fixing-job-cloning-issues
Sep 21, 2018
Merged

[ML] Fixing various issues when cloning a job using a wizard#23368
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:fixing-job-cloning-issues

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Sep 20, 2018

Fixes:

  • When cloning a job which uses high/low count. Count would mistakenly be used instead.
  • Cloning a distinct count job would fail.
  • When jumping from a wizard to the advanced job page, the created_by setting would be retained. Subsequent cloning of that job would cause it to use a wizard rather than the advanced page.

Fixes #23272

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.5.0 labels Sep 20, 2018
@jgowdyelastic jgowdyelastic self-assigned this Sep 20, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 20, 2018

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 20, 2018

💔 Build Failed

@jgowdyelastic
Copy link
Copy Markdown
Member Author

jgowdyelastic commented Sep 20, 2018

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 20, 2018

💚 Build Succeeded

peteharverson
peteharverson approved these changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jgowdyelastic jgowdyelastic merged commit ec49c36 into elastic:master Sep 21, 2018
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 21, 2018
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 21, 2018
@jgowdyelastic
[ML] Fixing various issues when cloning a job using a wizard (elastic…
e18482d 
…#23368)
jgowdyelastic added a commit that referenced this pull request Sep 22, 2018
@jgowdyelastic
[ML] Fixing various issues when cloning a job using a wizard (#23368) (…
848de4d 
…#23412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels

bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v6.5.0 v7.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson