user email validation#23346
Merged
rashmivkulkarni merged 6 commits intoelastic:masterfrom Sep 24, 2018
Merged
Conversation
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
cuff-links
reviewed
Sep 21, 2018
Contributor
cuff-links
left a comment
There was a problem hiding this comment.
I just have an additional comment. There should probably be some condition that you wait for at the end of changePassword. Basically, the way it is now, the tests might have the tendency to be flaky because there are no waits, nor retries. So if something isn't ready, it will just fail.
Contributor
💚 Build Succeeded |
Contributor
Author
|
jenkins, test this |
LeeDr
approved these changes
Sep 21, 2018
LeeDr
left a comment
There was a problem hiding this comment.
LGTM after removing the duplicate test
| expect(users.anonymous.reserved).to.be(true); | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
This test is already in x-pack/test/functional/apps/security/users.js:. I think you started from that file and forgot to take this out?
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Sep 24, 2018
* Added automation for a support-dev-help ticket - user email validation https://github.com/elastic/support-dev-help/issues/4571
This was referenced Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-test-subjwhere ever required.in support of a SDH ticket opened a while back.