Create re-usable IndexPatternSelect component#23335
Merged
nreese merged 3 commits intoelastic:masterfrom Sep 21, 2018
Merged
Conversation
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
chrisdavies
approved these changes
Sep 21, 2018
Contributor
chrisdavies
left a comment
There was a problem hiding this comment.
LGTM. I didn't pull down and test, though.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 21, 2018
* Migrate index pattern select to ui/public/index_patterns * get rest of jest tests working * migrate remaining part of IndexPatternSelect to IndexPatternSelectFormRow
nreese
added a commit
that referenced
this pull request
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input controls has an IndexPatternSelect component. The Kibana GIS application will need the same functionality. This PR refactors the input controls IndexPatternSelect component into a more generic component that is placed in
ui/public/index_patternsso it is accessible by other plugins.