Skip to content

Remove nesting-indicator directive#23180

Merged
timroes merged 2 commits intoelastic:masterfrom
timroes:remove-nesting-indicator
Sep 14, 2018
Merged

Remove nesting-indicator directive#23180
timroes merged 2 commits intoelastic:masterfrom
timroes:remove-nesting-indicator

Conversation

@timroes
Copy link
Copy Markdown
Contributor

@timroes timroes commented Sep 14, 2018

This PR removes the apparently unused nesting-indicator directive. I think this was used earlier for the colorful sidebars in the editor, that doesn't exist anymore.

cc @cchaos

@timroes timroes added chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 v6.5.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Sep 14, 2018
@timroes timroes mentioned this pull request Sep 14, 2018
Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any other reference to the nesting-indicator directive on code. LGTM.

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

Copy link
Copy Markdown
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@timroes timroes merged commit dbca0c5 into elastic:master Sep 14, 2018
@timroes timroes deleted the remove-nesting-indicator branch September 14, 2018 13:24
timroes added a commit to timroes/kibana that referenced this pull request Sep 14, 2018
* Remove nesting-indicator directive

* Remove broken import
timroes added a commit that referenced this pull request Sep 14, 2018
* Remove nesting-indicator directive

* Remove broken import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v6.5.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants