Merged
Conversation
Member
Author
|
@elasticmachine merge upstream |
…e aware of the `overwrite` copy mode being available only when `createNewCopies` is false
Member
Author
|
@elasticmachine merge upstream |
tkajtoch
commented
Aug 1, 2025
| const label = await form.findByCssSelector('label[for="createNewCopiesDisabled"]'); | ||
| await label.click(); | ||
|
|
||
| if (!overwrite) { |
Member
Author
There was a problem hiding this comment.
This change is needed since the original test logic was executing clicks on disabled overwrite inputs.
Historically, this was a no-op, and executing the click had no adverse effects. With the recent change to EuiCheckableCard when there are no child interactive elements, clicking on the card results in selection of its radio button. A disabled input is considered non-interactive, which is the reason why this started failing.
Contributor
|
Pinging @elastic/eui-team (EUI) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
cc @tkajtoch |
SiddharthMantri
approved these changes
Aug 5, 2025
dokmic
approved these changes
Aug 5, 2025
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([elastic#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([elastic#8889](elastic/eui#8889)) ([elastic#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([elastic#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([elastic#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
`106.1.0` ⏩ `106.2.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v106.2.0`](https://github.com/elastic/eui/releases/v106.2.0) - Enhanced `EuiCheckableCard` to make non-interactive children clickable for card selection ([elastic#8907](elastic/eui#8907)) - Added `showFooter` and `toolbarProps.right` props to `EuiMarkdownEditor` for more flexible layout control. ([elastic#8889](elastic/eui#8889)) ([elastic#8889](elastic/eui#8889)) **Bug fixes** - Fixed `EuiPopover` not closing on outside click after multiple fast clicks on the trigger element ([elastic#8882](elastic/eui#8882)) **Accessibility** - Added accessible labels to virtualized `EuiCodeBlock` ([elastic#8887](elastic/eui#8887)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
106.1.0⏩106.2.0Questions? Please see our Kibana upgrade FAQ.
Package updates
@elastic/euiv106.2.0EuiCheckableCardto make non-interactive children clickable for card selection (#8907)showFooterandtoolbarProps.rightprops toEuiMarkdownEditorfor more flexible layout control. (#8889) (#8889)Bug fixes
EuiPopovernot closing on outside click after multiple fast clicks on the trigger element (#8882)Accessibility
EuiCodeBlock(#8887)