Attempt to fix flaky rbac tests#22852
Merged
legrego merged 1 commit intoelastic:masterfrom Sep 10, 2018
Merged
Conversation
Contributor
|
Why use the UI to create the vis at all for this? A simple non-flaky api call should tell you what you need to know. |
Member
Author
|
We have API test suites covering all of the backend functionality, these couple of UI tests were just meant as end-to-end tests to make sure everything is wired together correctly on the front end as well |
Contributor
💚 Build Succeeded |
Member
Author
|
retest |
Contributor
💔 Build Failed |
Member
Author
|
Unrelated failure (chrome failed to start) Jenkins retest this |
Contributor
💚 Build Succeeded |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Sep 10, 2018
legrego
added a commit
that referenced
this pull request
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were not using the common way to create a new viz