[Security Solution] Fix Cypress test error by forcing enter after typing into input field by jkelas · Pull Request #228517 · elastic/kibana

jkelas · 2025-07-17T20:18:57Z

Resolves: #227885

Summary

Fixing Cypress test issue and unskipping the test.
The fault was introduced most probably by the upgrade of EUI in the following commit.

commit eca0d1c9d4fd511b36787260461eee1dd3c4553f (HEAD)
Author: Arturo Castillo Delgado <arturo.castillo@elastic.co>
Date:   Mon Jul 14 16:25:22 2025 +0200

    Upgrade EUI to v105.0.0 (#226882)

In Cypress the fault reported itself by not finding the progress bar icon, but that was due to an issue with filling the email input field (which made the flyout not close properly, reporting an input error, and the test was expecting the elements of the rule table below, which was not shown).

I am fixing it by forcing the enter key, like it is already done in other places in the code.

Testing:

Run Cypress test

yarn cypress:open:ess --spec ./cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

jkelas · 2025-07-18T06:06:40Z

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8703/steps/canvas

elasticmachine · 2025-07-18T06:06:50Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine · 2025-07-18T06:06:51Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2025-07-18T06:06:52Z

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

kibanamachine · 2025-07-18T08:27:03Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8703

[✅] Security Solution Rule Management - Cypress: 100/100 tests passed.
[✅] [Serverless] Security Solution Rule Management - Cypress: 100/100 tests passed.

see run history

jkelas · 2025-07-18T13:53:14Z

Removed the labels, as advised by @mgadewoll
The EUI update, causing this issue, wasn't backported to other branches.

dplumlee

LGTM @jkelas

elasticmachine · 2025-07-18T18:14:31Z

💚 Build Succeeded

Buildkite Build
Commit: a537682

Metrics [docs]

✅ unchanged

History

💔 Build #320886 failed 8737c03
💚 Build #320677 succeeded bae6fea
💚 Build #320628 succeeded 17c7ce1

cc @jkelas

…ing into input field (elastic#228517) **Resolves: elastic#227885** ## Summary Fixing Cypress test issue and unskipping the test. The fault was introduced most probably by the upgrade of EUI in the following commit. ``` commit eca0d1c (HEAD) Author: Arturo Castillo Delgado <arturo.castillo@elastic.co> Date: Mon Jul 14 16:25:22 2025 +0200 Upgrade EUI to v105.0.0 (elastic#226882) ``` In Cypress the fault reported itself by not finding the progress bar icon, but that was due to an issue with filling the `email` input field (which made the flyout not close properly, reporting an input error, and the test was expecting the elements of the rule table below, which was not shown). I am fixing it by forcing the `enter` key, like it is already done in other places in the code. # Testing: Run Cypress test `yarn cypress:open:ess --spec ./cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts ` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.

`@elastic/eui`: `106.0.0` ⏩ `106.1.0` `@elastic/eslint-plugin-eui`: `2.1.0` ⏩ `2.2.1` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) New props and defaults have been added to `EuiFlyout`, including `includeSelectorInFocusTrap`, plus new global CSS variables for push mode offset control. Additionally, we introduced a small spacing fix for invalid `EuiDualRange` append component and added support for custom styles on `EuiTreeView` nodes via the css key. :warning: **React 16 is now deprecated:** EUI no longer tests against it or fixes issues specific to it. ## Changes - I removed forced click in: `x-pack/test/security_solution_cypress/cypress/tasks/rule_details.ts` - I removed `{enter}` in: `x-pack/test/security_solution_cypress/cypress/tasks/common/rule_actions.ts` (see #228517) ## Package updates ### `@elastic/eui` #### [`v106.1.0`](https://github.com/elastic/eui/releases/v106.1.0) - Added `--euiPushFlyoutOffsetInlineStart` and `--euiPushFlyoutOffsetInlineEnd` global CSS variables set by the `EuiFlyout` in `push` mode. ([#8872](elastic/eui#8872)) - Reduced the `min-width` for inputs in `EuiRange` and `EuiDualRange` ([#8866](elastic/eui#8866)) - Added `includeSelectorInFocusTrap` prop for `EuiFlyout` ([#8849](elastic/eui#8849)) - Added component defaults for `EuiFlyout` that include `includeSelectorInFocusTrap` and `includeFixedHeadersInFocusTrap` ([#8849](elastic/eui#8849)) **Bug fixes** - Fixed flaky manual return focus behavior on `EuiFlyout` by relying on `FocusTrap` returning focus instead ([#8878](elastic/eui#8878)) - Fixed `EuiFlyoutChild` closing its parent `EuiFlyout` on `Escape` keypress ([#8878](elastic/eui#8878)) - Fixed support for `css` key in items object passed to `EuiTreeView` ([#8864](elastic/eui#8864)) **Deprecations** - Deprecated support for React 16. Please update to a modern version of React or stay on EUI version 106.0.0 if you can't switch right now. ([#8868](elastic/eui#8868)) ### `@elastic/eslint-plugin-eui` #### [`v2.2.1`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.1) **Bug fixes** - Removed `no-css_color` entry which mapped to a duplicate `no-css-color` rule ([#8888](elastic/eui#8888)) #### [`v2.2.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.0) - Added new `prefer-eui-icon-tip` rule. ([#8877](elastic/eui#8877))

…ing into input field (elastic#228517) **Resolves: elastic#227885** ## Summary Fixing Cypress test issue and unskipping the test. The fault was introduced most probably by the upgrade of EUI in the following commit. ``` commit eca0d1c (HEAD) Author: Arturo Castillo Delgado <arturo.castillo@elastic.co> Date: Mon Jul 14 16:25:22 2025 +0200 Upgrade EUI to v105.0.0 (elastic#226882) ``` In Cypress the fault reported itself by not finding the progress bar icon, but that was due to an issue with filling the `email` input field (which made the flyout not close properly, reporting an input error, and the test was expecting the elements of the rule table below, which was not shown). I am fixing it by forcing the `enter` key, like it is already done in other places in the code. # Testing: Run Cypress test `yarn cypress:open:ess --spec ./cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts ` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.

`@elastic/eui`: `106.0.0` ⏩ `106.1.0` `@elastic/eslint-plugin-eui`: `2.1.0` ⏩ `2.2.1` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) New props and defaults have been added to `EuiFlyout`, including `includeSelectorInFocusTrap`, plus new global CSS variables for push mode offset control. Additionally, we introduced a small spacing fix for invalid `EuiDualRange` append component and added support for custom styles on `EuiTreeView` nodes via the css key. :warning: **React 16 is now deprecated:** EUI no longer tests against it or fixes issues specific to it. ## Changes - I removed forced click in: `x-pack/test/security_solution_cypress/cypress/tasks/rule_details.ts` - I removed `{enter}` in: `x-pack/test/security_solution_cypress/cypress/tasks/common/rule_actions.ts` (see elastic#228517) ## Package updates ### `@elastic/eui` #### [`v106.1.0`](https://github.com/elastic/eui/releases/v106.1.0) - Added `--euiPushFlyoutOffsetInlineStart` and `--euiPushFlyoutOffsetInlineEnd` global CSS variables set by the `EuiFlyout` in `push` mode. ([elastic#8872](elastic/eui#8872)) - Reduced the `min-width` for inputs in `EuiRange` and `EuiDualRange` ([elastic#8866](elastic/eui#8866)) - Added `includeSelectorInFocusTrap` prop for `EuiFlyout` ([elastic#8849](elastic/eui#8849)) - Added component defaults for `EuiFlyout` that include `includeSelectorInFocusTrap` and `includeFixedHeadersInFocusTrap` ([elastic#8849](elastic/eui#8849)) **Bug fixes** - Fixed flaky manual return focus behavior on `EuiFlyout` by relying on `FocusTrap` returning focus instead ([elastic#8878](elastic/eui#8878)) - Fixed `EuiFlyoutChild` closing its parent `EuiFlyout` on `Escape` keypress ([elastic#8878](elastic/eui#8878)) - Fixed support for `css` key in items object passed to `EuiTreeView` ([elastic#8864](elastic/eui#8864)) **Deprecations** - Deprecated support for React 16. Please update to a modern version of React or stay on EUI version 106.0.0 if you can't switch right now. ([elastic#8868](elastic/eui#8868)) ### `@elastic/eslint-plugin-eui` #### [`v2.2.1`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.1) **Bug fixes** - Removed `no-css_color` entry which mapped to a duplicate `no-css-color` rule ([elastic#8888](elastic/eui#8888)) #### [`v2.2.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.0) - Added new `prefer-eui-icon-tip` rule. ([elastic#8877](elastic/eui#8877))

jkelas self-assigned this Jul 17, 2025

jkelas force-pushed the 227885_cypress_bulk_edit_rule_actions branch from 17c7ce1 to bae6fea Compare July 17, 2025 20:41

jkelas added v9.1.0 v8.19.0 v9.2.0 v8.18.4 v9.0.4 labels Jul 17, 2025

jkelas marked this pull request as ready for review July 18, 2025 06:06

jkelas requested a review from a team as a code owner July 18, 2025 06:06

jkelas requested a review from dplumlee July 18, 2025 06:06

banderror added test and removed bug Fixes for quality problems that affect the customer experience labels Jul 18, 2025

jkelas removed v9.1.0 v8.19.0 v8.18.4 v9.0.4 labels Jul 18, 2025

mgadewoll mentioned this pull request Jul 18, 2025

[EuiFlyout] Fix flaky return focus and child flyouts closing their parent flyouts elastic/eui#8878

Merged

16 tasks

jkelas removed the backport:version Backport to applied version labels label Jul 18, 2025

jkelas force-pushed the 227885_cypress_bulk_edit_rule_actions branch from bae6fea to 8737c03 Compare July 18, 2025 13:54

jkelas added the backport:skip This PR does not require backporting label Jul 18, 2025

dplumlee approved these changes Jul 18, 2025

View reviewed changes

jkelas enabled auto-merge (squash) July 18, 2025 15:36

Fix Cypress test error by forcing enter after typing into input field

a537682

jkelas force-pushed the 227885_cypress_bulk_edit_rule_actions branch from 8737c03 to a537682 Compare July 18, 2025 15:59

jkelas merged commit 4f6bede into elastic:main Jul 18, 2025
12 checks passed

weronikaolejniczak mentioned this pull request Jul 22, 2025

Upgrade EUI to v106.1.0 and ESLint plugin to v2.2.1 #228828

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Fix Cypress test error by forcing enter after typing into input field#228517

[Security Solution] Fix Cypress test error by forcing enter after typing into input field#228517
jkelas merged 1 commit intoelastic:mainfrom
jkelas:227885_cypress_bulk_edit_rule_actions

jkelas commented Jul 17, 2025

Uh oh!

jkelas commented Jul 18, 2025

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

kibanamachine commented Jul 18, 2025

Uh oh!

jkelas commented Jul 18, 2025

Uh oh!

dplumlee left a comment

Uh oh!

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jkelas commented Jul 17, 2025

Summary

Testing:

Checklist

Uh oh!

jkelas commented Jul 18, 2025

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

elasticmachine commented Jul 18, 2025

Uh oh!

kibanamachine commented Jul 18, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8703

Uh oh!

jkelas commented Jul 18, 2025

Uh oh!

dplumlee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jul 18, 2025

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants