[ES|QL] Fix empty editor syntax error bug#228482
Merged
drewdaemon merged 36 commits intoelastic:mainfrom Jul 18, 2025
Merged
Conversation
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
|
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2025
## Summary Fix elastic#228244 The "empty query" syntax error should be suppressed in Kibana. elastic#225751 introduced a regression to this behavior. This PR reinstates the old behavior and hopefully makes the intent of test case clearer. (cherry picked from commit f19783f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2025
## Summary Fix elastic#228244 The "empty query" syntax error should be suppressed in Kibana. elastic#225751 introduced a regression to this behavior. This PR reinstates the old behavior and hopefully makes the intent of test case clearer. (cherry picked from commit f19783f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[ES|QL] Fix empty editor syntax error bug (#228482)](#228482) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-07-18T15:13:57Z","message":"[ES|QL] Fix empty editor syntax error bug (#228482)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/228244\n\nThe \"empty query\" syntax error should be suppressed in Kibana.\nhttps://github.com//pull/225751 introduced a regression to\nthis behavior.\n\nThis PR reinstates the old behavior and hopefully makes the intent of\ntest case clearer.","sha":"f19783f87e192eed0e52a480e92d7a8518959a29","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL] Fix empty editor syntax error bug","number":228482,"url":"https://github.com/elastic/kibana/pull/228482","mergeCommit":{"message":"[ES|QL] Fix empty editor syntax error bug (#228482)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/228244\n\nThe \"empty query\" syntax error should be suppressed in Kibana.\nhttps://github.com//pull/225751 introduced a regression to\nthis behavior.\n\nThis PR reinstates the old behavior and hopefully makes the intent of\ntest case clearer.","sha":"f19783f87e192eed0e52a480e92d7a8518959a29"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228482","number":228482,"mergeCommit":{"message":"[ES|QL] Fix empty editor syntax error bug (#228482)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/228244\n\nThe \"empty query\" syntax error should be suppressed in Kibana.\nhttps://github.com//pull/225751 introduced a regression to\nthis behavior.\n\nThis PR reinstates the old behavior and hopefully makes the intent of\ntest case clearer.","sha":"f19783f87e192eed0e52a480e92d7a8518959a29"}}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
4 tasks
Contributor
|
Thanx for fixing this Drew! |
kibanamachine
added a commit
that referenced
this pull request
Jul 22, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] Fix empty editor syntax error bug (#228482)](#228482) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-07-18T15:13:57Z","message":"[ES|QL] Fix empty editor syntax error bug (#228482)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/228244\n\nThe \"empty query\" syntax error should be suppressed in Kibana.\nhttps://github.com//pull/225751 introduced a regression to\nthis behavior.\n\nThis PR reinstates the old behavior and hopefully makes the intent of\ntest case clearer.","sha":"f19783f87e192eed0e52a480e92d7a8518959a29","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL] Fix empty editor syntax error bug","number":228482,"url":"https://github.com/elastic/kibana/pull/228482","mergeCommit":{"message":"[ES|QL] Fix empty editor syntax error bug (#228482)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/228244\n\nThe \"empty query\" syntax error should be suppressed in Kibana.\nhttps://github.com//pull/225751 introduced a regression to\nthis behavior.\n\nThis PR reinstates the old behavior and hopefully makes the intent of\ntest case clearer.","sha":"f19783f87e192eed0e52a480e92d7a8518959a29"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228482","number":228482,"mergeCommit":{"message":"[ES|QL] Fix empty editor syntax error bug (#228482)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/228244\n\nThe \"empty query\" syntax error should be suppressed in Kibana.\nhttps://github.com//pull/225751 introduced a regression to\nthis behavior.\n\nThis PR reinstates the old behavior and hopefully makes the intent of\ntest case clearer.","sha":"f19783f87e192eed0e52a480e92d7a8518959a29"}}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary Fix elastic#228244 The "empty query" syntax error should be suppressed in Kibana. elastic#225751 introduced a regression to this behavior. This PR reinstates the old behavior and hopefully makes the intent of test case clearer.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Fix elastic#228244 The "empty query" syntax error should be suppressed in Kibana. elastic#225751 introduced a regression to this behavior. This PR reinstates the old behavior and hopefully makes the intent of test case clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #228244
The "empty query" syntax error should be suppressed in Kibana. #225751 introduced a regression to this behavior.
This PR reinstates the old behavior and hopefully makes the intent of test case clearer.