Skip to content

Allow filtering on multiple visualizations in the dashboard.#2280

Merged
rashidkpc merged 3 commits intoelastic:masterfrom
stormpython:fix/#2255
Dec 12, 2014
Merged

Allow filtering on multiple visualizations in the dashboard.#2280
rashidkpc merged 3 commits intoelastic:masterfrom
stormpython:fix/#2255

Conversation

@stormpython
Copy link
Copy Markdown
Contributor

Closes #2255.

The issue reoccurred because a d3 selection did not exist in all cases. The fix here simply deletes that code. It isn't necessary and further complicates that particular function.

Tests still need to get in for this, but there is an open issue #2208.

@simianhacker
Copy link
Copy Markdown
Member

LGTM... I tested all the issues that appeared in #2255 and they seem to be fixed by this.

@rashidkpc
Copy link
Copy Markdown
Contributor

This fixed the crash, but I still get an empty box. We should get a message here

image

@stormpython
Copy link
Copy Markdown
Contributor Author

@rashidkpc since this issue is related to the vislib not getting any data, I am not going to add another commit here to fix the issue above. I opened issue #2297.

@rashidkpc
Copy link
Copy Markdown
Contributor

Ok, I'm fine merging this then given the new ticket.

rashidkpc added a commit that referenced this pull request Dec 12, 2014
Allow filtering on multiple visualizations in the dashboard.
@rashidkpc rashidkpc merged commit e8da49f into elastic:master Dec 12, 2014
@stormpython stormpython deleted the fix/#2255 branch February 10, 2015 14:41
edmarmoretti pushed a commit to edmarmoretti/kibana-pt-br that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vislib/Dashboard - adding/removing filters causes visualizations not to re-draw

4 participants