Merged
Conversation
This comment has been minimized.
This comment has been minimized.
9ee3f45 to
33212af
Compare
90b506f to
56262f7
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
Contributor
|
Oops, I've accidentally merged PR instead of approving 🤦♂️ |
azasypkin
reviewed
Sep 11, 2018
Contributor
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates TypeScript to version 3.0.3, from 2.9.2. The features in 3.0 are described here, but I don't see any mention of breaking changes. The only things that really needed tweaking were TSLint related:
no-unused-varsrule is more aggressively deprecated, printing warnings when used, so I've updated the tsconfig.json and tslint.yaml files to move the check to the tsc. This means that unused variables will not be caught by the pre-commit hook but will still be noticed in IDEs and on CI.no-consoleseems to complain about simply referencingconsole.lognowradixcomplains when usingNumber.parseInt(), not justwindow.parseInt()