Skip to content

[ES|QL] Parser converter improvements#227653

Merged
vadimkibana merged 18 commits intoelastic:mainfrom
vadimkibana:esql/converter-4
Jul 14, 2025
Merged

[ES|QL] Parser converter improvements#227653
vadimkibana merged 18 commits intoelastic:mainfrom
vadimkibana:esql/converter-4

Conversation

@vadimkibana
Copy link
Copy Markdown
Contributor

@vadimkibana vadimkibana commented Jul 11, 2025 •
edited
Loading

Summary

Partially addresses #222505

  • Improves the parser CST-to-AST converter and fixes some bugs.
  • Moves all remaining "factories" and "walkers" to the converter class.
  • Removes RERANK command parsing.
  • Leaves plenty of TODOs for a followup in the CstToAstConverter class.

Checklist

  • Documentation was added for features that require explanation or tutorials

@vadimkibana
Copy link
Copy Markdown
Contributor Author

vadimkibana commented Jul 11, 2025

/ci

@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.2.0 labels Jul 11, 2025
@vadimkibana vadimkibana marked this pull request as ready for review July 11, 2025 13:06
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 11, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana vadimkibana requested a review from a team as a code owner July 11, 2025 13:06
@vadimkibana vadimkibana enabled auto-merge (squash) July 11, 2025 13:06
stratoula
stratoula approved these changes Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

src/platform/packages/shared/kbn-esql-ast/src/parser/constants.ts

/**
* @todo Move this out of the parser/ folder.
*/
Copy link
Copy Markdown
Contributor

@stratoula stratoula Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍

@vadimkibana vadimkibana merged commit 394d0de into elastic:main Jul 14, 2025
11 of 12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 14, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7684 7676 -8
unifiedSearch 438 430 -8
total -16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.8MB 3.8MB +3.2KB
securitySolution 94.3KB 94.3KB +1.0B
total +3.2KB

History

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
@vadimkibana @Bluefinger
[ES|QL] Parser converter improvements (elastic#227653)
7ac8ba3 
## Summary

Partially addresses elastic#222505

- Improves the parser CST-to-AST converter and fixes some bugs.
- Moves all remaining "factories" and "walkers" to the converter class.
- Removes `RERANK` command parsing.
- Leaves plenty of TODOs for a followup in the `CstToAstConverter`
class.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@vadimkibana @kertal
[ES|QL] Parser converter improvements (elastic#227653)
ea0bb2e 
## Summary

Partially addresses elastic#222505

- Improves the parser CST-to-AST converter and fixes some bugs.
- Moves all remaining "factories" and "walkers" to the converter class.
- Removes `RERANK` command parsing.
- Leaves plenty of TODOs for a followup in the `CstToAstConverter`
class.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana t// v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vadimkibana @elasticmachine @stratoula