Skip to content

chore: update @elastic/eslint-plugin-eui to v2.1.0#227638

Merged
weronikaolejniczak merged 1 commit intoelastic:mainfrom
weronikaolejniczak:eslint-plugin-eui-v2.1.0
Jul 15, 2025
Merged

chore: update @elastic/eslint-plugin-eui to v2.1.0#227638
weronikaolejniczak merged 1 commit intoelastic:mainfrom
weronikaolejniczak:eslint-plugin-eui-v2.1.0

Conversation

@weronikaolejniczak
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak commented Jul 11, 2025 •
edited
Loading

@elastic/eslint-plugin-eui: 2.0.0 ⏩ 2.1.0

Questions? Please see our Kibana upgrade FAQ.

Changes

This PR updates the @elastic/eslint-plugin-eui version to latest: v2.1.0

@elastic/eui/require-aria-label-for-modals (fixed with GenAI: #227623)

Ensures that EUI modal components (EuiModal, EuiFlyout, EuiConfirmModal) have either an aria-label or aria-labelledby prop for accessibility. This helps screen reader users understand the purpose and content of modal dialogs.

@elastic/eui/consistent-is-invalid-props (auto-fix available)

Ensures that form control components within EuiFormRow components have matching isInvalid prop values. This maintains consistent validation state between parent form rows and their child form controls, leading to a more predictable and accessible user experience.

@elastic/eui/sr_output_disabled_tooltip (auto-fix available)

Ensures disableScreenReaderOutput is set when EuiToolTip content matches EuiButtonIcon's aria-label.

Note

@elastic/eui/sr_output_disabled_tooltip will be renamed to @elastic/eui/sr-output-disabled-tooltip for consistent rule naming.

Package updates

@elastic/eslint-plugin-eui

  • Added new sr_output_disabled_tooltip rule. (#8848)
  • Added new consistent-is-invalid-props rule. (#8843)
  • Added new require-aria-label-for-modals rule. (#8811)

@weronikaolejniczak weronikaolejniczak added backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes labels Jul 11, 2025
@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.1.0 branch from e433597 to 46bfbbb Compare July 11, 2025 12:27
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review July 11, 2025 12:57
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 11, 2025

Pinging @elastic/eui-team (EUI)

@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.1.0 branch from 46bfbbb to ea6ce13 Compare July 11, 2025 16:53
@weronikaolejniczak weronikaolejniczak requested a review from a team July 11, 2025 17:19
mgadewoll
mgadewoll approved these changes Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM

@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.1.0 branch 4 times, most recently from da0f58a to 6fd2481 Compare July 15, 2025 07:57
@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) July 15, 2025 08:30
@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.1.0 branch 2 times, most recently from 8ddeaf1 to 6c66d6b Compare July 15, 2025 14:10
@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.1.0 branch from 6c66d6b to 7d443cd Compare July 15, 2025 16:37
@weronikaolejniczak weronikaolejniczak merged commit e73fbdc into elastic:main Jul 15, 2025
14 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 15, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Search solution tests Search Home page Solution Nav - Search search home page with existing indices "before each" hook for "renders Elasticsearch Documentation content"

Metrics [docs]

✅ unchanged

History

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
@weronikaolejniczak @Bluefinger
chore: update @elastic/eslint-plugin-eui to v2.1.0 (elastic#227638)
02c99f0 
`@elastic/eslint-plugin-eui`: `2.0.0` ⏩ `2.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

This PR updates the `@elastic/eslint-plugin-eui` version to latest:
[`v2.1.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.1.0)

### `@elastic/eui/require-aria-label-for-modals` (fixed with GenAI:
elastic#227623)

Ensures that EUI modal components (`EuiModal`, `EuiFlyout`,
`EuiConfirmModal`) have either an `aria-label` or `aria-labelledby` prop
for accessibility. This helps screen reader users understand the purpose
and content of modal dialogs.

### `@elastic/eui/consistent-is-invalid-props` (auto-fix available)

Ensures that form control components within `EuiFormRow` components have
matching `isInvalid` prop values. This maintains consistent validation
state between parent form rows and their child form controls, leading to
a more predictable and accessible user experience.

### `@elastic/eui/sr_output_disabled_tooltip` (auto-fix available)

Ensures `disableScreenReaderOutput` is set when `EuiToolTip` content
matches `EuiButtonIcon`'s `aria-label`.

> [!NOTE]
> `@elastic/eui/sr_output_disabled_tooltip` will be renamed to
`@elastic/eui/sr-output-disabled-tooltip` for consistent rule naming.

## Package updates

### `@elastic/eslint-plugin-eui`

- Added new `sr_output_disabled_tooltip` rule.
([elastic#8848](elastic/eui#8848))
- Added new `consistent-is-invalid-props` rule.
([elastic#8843](elastic/eui#8843))
- Added new `require-aria-label-for-modals` rule.
([elastic#8811](elastic/eui#8811))
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@weronikaolejniczak @kertal
chore: update @elastic/eslint-plugin-eui to v2.1.0 (elastic#227638)
87f3a27 
`@elastic/eslint-plugin-eui`: `2.0.0` ⏩ `2.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

This PR updates the `@elastic/eslint-plugin-eui` version to latest:
[`v2.1.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.1.0)

### `@elastic/eui/require-aria-label-for-modals` (fixed with GenAI:
elastic#227623)

Ensures that EUI modal components (`EuiModal`, `EuiFlyout`,
`EuiConfirmModal`) have either an `aria-label` or `aria-labelledby` prop
for accessibility. This helps screen reader users understand the purpose
and content of modal dialogs.

### `@elastic/eui/consistent-is-invalid-props` (auto-fix available)

Ensures that form control components within `EuiFormRow` components have
matching `isInvalid` prop values. This maintains consistent validation
state between parent form rows and their child form controls, leading to
a more predictable and accessible user experience.

### `@elastic/eui/sr_output_disabled_tooltip` (auto-fix available)

Ensures `disableScreenReaderOutput` is set when `EuiToolTip` content
matches `EuiButtonIcon`'s `aria-label`.

> [!NOTE]
> `@elastic/eui/sr_output_disabled_tooltip` will be renamed to
`@elastic/eui/sr-output-disabled-tooltip` for consistent rule naming.

## Package updates

### `@elastic/eslint-plugin-eui`

- Added new `sr_output_disabled_tooltip` rule.
([elastic#8848](elastic/eui#8848))
- Added new `consistent-is-invalid-props` rule.
([elastic#8843](elastic/eui#8843))
- Added new `require-aria-label-for-modals` rule.
([elastic#8811](elastic/eui#8811))
@weronikaolejniczak weronikaolejniczak deleted the eslint-plugin-eui-v2.1.0 branch February 10, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weronikaolejniczak @elasticmachine @mgadewoll @kibanamachine