Enforce stronger checks on SO type definition changes#227636
Merged
gsoldevila merged 2 commits intoelastic:mainfrom Jul 14, 2025
Merged
Enforce stronger checks on SO type definition changes#227636gsoldevila merged 2 commits intoelastic:mainfrom
gsoldevila merged 2 commits intoelastic:mainfrom
Conversation
jesuswr
approved these changes
Jul 14, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary Closes elastic/kibana-team#1746 Closes elastic/kibana-team#1801 Addresses https://elasticco.atlassian.net/browse/APEX-91 As codeowners of the `check_registered_types.test.ts`, @elastic/kibana-core was already pinged whenever SO types had modifications. This PR aims at putting in place much clearer checks to control which changes are being performed in the registered SO types. For each of the updated snapshots, a description is added on top, with a checklist of things that are and are NOT allowed when upgrading SO definitions. The PR also improves a couple of other things: - checking that folks don't skip any version number when defining _modelVersions_. - checking mutations on _migrations_ and _modelVersions_ that use a provider function.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Closes elastic/kibana-team#1746 Closes elastic/kibana-team#1801 Addresses https://elasticco.atlassian.net/browse/APEX-91 As codeowners of the `check_registered_types.test.ts`, @elastic/kibana-core was already pinged whenever SO types had modifications. This PR aims at putting in place much clearer checks to control which changes are being performed in the registered SO types. For each of the updated snapshots, a description is added on top, with a checklist of things that are and are NOT allowed when upgrading SO definitions. The PR also improves a couple of other things: - checking that folks don't skip any version number when defining _modelVersions_. - checking mutations on _migrations_ and _modelVersions_ that use a provider function.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/kibana-team/issues/1746
Closes https://github.com/elastic/kibana-team/issues/1801
Addresses https://elasticco.atlassian.net/browse/APEX-91
As codeowners of the
check_registered_types.test.ts, @elastic/kibana-core was already pinged whenever SO types had modifications.This PR aims at putting in place much clearer checks to control which changes are being performed in the registered SO types. For each of the updated snapshots, a description is added on top, with a checklist of things that are and are NOT allowed when upgrading SO definitions.
The PR also improves a couple of other things: