[APM] Fix missing sparklines from dependency#227211
Merged
kpatticha merged 2 commits intoelastic:mainfrom Jul 9, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
approved these changes
Jul 9, 2025
| dependencies: { | ||
| terms: { | ||
| field: SPAN_DESTINATION_SERVICE_RESOURCE, | ||
| size: dependencyNames.length, |
Contributor
There was a problem hiding this comment.
q: why adding the size fixes the problem?
Contributor
Author
There was a problem hiding this comment.
In ES, if you don't explicitly specify the size, the default number of results returned is 10. If you check the recording related to the issue, you'll notice that sparklines are displayed but only for 10 of the dependencies."
Contributor
There was a problem hiding this comment.
ahhh yes. That makes sense. Thanks.
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2025
## Summary closes elastic#227183 ### Before https://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a ### After https://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69 (cherry picked from commit 7bc9207)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[APM] Fix missing sparklines from dependency (#227211)](#227211) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T13:11:15Z","message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM] Fix missing sparklines from dependency","number":227211,"url":"https://github.com/elastic/kibana/pull/227211","mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227211","number":227211,"mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}}]}] BACKPORT--> Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kpatticha
added a commit
to kpatticha/kibana
that referenced
this pull request
Jul 10, 2025
kpatticha
added a commit
to kpatticha/kibana
that referenced
this pull request
Jul 10, 2025
## Summary closes elastic#227183 ### Before https://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a ### After https://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69 (cherry picked from commit 7bc9207) # Conflicts: # x-pack/plugins/observability_solution/apm/server/routes/dependencies/get_dependencies_timeseries_statistics.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kpatticha
added a commit
to kpatticha/kibana
that referenced
this pull request
Jul 10, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kpatticha
added a commit
to kpatticha/kibana
that referenced
this pull request
Jul 10, 2025
kpatticha
added a commit
that referenced
this pull request
Jul 10, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[APM] Fix missing sparklines from dependency (#227211)](#227211) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T13:11:15Z","message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-infra_services","v9.1.0","v9.2.0"],"title":"[APM] Fix missing sparklines from dependency","number":227211,"url":"https://github.com/elastic/kibana/pull/227211","mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/227254","number":227254,"state":"MERGED","mergeCommit":{"sha":"f1f3bd0b53639d5cfaccfc970279d81fe5352d08","message":"[9.1] [APM] Fix missing sparklines from dependency (#227211) (#227254)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[APM] Fix missing sparklines from dependency\n(#227211)](https://github.com/elastic/kibana/pull/227211)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Katerina <aikaterini.patticha@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227211","number":227211,"mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},{"url":"https://github.com/elastic/kibana/pull/227395","number":227395,"branch":"8.17","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/227396","number":227396,"branch":"8.18","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/227397","number":227397,"branch":"8.19","state":"OPEN"}]}] BACKPORT-->
kpatticha
added a commit
that referenced
this pull request
Jul 10, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [[APM] Fix missing sparklines from dependency (#227211)](#227211) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T13:11:15Z","message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-infra_services","v9.1.0","v9.2.0"],"title":"[APM] Fix missing sparklines from dependency","number":227211,"url":"https://github.com/elastic/kibana/pull/227211","mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/227254","number":227254,"state":"MERGED","mergeCommit":{"sha":"f1f3bd0b53639d5cfaccfc970279d81fe5352d08","message":"[9.1] [APM] Fix missing sparklines from dependency (#227211) (#227254)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[APM] Fix missing sparklines from dependency\n(#227211)](https://github.com/elastic/kibana/pull/227211)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Katerina <aikaterini.patticha@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227211","number":227211,"mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},{"url":"https://github.com/elastic/kibana/pull/227395","number":227395,"branch":"8.17","state":"OPEN"}]}] BACKPORT-->
kpatticha
added a commit
that referenced
this pull request
Jul 10, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[APM] Fix missing sparklines from dependency (#227211)](#227211) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T13:11:15Z","message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-infra_services","v9.1.0","v9.2.0"],"title":"[APM] Fix missing sparklines from dependency","number":227211,"url":"https://github.com/elastic/kibana/pull/227211","mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/227254","number":227254,"state":"MERGED","mergeCommit":{"sha":"f1f3bd0b53639d5cfaccfc970279d81fe5352d08","message":"[9.1] [APM] Fix missing sparklines from dependency (#227211) (#227254)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[APM] Fix missing sparklines from dependency\n(#227211)](https://github.com/elastic/kibana/pull/227211)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Katerina <aikaterini.patticha@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227211","number":227211,"mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},{"url":"https://github.com/elastic/kibana/pull/227395","number":227395,"branch":"8.17","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/227396","number":227396,"branch":"8.18","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kpatticha
added a commit
that referenced
this pull request
Jul 11, 2025
# Backport This will backport the following commits from `main` to `8.17`: - [[APM] Fix missing sparklines from dependency (#227211)](#227211) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T13:11:15Z","message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:obs-ux-infra_services","v9.1.0","v9.2.0"],"title":"[APM] Fix missing sparklines from dependency","number":227211,"url":"https://github.com/elastic/kibana/pull/227211","mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/227254","number":227254,"state":"MERGED","mergeCommit":{"sha":"f1f3bd0b53639d5cfaccfc970279d81fe5352d08","message":"[9.1] [APM] Fix missing sparklines from dependency (#227211) (#227254)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[APM] Fix missing sparklines from dependency\n(#227211)](https://github.com/elastic/kibana/pull/227211)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Katerina <aikaterini.patticha@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227211","number":227211,"mergeCommit":{"message":"[APM] Fix missing sparklines from dependency (#227211)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/227183\n\n\n### Before \n\n\nhttps://github.com/user-attachments/assets/1c737e25-cf4e-461e-940e-3c936be6597a\n\n\n\n### After \n\n\n\nhttps://github.com/user-attachments/assets/dd77f65e-85e2-4cee-8fad-9dee985f5e69","sha":"7bc920732652a0a090b9e07989d0ed2289721367"}}]}] BACKPORT-->
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #227183
Before
Screen.Recording.2025-07-09.at.11.53.57.AM.mov
After
Screen.Recording.2025-07-09.at.2.05.16.PM.mov