Remove error state on title field#227098
Merged
eleonoramicozzi merged 1 commit intoelastic:mainfrom Jul 9, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
⏳ Build in-progress
|
viduni94
reviewed
Jul 8, 2025
Contributor
viduni94
left a comment
There was a problem hiding this comment.
When I try to edit an existing entry:
- If I clear the title, I'd expect to see the validation error
- Which I don't see anymore with this change
Can we still keep the validation error if the user clears the title, because that's an indicator as to why the Save button is disabled.
Screen.Recording.2025-07-08.at.2.38.55.PM.mov
Contributor
Author
Hey @viduni94 , I consulted with @isaclfreire about this change and we agreed to remove the error state. |
Contributor
Thanks for clarifying @eleonoramicozzi |
viduni94
approved these changes
Jul 9, 2025
Contributor
Author
Yes, I'm adding it to the description now and will make sure to do so in the future. Thanks :) |
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2025
## Summary Closes elastic#224820 Remove error state for name field when creating a new knowledge base entry. I consulted with @isaclfreire offline about this change and we agreed to remove the error state completely, as error states are not necessary in cases where all fields in a form are mandatory in order to continue. ### Before https://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362 ### After https://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 03b3779)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2025
## Summary Closes elastic#224820 Remove error state for name field when creating a new knowledge base entry. I consulted with @isaclfreire offline about this change and we agreed to remove the error state completely, as error states are not necessary in cases where all fields in a form are mandatory in order to continue. ### Before https://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362 ### After https://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 03b3779)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2025
## Summary Closes elastic#224820 Remove error state for name field when creating a new knowledge base entry. I consulted with @isaclfreire offline about this change and we agreed to remove the error state completely, as error states are not necessary in cases where all fields in a form are mandatory in order to continue. ### Before https://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362 ### After https://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 03b3779)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2025
## Summary Closes elastic#224820 Remove error state for name field when creating a new knowledge base entry. I consulted with @isaclfreire offline about this change and we agreed to remove the error state completely, as error states are not necessary in cases where all fields in a form are mandatory in order to continue. ### Before https://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362 ### After https://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 03b3779)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Remove error state on title field (#227098)](#227098) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eleonora","email":"52030607+eleonoramicozzi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-09T11:35:29Z","message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"Remove error state on title field","number":227098,"url":"https://github.com/elastic/kibana/pull/227098","mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227098","number":227098,"mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}}]}] BACKPORT--> Co-authored-by: Eleonora <52030607+eleonoramicozzi@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Remove error state on title field (#227098)](#227098) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eleonora","email":"52030607+eleonoramicozzi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-09T11:35:29Z","message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"Remove error state on title field","number":227098,"url":"https://github.com/elastic/kibana/pull/227098","mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227098","number":227098,"mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}}]}] BACKPORT--> Co-authored-by: Eleonora <52030607+eleonoramicozzi@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [Remove error state on title field (#227098)](#227098) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eleonora","email":"52030607+eleonoramicozzi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-09T11:35:29Z","message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"Remove error state on title field","number":227098,"url":"https://github.com/elastic/kibana/pull/227098","mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227098","number":227098,"mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}}]}] BACKPORT--> Co-authored-by: Eleonora <52030607+eleonoramicozzi@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [Remove error state on title field (#227098)](#227098) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eleonora","email":"52030607+eleonoramicozzi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-09T11:35:29Z","message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"Remove error state on title field","number":227098,"url":"https://github.com/elastic/kibana/pull/227098","mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227098","number":227098,"mergeCommit":{"message":"Remove error state on title field (#227098)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/224820\n\nRemove error state for name field when creating a new knowledge base\nentry.\n\nI consulted with @isaclfreire offline about this change and we agreed to\nremove the error state completely, as error states are not necessary in\ncases where all fields in a form are mandatory in order to continue.\n\n### Before\n\n\nhttps://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362\n\n### After\n\n\nhttps://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"03b3779f9522285742619d7efd137baa7e1d388d"}}]}] BACKPORT--> Co-authored-by: Eleonora <52030607+eleonoramicozzi@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Closes elastic#224820 Remove error state for name field when creating a new knowledge base entry. I consulted with @isaclfreire offline about this change and we agreed to remove the error state completely, as error states are not necessary in cases where all fields in a form are mandatory in order to continue. ### Before https://github.com/user-attachments/assets/32aab4ad-e558-4e9c-b9c1-b54e9e20b362 ### After https://github.com/user-attachments/assets/4b873397-66fc-4b9c-be0c-dc118e54bfc9 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #224820
Remove error state for name field when creating a new knowledge base entry.
I consulted with @isaclfreire offline about this change and we agreed to remove the error state completely, as error states are not necessary in cases where all fields in a form are mandatory in order to continue.
Before
Screen.Recording.2025-07-08.at.17.10.02.mov
After
Screen.Recording.2025-07-08.at.17.09.25.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.