[dashboard] replace panel_context_menu functional tests with unit tests#226876
Merged
nreese merged 4 commits intoelastic:mainfrom Jul 8, 2025
Merged
[dashboard] replace panel_context_menu functional tests with unit tests#226876nreese merged 4 commits intoelastic:mainfrom
nreese merged 4 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
1 similar comment
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
ThomThomson
approved these changes
Jul 8, 2025
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Great work to remove these tests. Spent a few minutes ensuring that we had unit test coverage already for cloning and editing panels + looked through the code. LGTM!
| await browser.get(currentUrl.toString(), false); | ||
| }); | ||
|
|
||
| describe('visualization object edit menu', () => { |
Contributor
There was a problem hiding this comment.
Great to see removal of this legacy vis code leaking into Dashboard.
| it('are hidden in view mode', async function () { | ||
| await dashboard.saveDashboard(dashboardName); | ||
|
|
||
| await dashboardPanelActions.expectMissingEditPanelAction(); |
Contributor
There was a problem hiding this comment.
Looks like we had redundant coverage for this in src/platform/plugins/private/presentation_panel/public/panel_actions/edit_panel_action/edit_panel_action.test.tsx. Nice to see the FTR coverage removed.
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…ts (elastic#226876) Test cases in panel_context_menu are better suited for unit tests instead of functional tests. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test cases in panel_context_menu are better suited for unit tests instead of functional tests.