Skip to content

[Observability] [Alert details page] Follow up to fix view in discover link is partial broken#226847

Merged
fkanout merged 3 commits intoelastic:mainfrom
fkanout:212133-follow-up-broken-link-discover
Jul 8, 2025
Merged

[Observability] [Alert details page] Follow up to fix view in discover link is partial broken#226847
fkanout merged 3 commits intoelastic:mainfrom
fkanout:212133-follow-up-broken-link-discover

Conversation

@fkanout
Copy link
Copy Markdown
Contributor

@fkanout fkanout commented Jul 7, 2025

Summary

This is a follow-up on ##217993 and that fixes #212133 by adding a missing check/case

@fkanout fkanout requested a review from a team as a code owner July 7, 2025 15:43
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Jul 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@fkanout fkanout self-assigned this Jul 7, 2025
@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jul 7, 2025
@fkanout fkanout added bug Fixes for quality problems that affect the customer experience backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 v9.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed v8.19.0 labels Jul 7, 2025
@fkanout fkanout changed the title [Observability] [Alert details page] Fix view in discover link is partial broken [Observability] [Alert details page] Follow up to fix view in discover link is partial broken Jul 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #78 / Serverless Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables
  • [job] [logs] FTR Configs #78 / Serverless Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables
  • [job] [logs] FTR Configs #41 / Stateful Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables
  • [job] [logs] FTR Configs #41 / Stateful Observability - Deployment-agnostic API integration tests Observability Alerting Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 95.4KB 95.5KB +24.0B

History

cc @fkanout

@fkanout fkanout merged commit 1a0f182 into elastic:main Jul 8, 2025
12 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16145670543

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2025
…r link is partial broken (elastic#226847)

## Summary

This is a follow-up on #elastic#217993
and that fixes elastic#212133 by adding a missing check/case

(cherry picked from commit 1a0f182)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Infra] Replace EuiErrorBoundary with KibanaErrorBoundary on the Infra Metrics (#226805)
- Update dependency moment-timezone to ^0.6.0 (main) (#215606)
- [Build] Split tasks by arch for increased parallelism (#223471)
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 226847

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 8, 2025
…iscover link is partial broken (#226847) (#227047)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Observability] [Alert details page] Follow up to fix view in
discover link is partial broken
(#226847)](#226847)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Faisal
Kanout","email":"faisal.kanout@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T14:10:31Z","message":"[Observability]
[Alert details page] Follow up to fix view in discover link is partial
broken (#226847)\n\n## Summary\n\nThis is a follow-up on
#https://github.com/elastic/kibana/pull/217993\nand that fixes #212133
by adding a missing
check/case","sha":"1a0f1827ca082fcf584b26d03051bc3bb3420c01","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","author:obs-ux-management","v9.2.0"],"title":"[Observability]
[Alert details page] Follow up to fix view in discover link is partial
broken","number":226847,"url":"https://github.com/elastic/kibana/pull/226847","mergeCommit":{"message":"[Observability]
[Alert details page] Follow up to fix view in discover link is partial
broken (#226847)\n\n## Summary\n\nThis is a follow-up on
#https://github.com/elastic/kibana/pull/217993\nand that fixes #212133
by adding a missing
check/case","sha":"1a0f1827ca082fcf584b26d03051bc3bb3420c01"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226847","number":226847,"mergeCommit":{"message":"[Observability]
[Alert details page] Follow up to fix view in discover link is partial
broken (#226847)\n\n## Summary\n\nThis is a follow-up on
#https://github.com/elastic/kibana/pull/217993\nand that fixes #212133
by adding a missing
check/case","sha":"1a0f1827ca082fcf584b26d03051bc3bb3420c01"}}]}]
BACKPORT-->

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…r link is partial broken (elastic#226847)

## Summary

This is a follow-up on #elastic#217993
and that fixes elastic#212133 by adding a missing check/case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.0.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Observability] [Alert details page] View in discover link is partial broken

4 participants