Skip to content

[ES|QL] Removes is... functions from validation package#226752

Merged
stratoula merged 10 commits intoelastic:mainfrom
stratoula:cleanup-duplicates
Jul 9, 2025
Merged

[ES|QL] Removes is... functions from validation package#226752
stratoula merged 10 commits intoelastic:mainfrom
stratoula:cleanup-duplicates

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

Summary

Removes the is... functions from the package as they are redeclared in the ast package

@stratoula stratoula changed the title [ES|QL] Removes is... functions from package [ES|QL] Removes is... functions from validation package Jul 7, 2025
@stratoula stratoula added v9.2.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Jul 7, 2025
@stratoula stratoula marked this pull request as ready for review July 7, 2025 17:54
@stratoula stratoula requested review from a team as code owners July 7, 2025 17:54
@stratoula stratoula requested review from denar50 and xcrzx July 7, 2025 17:54
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Copy Markdown
Contributor

@sddonne sddonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (Only review)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 512 339 -173
securitySolution 7809 7676 -133
stackAlerts 443 270 -173
total -479

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-ast 505 507 +2
@kbn/esql-validation-autocomplete 64 46 -18
total -16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB -88.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.8MB 3.8MB -167.0B
stackAlerts 28.0KB 28.0KB -54.0B
total -221.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 600 602 +2
@kbn/esql-validation-autocomplete 66 48 -18
total -16

History

Copy link
Copy Markdown
Contributor

@denar50 denar50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review. LGTM for files owned by @elastic/security-detection-engine

@stratoula stratoula merged commit 7cecf2f into elastic:main Jul 9, 2025
12 checks passed
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
## Summary

Removes the `is...` functions from the package as they are redeclared in
the ast package

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants