[Streams] [Streamlang] Add base / core types#226668
Merged
Kerry350 merged 1 commit intoelastic:mainfrom Jul 8, 2025
Merged
Conversation
Kerry350
commented
Jul 4, 2025
|
|
||
| export interface ShorthandUnaryFilterCondition { | ||
| field: string; | ||
| exists?: true; |
Contributor
Author
There was a problem hiding this comment.
We could also just model this as exists: boolean and have no notExists, that's probably more natural 🤔
Kerry350
commented
Jul 4, 2025
| @@ -0,0 +1,64 @@ | |||
| /* | |||
Contributor
Author
There was a problem hiding this comment.
This is just copied over verbatim from the streams-schema package for now, the schema package will be cleaned up once we've completed the conversion process to Streamlang (for the APIs, UI etc).
e48eb7b to
d46ddc4
Compare
Kerry350
commented
Jul 7, 2025
|
|
||
| import { z } from '@kbn/zod'; | ||
| import { NonEmptyString } from '@kbn/zod-helpers'; | ||
| import { createIsNarrowSchema } from '@kbn/streams-schema'; |
Contributor
Author
There was a problem hiding this comment.
I might need to move these to a shared package for the next batch of work (circular dependencies).
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
cc @Kerry350 |
flash1293
approved these changes
Jul 8, 2025
Contributor
flash1293
left a comment
There was a problem hiding this comment.
As you mention, we need to reduce it in some places (e.g. multiple patterns, all the options for date processing), but also extend in others ("not" operator for conditions)
If we don't want to do this here I'm OK with this. Do we need to make a final decision of what features and processors will be supported how in this first version?
Contributor
Author
Yeah, we do at some point, but I wouldn't do it here. I think once we have the call with the ESQL folks, and we know where we're at with requests that need to be made, we can make the final call for V1. |
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
## Summary Implements elastic#224421. Adds various base / core types for Streamlang. As mentioned in the issue this will not (yet) be a perfect representation of the end product (e.g. processor types will eventually be reduced down to a schema representation that fits the support matrix, types will change with the transpilation code / extension of the conditions code etc), however this is a best effort at keeping PR sizes down. (cherry picked from commit b20ba3e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Streams] [Streamlang] Add base / core types (#226668)](#226668) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kerry Gallagher","email":"kerry.gallagher@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T13:12:41Z","message":"[Streams] [Streamlang] Add base / core types (#226668)\n\n## Summary\n\nImplements https://github.com/elastic/kibana/issues/224421.\n\nAdds various base / core types for Streamlang. As mentioned in the issue\nthis will not (yet) be a perfect representation of the end product (e.g.\nprocessor types will eventually be reduced down to a schema\nrepresentation that fits the support matrix, types will change with the\ntranspilation code / extension of the conditions code etc), however this\nis a best effort at keeping PR sizes down.","sha":"b20ba3e798266629881e1809f7fe81182e7134dc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","Feature:Streams","v8.19.0","v9.2.0"],"title":"[Streams] [Streamlang] Add base / core types","number":226668,"url":"https://github.com/elastic/kibana/pull/226668","mergeCommit":{"message":"[Streams] [Streamlang] Add base / core types (#226668)\n\n## Summary\n\nImplements https://github.com/elastic/kibana/issues/224421.\n\nAdds various base / core types for Streamlang. As mentioned in the issue\nthis will not (yet) be a perfect representation of the end product (e.g.\nprocessor types will eventually be reduced down to a schema\nrepresentation that fits the support matrix, types will change with the\ntranspilation code / extension of the conditions code etc), however this\nis a best effort at keeping PR sizes down.","sha":"b20ba3e798266629881e1809f7fe81182e7134dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226668","number":226668,"mergeCommit":{"message":"[Streams] [Streamlang] Add base / core types (#226668)\n\n## Summary\n\nImplements https://github.com/elastic/kibana/issues/224421.\n\nAdds various base / core types for Streamlang. As mentioned in the issue\nthis will not (yet) be a perfect representation of the end product (e.g.\nprocessor types will eventually be reduced down to a schema\nrepresentation that fits the support matrix, types will change with the\ntranspilation code / extension of the conditions code etc), however this\nis a best effort at keeping PR sizes down.","sha":"b20ba3e798266629881e1809f7fe81182e7134dc"}}]}] BACKPORT--> Co-authored-by: Kerry Gallagher <kerry.gallagher@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Implements elastic#224421. Adds various base / core types for Streamlang. As mentioned in the issue this will not (yet) be a perfect representation of the end product (e.g. processor types will eventually be reduced down to a schema representation that fits the support matrix, types will change with the transpilation code / extension of the conditions code etc), however this is a best effort at keeping PR sizes down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #224421.
Adds various base / core types for Streamlang. As mentioned in the issue this will not (yet) be a perfect representation of the end product (e.g. processor types will eventually be reduced down to a schema representation that fits the support matrix, types will change with the transpilation code / extension of the conditions code etc), however this is a best effort at keeping PR sizes down.