Skip to content

[Discover][APM] Fix summary column badge field filtering for ES|QL#226598

Merged
Bluefinger merged 4 commits intoelastic:mainfrom
Bluefinger:refactor-badge-icon-field-mapping
Jul 8, 2025
Merged

[Discover][APM] Fix summary column badge field filtering for ES|QL#226598
Bluefinger merged 4 commits intoelastic:mainfrom
Bluefinger:refactor-badge-icon-field-mapping

Conversation

@Bluefinger
Copy link
Copy Markdown
Contributor

@Bluefinger Bluefinger commented Jul 4, 2025

Summary

Fixes the filter buttons for the summary badge icons on the traces document source profile, so that in ES|QL mode, the filters correctly add the field query without defaulting to casting the field value to a string.

Closes #226414

image

How to test

  • Enable the Observability mode on the space you are in, navigate to Discover and enable the ES|QL mode
  • Query for a traces-* index, remote_cluster:traces-* if using edge-oblt-ccs.
  • On the summary column, click on a badge icon and add a filter to the query.
  • The field value should be in its assumed format and not being casted, such as a span.duration.us should be as a number, service.name as a string.

@Bluefinger Bluefinger added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes labels Jul 4, 2025
@Bluefinger Bluefinger requested a review from a team as a code owner July 4, 2025 14:42
@Bluefinger Bluefinger added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jul 4, 2025
@Bluefinger Bluefinger requested a review from a team as a code owner July 4, 2025 14:42
@Bluefinger Bluefinger added backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jul 4, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/discover-contextual-components 36 37 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.1MB 1.1MB +71.0B
Unknown metric groups

API count

id before after diff
@kbn/discover-contextual-components 38 39 +1

History

Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review, Data Discovery changes LGTM 👍

@Bluefinger Bluefinger merged commit 53219ed into elastic:main Jul 8, 2025
12 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16145191649

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2025
…lastic#226598)

## Summary

Fixes the filter buttons for the summary badge icons on the traces
document source profile, so that in ES|QL mode, the filters correctly
add the field query without defaulting to casting the field value to a
string.

Closes elastic#226414

![image](https://github.com/user-attachments/assets/c306d74f-84c1-4afb-aeed-a29509d389ec)

## How to test

- Enable the Observability mode on the space you are in, navigate to
Discover and enable the ES|QL mode
- Query for a `traces-*` index, `remote_cluster:traces-*` if using
edge-oblt-ccs.
- On the summary column, click on a badge icon and add a filter to the
query.
- The field value should be in its assumed format and not being casted,
such as a `span.duration.us` should be as a `number`, `service.name` as
a `string`.

(cherry picked from commit 53219ed)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 226598

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 8, 2025
…|QL (#226598) (#227038)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Discover][APM] Fix summary column badge field filtering for ES|QL
(#226598)](#226598)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T13:51:35Z","message":"[Discover][APM]
Fix summary column badge field filtering for ES|QL (#226598)\n\n##
Summary\n\nFixes the filter buttons for the summary badge icons on the
traces\ndocument source profile, so that in ES|QL mode, the filters
correctly\nadd the field query without defaulting to casting the field
value to a\nstring.\n\nCloses
#226414\n\n\n![image](https://github.com/user-attachments/assets/c306d74f-84c1-4afb-aeed-a29509d389ec)\n\n##
How to test\n\n- Enable the Observability mode on the space you are in,
navigate to\nDiscover and enable the ES|QL mode\n- Query for a
`traces-*` index, `remote_cluster:traces-*` if using\nedge-oblt-ccs.\n-
On the summary column, click on a badge icon and add a filter to
the\nquery.\n- The field value should be in its assumed format and not
being casted,\nsuch as a `span.duration.us` should be as a `number`,
`service.name` as\na
`string`.","sha":"53219ed2863a4ad31be857947c41df06a7f86755","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover][APM]
Fix summary column badge field filtering for
ES|QL","number":226598,"url":"https://github.com/elastic/kibana/pull/226598","mergeCommit":{"message":"[Discover][APM]
Fix summary column badge field filtering for ES|QL (#226598)\n\n##
Summary\n\nFixes the filter buttons for the summary badge icons on the
traces\ndocument source profile, so that in ES|QL mode, the filters
correctly\nadd the field query without defaulting to casting the field
value to a\nstring.\n\nCloses
#226414\n\n\n![image](https://github.com/user-attachments/assets/c306d74f-84c1-4afb-aeed-a29509d389ec)\n\n##
How to test\n\n- Enable the Observability mode on the space you are in,
navigate to\nDiscover and enable the ES|QL mode\n- Query for a
`traces-*` index, `remote_cluster:traces-*` if using\nedge-oblt-ccs.\n-
On the summary column, click on a badge icon and add a filter to
the\nquery.\n- The field value should be in its assumed format and not
being casted,\nsuch as a `span.duration.us` should be as a `number`,
`service.name` as\na
`string`.","sha":"53219ed2863a4ad31be857947c41df06a7f86755"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226598","number":226598,"mergeCommit":{"message":"[Discover][APM]
Fix summary column badge field filtering for ES|QL (#226598)\n\n##
Summary\n\nFixes the filter buttons for the summary badge icons on the
traces\ndocument source profile, so that in ES|QL mode, the filters
correctly\nadd the field query without defaulting to casting the field
value to a\nstring.\n\nCloses
#226414\n\n\n![image](https://github.com/user-attachments/assets/c306d74f-84c1-4afb-aeed-a29509d389ec)\n\n##
How to test\n\n- Enable the Observability mode on the space you are in,
navigate to\nDiscover and enable the ES|QL mode\n- Query for a
`traces-*` index, `remote_cluster:traces-*` if using\nedge-oblt-ccs.\n-
On the summary column, click on a badge icon and add a filter to
the\nquery.\n- The field value should be in its assumed format and not
being casted,\nsuch as a `span.duration.us` should be as a `number`,
`service.name` as\na
`string`.","sha":"53219ed2863a4ad31be857947c41df06a7f86755"}}]}]
BACKPORT-->

Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…lastic#226598)

## Summary

Fixes the filter buttons for the summary badge icons on the traces
document source profile, so that in ES|QL mode, the filters correctly
add the field query without defaulting to casting the field value to a
string.

Closes elastic#226414


![image](https://github.com/user-attachments/assets/c306d74f-84c1-4afb-aeed-a29509d389ec)

## How to test

- Enable the Observability mode on the space you are in, navigate to
Discover and enable the ES|QL mode
- Query for a `traces-*` index, `remote_cluster:traces-*` if using
edge-oblt-ccs.
- On the summary column, click on a badge icon and add a filter to the
query.
- The field value should be in its assumed format and not being casted,
such as a `span.duration.us` should be as a `number`, `service.name` as
a `string`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discover][APM] Fix badge icon filters with new field mapping inference for ES|QL

4 participants