[Discover][APM] Fix summary column badge field filtering for ES|QL#226598
Merged
Bluefinger merged 4 commits intoelastic:mainfrom Jul 8, 2025
Merged
[Discover][APM] Fix summary column badge field filtering for ES|QL#226598Bluefinger merged 4 commits intoelastic:mainfrom
Bluefinger merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
|
davismcphee
approved these changes
Jul 4, 2025
Contributor
davismcphee
left a comment
There was a problem hiding this comment.
Code-only review, Data Discovery changes LGTM 👍
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
…lastic#226598) ## Summary Fixes the filter buttons for the summary badge icons on the traces document source profile, so that in ES|QL mode, the filters correctly add the field query without defaulting to casting the field value to a string. Closes elastic#226414  ## How to test - Enable the Observability mode on the space you are in, navigate to Discover and enable the ES|QL mode - Query for a `traces-*` index, `remote_cluster:traces-*` if using edge-oblt-ccs. - On the summary column, click on a badge icon and add a filter to the query. - The field value should be in its assumed format and not being casted, such as a `span.duration.us` should be as a `number`, `service.name` as a `string`. (cherry picked from commit 53219ed)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2025
…|QL (#226598) (#227038) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover][APM] Fix summary column badge field filtering for ES|QL (#226598)](#226598) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"goncalo.rica@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T13:51:35Z","message":"[Discover][APM] Fix summary column badge field filtering for ES|QL (#226598)\n\n## Summary\n\nFixes the filter buttons for the summary badge icons on the traces\ndocument source profile, so that in ES|QL mode, the filters correctly\nadd the field query without defaulting to casting the field value to a\nstring.\n\nCloses #226414\n\n\n\n\n## How to test\n\n- Enable the Observability mode on the space you are in, navigate to\nDiscover and enable the ES|QL mode\n- Query for a `traces-*` index, `remote_cluster:traces-*` if using\nedge-oblt-ccs.\n- On the summary column, click on a badge icon and add a filter to the\nquery.\n- The field value should be in its assumed format and not being casted,\nsuch as a `span.duration.us` should be as a `number`, `service.name` as\na `string`.","sha":"53219ed2863a4ad31be857947c41df06a7f86755","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover][APM] Fix summary column badge field filtering for ES|QL","number":226598,"url":"https://github.com/elastic/kibana/pull/226598","mergeCommit":{"message":"[Discover][APM] Fix summary column badge field filtering for ES|QL (#226598)\n\n## Summary\n\nFixes the filter buttons for the summary badge icons on the traces\ndocument source profile, so that in ES|QL mode, the filters correctly\nadd the field query without defaulting to casting the field value to a\nstring.\n\nCloses #226414\n\n\n\n\n## How to test\n\n- Enable the Observability mode on the space you are in, navigate to\nDiscover and enable the ES|QL mode\n- Query for a `traces-*` index, `remote_cluster:traces-*` if using\nedge-oblt-ccs.\n- On the summary column, click on a badge icon and add a filter to the\nquery.\n- The field value should be in its assumed format and not being casted,\nsuch as a `span.duration.us` should be as a `number`, `service.name` as\na `string`.","sha":"53219ed2863a4ad31be857947c41df06a7f86755"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226598","number":226598,"mergeCommit":{"message":"[Discover][APM] Fix summary column badge field filtering for ES|QL (#226598)\n\n## Summary\n\nFixes the filter buttons for the summary badge icons on the traces\ndocument source profile, so that in ES|QL mode, the filters correctly\nadd the field query without defaulting to casting the field value to a\nstring.\n\nCloses #226414\n\n\n\n\n## How to test\n\n- Enable the Observability mode on the space you are in, navigate to\nDiscover and enable the ES|QL mode\n- Query for a `traces-*` index, `remote_cluster:traces-*` if using\nedge-oblt-ccs.\n- On the summary column, click on a badge icon and add a filter to the\nquery.\n- The field value should be in its assumed format and not being casted,\nsuch as a `span.duration.us` should be as a `number`, `service.name` as\na `string`.","sha":"53219ed2863a4ad31be857947c41df06a7f86755"}}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <goncalo.rica@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…lastic#226598) ## Summary Fixes the filter buttons for the summary badge icons on the traces document source profile, so that in ES|QL mode, the filters correctly add the field query without defaulting to casting the field value to a string. Closes elastic#226414  ## How to test - Enable the Observability mode on the space you are in, navigate to Discover and enable the ES|QL mode - Query for a `traces-*` index, `remote_cluster:traces-*` if using edge-oblt-ccs. - On the summary column, click on a badge icon and add a filter to the query. - The field value should be in its assumed format and not being casted, such as a `span.duration.us` should be as a `number`, `service.name` as a `string`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the filter buttons for the summary badge icons on the traces document source profile, so that in ES|QL mode, the filters correctly add the field query without defaulting to casting the field value to a string.
Closes #226414
How to test
traces-*index,remote_cluster:traces-*if using edge-oblt-ccs.span.duration.usshould be as anumber,service.nameas astring.