Skip to content

[UnifiedFieldList] Remove the deprecated logic around Smart fields#226553

Merged
jughosta merged 10 commits intoelastic:mainfrom
jughosta:217441-remove-smart-fields
Jul 14, 2025
Merged

[UnifiedFieldList] Remove the deprecated logic around Smart fields#226553
jughosta merged 10 commits intoelastic:mainfrom
jughosta:217441-remove-smart-fields

Conversation

@jughosta
Copy link
Copy Markdown
Contributor

@jughosta jughosta commented Jul 4, 2025

Summary

"Smart fields" code was added in the past to show additional fields in the sidebar for Log Explorer. Since the Log Explorer is deprecated, we can drop these unreachable code and reduce the bundle size.

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@jughosta jughosta self-assigned this Jul 4, 2025
@jughosta jughosta added chore release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Jul 4, 2025
@jughosta jughosta marked this pull request as ready for review July 4, 2025 12:52
@jughosta jughosta requested review from a team as code owners July 4, 2025 12:52
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick smoke test in Discover, LGTM 👍 Thanks for the cleanup!

Copy link
Copy Markdown
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners review LGTM.

Copy link
Copy Markdown
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to the kibana.jsonc lgtm (adding datViews required bundle

@jughosta jughosta enabled auto-merge (squash) July 14, 2025 10:00
@jughosta jughosta merged commit fde2f42 into elastic:main Jul 14, 2025
11 of 12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 692 563 -129
discover 1430 1426 -4
esqlDataGrid 423 291 -132
eventAnnotationListing 575 572 -3
lens 1425 1422 -3
observability 1415 1412 -3
securitySolution 7688 7685 -3
slo 1279 1276 -3
total -280

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/unified-field-list 294 282 -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 559.0KB 556.8KB -2.2KB
discover 1.1MB 1.1MB +445.0B
esqlDataGrid 160.0KB 158.1KB -1.9KB
lens 1.5MB 1.5MB -2.2KB
securitySolution 9.8MB 9.8MB -2.6KB
slo 977.5KB 975.0KB -2.5KB
total -11.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 19.2KB 19.1KB -64.0B
discover 22.5KB 22.4KB -100.0B
esqlDataGrid 9.1KB 9.1KB -64.0B
lens 59.3KB 59.3KB -64.0B
slo 32.6KB 32.6KB -64.0B
total -356.0B
Unknown metric groups

API count

id before after diff
@kbn/unified-field-list 329 312 -17

async chunk count

id before after diff
cloudSecurityPosture 18 17 -1
discover 39 37 -2
esqlDataGrid 5 4 -1
lens 19 18 -1
securitySolution 102 101 -1
slo 34 33 -1
total -7

ESLint disabled line counts

id before after diff
@kbn/unified-field-list 17 16 -1

Total ESLint disabled count

id before after diff
@kbn/unified-field-list 17 16 -1

History

cc @jughosta

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
…lastic#226553)

- Closes elastic#217441

## Summary

"Smart fields" code was added in the past to show additional fields in
the sidebar for Log Explorer. Since the Log Explorer is deprecated, we
can drop these unreachable code and reduce the bundle size.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…lastic#226553)

- Closes elastic#217441

## Summary

"Smart fields" code was added in the past to show additional fields in
the sidebar for Log Explorer. Since the Log Explorer is deprecated, we
can drop these unreachable code and reduce the bundle size.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UnifiedFieldList] Remove the deprecated logic around Smart fields

6 participants