[ES|QL] Supports TS agg functions#226539
Merged
stratoula merged 12 commits intoelastic:mainfrom Jul 9, 2025
Merged
Conversation
stratoula
commented
Jul 7, 2025
| } | ||
| ), | ||
| // items are managed by scripts/generate_esql_docs.ts | ||
| items: [], |
Contributor
Author
There was a problem hiding this comment.
Empty as all functions are on snapshots atm
stratoula
commented
Jul 7, 2025
| args: ESQLAstItem[]; | ||
| } | ||
|
|
||
| export interface ESQLAstTimeseriesCommand extends ESQLCommand<'ts'> { |
Contributor
Author
There was a problem hiding this comment.
Kinda irrelevant but the sources property doesnt exist
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
vadimkibana
approved these changes
Jul 9, 2025
Contributor
vadimkibana
left a comment
There was a problem hiding this comment.
LGTM, code review only.
src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/autocomplete.ts
Outdated
Show resolved
Hide resolved
…src/autocomplete/autocomplete.ts Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
pgayvallet
approved these changes
Jul 9, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Closes elastic#220730 Supports of TS inner agg functions. 1. Retrieves the functions and the docs from elastic/elasticsearch#130290 2. Suggest them only when an agg is already selected and only if the source command is TS  Atm you won't see any changes in the editor. You can test it though if you change the `src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/time_series_agg_functions.ts` `ignoreAsSuggestion` flags to false. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #220730
Supports of TS inner agg functions.
Atm you won't see any changes in the editor. You can test it though if you change the
src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/time_series_agg_functions.tsignoreAsSuggestionflags to false.Checklist