Fix #22579, Kibana fails to use the latest Chromium build#22580
Merged
chrisdavies merged 1 commit intoelastic:masterfrom Aug 31, 2018
Merged
Fix #22579, Kibana fails to use the latest Chromium build#22580chrisdavies merged 1 commit intoelastic:masterfrom
chrisdavies merged 1 commit intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
|
retest looks unrelated |
stacey-gammon
approved these changes
Aug 31, 2018
stacey-gammon
left a comment
There was a problem hiding this comment.
LGTM! Pull down and confirmed that it didn't extract when my binary matched the checksum, but did when it didn't
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Aug 31, 2018
chrisdavies
added a commit
that referenced
this pull request
Aug 31, 2018
kobelb
pushed a commit
to kobelb/kibana
that referenced
this pull request
Oct 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently updated Chromium, and in some environments, Kibana was still using the old Chromium binaries. This PR fixes that bug.