[Streams 🌊] Reset query value for SearchBar if one is not specified#225773
Merged
tonyghiani merged 1 commit intoelastic:mainfrom Jun 30, 2025
Merged
[Streams 🌊] Reset query value for SearchBar if one is not specified#225773tonyghiani merged 1 commit intoelastic:mainfrom
tonyghiani merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
flash1293
approved these changes
Jun 30, 2025
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and works as expected with both ESQL and KQL mode, LGTM
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
…lastic#225773) ## 📓 Summary Closes elastic#225668 Given the stateful nature of the unified search bar, when a `query` property is not specified, it restores the saved value in the session, which coming from ESQL Discover was an `esql` query. Since we want want to use queries for the searchbar only when explicitly specified, passing an explicit default value of undefined to the searchbar tells the internal of unified search bar to not restore the previous value. https://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad (cherry picked from commit f0fba49)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
…lastic#225773) ## 📓 Summary Closes elastic#225668 Given the stateful nature of the unified search bar, when a `query` property is not specified, it restores the saved value in the session, which coming from ESQL Discover was an `esql` query. Since we want want to use queries for the searchbar only when explicitly specified, passing an explicit default value of undefined to the searchbar tells the internal of unified search bar to not restore the previous value. https://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad (cherry picked from commit f0fba49)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
…lastic#225773) ## 📓 Summary Closes elastic#225668 Given the stateful nature of the unified search bar, when a `query` property is not specified, it restores the saved value in the session, which coming from ESQL Discover was an `esql` query. Since we want want to use queries for the searchbar only when explicitly specified, passing an explicit default value of undefined to the searchbar tells the internal of unified search bar to not restore the previous value. https://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad (cherry picked from commit f0fba49)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
…lastic#225773) ## 📓 Summary Closes elastic#225668 Given the stateful nature of the unified search bar, when a `query` property is not specified, it restores the saved value in the session, which coming from ESQL Discover was an `esql` query. Since we want want to use queries for the searchbar only when explicitly specified, passing an explicit default value of undefined to the searchbar tells the internal of unified search bar to not restore the previous value. https://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad (cherry picked from commit f0fba49)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2025
…fied (#225773) (#225823) # Backport This will backport the following commits from `main` to `9.1`: - [[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)](#225773) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2025-06-30T11:59:01Z","message":"[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)\n\n## 📓 Summary\n\nCloses #225668 \n\nGiven the stateful nature of the unified search bar, when a `query`\nproperty is not specified, it restores the saved value in the session,\nwhich coming from ESQL Discover was an `esql` query.\nSince we want want to use queries for the searchbar only when explicitly\nspecified, passing an explicit default value of undefined to the\nsearchbar tells the internal of unified search bar to not restore the\nprevious value.\n\n\nhttps://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad","sha":"f0fba49056c80a15701f111d52627771887d7b72","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0","v9.2.0"],"title":"[Streams 🌊] Reset query value for SearchBar if one is not specified","number":225773,"url":"https://github.com/elastic/kibana/pull/225773","mergeCommit":{"message":"[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)\n\n## 📓 Summary\n\nCloses #225668 \n\nGiven the stateful nature of the unified search bar, when a `query`\nproperty is not specified, it restores the saved value in the session,\nwhich coming from ESQL Discover was an `esql` query.\nSince we want want to use queries for the searchbar only when explicitly\nspecified, passing an explicit default value of undefined to the\nsearchbar tells the internal of unified search bar to not restore the\nprevious value.\n\n\nhttps://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad","sha":"f0fba49056c80a15701f111d52627771887d7b72"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225773","number":225773,"mergeCommit":{"message":"[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)\n\n## 📓 Summary\n\nCloses #225668 \n\nGiven the stateful nature of the unified search bar, when a `query`\nproperty is not specified, it restores the saved value in the session,\nwhich coming from ESQL Discover was an `esql` query.\nSince we want want to use queries for the searchbar only when explicitly\nspecified, passing an explicit default value of undefined to the\nsearchbar tells the internal of unified search bar to not restore the\nprevious value.\n\n\nhttps://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad","sha":"f0fba49056c80a15701f111d52627771887d7b72"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2025
…ified (#225773) (#225822) # Backport This will backport the following commits from `main` to `8.19`: - [[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)](#225773) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2025-06-30T11:59:01Z","message":"[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)\n\n## 📓 Summary\n\nCloses #225668 \n\nGiven the stateful nature of the unified search bar, when a `query`\nproperty is not specified, it restores the saved value in the session,\nwhich coming from ESQL Discover was an `esql` query.\nSince we want want to use queries for the searchbar only when explicitly\nspecified, passing an explicit default value of undefined to the\nsearchbar tells the internal of unified search bar to not restore the\nprevious value.\n\n\nhttps://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad","sha":"f0fba49056c80a15701f111d52627771887d7b72","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0","v9.2.0"],"title":"[Streams 🌊] Reset query value for SearchBar if one is not specified","number":225773,"url":"https://github.com/elastic/kibana/pull/225773","mergeCommit":{"message":"[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)\n\n## 📓 Summary\n\nCloses #225668 \n\nGiven the stateful nature of the unified search bar, when a `query`\nproperty is not specified, it restores the saved value in the session,\nwhich coming from ESQL Discover was an `esql` query.\nSince we want want to use queries for the searchbar only when explicitly\nspecified, passing an explicit default value of undefined to the\nsearchbar tells the internal of unified search bar to not restore the\nprevious value.\n\n\nhttps://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad","sha":"f0fba49056c80a15701f111d52627771887d7b72"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225773","number":225773,"mergeCommit":{"message":"[Streams 🌊] Reset query value for SearchBar if one is not specified (#225773)\n\n## 📓 Summary\n\nCloses #225668 \n\nGiven the stateful nature of the unified search bar, when a `query`\nproperty is not specified, it restores the saved value in the session,\nwhich coming from ESQL Discover was an `esql` query.\nSince we want want to use queries for the searchbar only when explicitly\nspecified, passing an explicit default value of undefined to the\nsearchbar tells the internal of unified search bar to not restore the\nprevious value.\n\n\nhttps://github.com/user-attachments/assets/7525d950-4ce3-481e-bc45-13fe0edb79ad","sha":"f0fba49056c80a15701f111d52627771887d7b72"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #225668
Given the stateful nature of the unified search bar, when a
queryproperty is not specified, it restores the saved value in the session, which coming from ESQL Discover was anesqlquery.Since we want want to use queries for the searchbar only when explicitly specified, passing an explicit default value of undefined to the searchbar tells the internal of unified search bar to not restore the previous value.
Screen.Recording.2025-06-30.at.11.01.07.mov