add title to rule gap histogram in the rules dashboard#225274
Merged
denar50 merged 4 commits intoelastic:mainfrom Jun 30, 2025
Merged
add title to rule gap histogram in the rules dashboard#225274denar50 merged 4 commits intoelastic:mainfrom
denar50 merged 4 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
jkelas
reviewed
Jun 27, 2025
Contributor
jkelas
left a comment
There was a problem hiding this comment.
I reviewed the changes and this looks good.
I confirm that the "Rule gap histogram" appears as the title in the dashboard.
But shouldn't we also update the tests in x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/detection_engine_health/assets/assets.test.ts, @denar50 ?
OLD:
Screen.Recording.2025-06-27.at.09.58.27.mov
NEW:
Screen.Recording.2025-06-27.at.10.11.10.mov
Contributor
Author
|
@jkelas I have added a unit test for this case |
jkelas
approved these changes
Jun 30, 2025
Contributor
jkelas
left a comment
There was a problem hiding this comment.
I tested that this PR fixes the issue from the ticket correctly.
My comment also has been addressed.
I am approving.
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
## Summary fixes elastic#224518 This PR adds a title to the rule gap histogram in the rules dashboard. ## How was this tested? I added the title to the JSON file and then updated the dashboard by calling: ``` curl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H "x-elastic-internal-origin: Kibana" -H "elastic-api-version: 1" ``` Before:  After:  (cherry picked from commit 6a2aea3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
## Summary fixes elastic#224518 This PR adds a title to the rule gap histogram in the rules dashboard. ## How was this tested? I added the title to the JSON file and then updated the dashboard by calling: ``` curl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H "x-elastic-internal-origin: Kibana" -H "elastic-api-version: 1" ``` Before:  After:  (cherry picked from commit 6a2aea3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
## Summary fixes elastic#224518 This PR adds a title to the rule gap histogram in the rules dashboard. ## How was this tested? I added the title to the JSON file and then updated the dashboard by calling: ``` curl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H "x-elastic-internal-origin: Kibana" -H "elastic-api-version: 1" ``` Before:  After:  (cherry picked from commit 6a2aea3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2025
## Summary fixes elastic#224518 This PR adds a title to the rule gap histogram in the rules dashboard. ## How was this tested? I added the title to the JSON file and then updated the dashboard by calling: ``` curl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H "x-elastic-internal-origin: Kibana" -H "elastic-api-version: 1" ``` Before:  After:  (cherry picked from commit 6a2aea3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2025
#225848) # Backport This will backport the following commits from `main` to `9.1`: - [add title to rule gap histogram in the rules dashboard (#225274)](#225274) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Edgar Santos","email":"edgar.santos@elastic.co"},"sourceCommit":{"committedDate":"2025-06-30T13:43:21Z","message":"add title to rule gap histogram in the rules dashboard (#225274)\n\n## Summary\nfixes #224518 \nThis PR adds a title to the rule gap histogram in the rules dashboard.\n\n## How was this tested?\nI added the title to the JSON file and then updated the dashboard by\ncalling:\n```\ncurl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H \"x-elastic-internal-origin: Kibana\" -H \"elastic-api-version: 1\"\n```\n\nBefore:\n\n\nAfter:\n","sha":"6a2aea3311b7567240aa88a83f13ad16beed166e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detection Engine","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"add title to rule gap histogram in the rules dashboard","number":225274,"url":"https://github.com/elastic/kibana/pull/225274","mergeCommit":{"message":"add title to rule gap histogram in the rules dashboard (#225274)\n\n## Summary\nfixes #224518 \nThis PR adds a title to the rule gap histogram in the rules dashboard.\n\n## How was this tested?\nI added the title to the JSON file and then updated the dashboard by\ncalling:\n```\ncurl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H \"x-elastic-internal-origin: Kibana\" -H \"elastic-api-version: 1\"\n```\n\nBefore:\n\n\nAfter:\n","sha":"6a2aea3311b7567240aa88a83f13ad16beed166e"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225274","number":225274,"mergeCommit":{"message":"add title to rule gap histogram in the rules dashboard (#225274)\n\n## Summary\nfixes #224518 \nThis PR adds a title to the rule gap histogram in the rules dashboard.\n\n## How was this tested?\nI added the title to the JSON file and then updated the dashboard by\ncalling:\n```\ncurl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H \"x-elastic-internal-origin: Kibana\" -H \"elastic-api-version: 1\"\n```\n\nBefore:\n\n\nAfter:\n","sha":"6a2aea3311b7567240aa88a83f13ad16beed166e"}}]}] BACKPORT--> Co-authored-by: Edgar Santos <edgar.santos@elastic.co>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jul 1, 2025
… (#225847) # Backport This will backport the following commits from `main` to `8.19`: - [add title to rule gap histogram in the rules dashboard (#225274)](#225274) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Edgar Santos","email":"edgar.santos@elastic.co"},"sourceCommit":{"committedDate":"2025-06-30T13:43:21Z","message":"add title to rule gap histogram in the rules dashboard (#225274)\n\n## Summary\nfixes #224518 \nThis PR adds a title to the rule gap histogram in the rules dashboard.\n\n## How was this tested?\nI added the title to the JSON file and then updated the dashboard by\ncalling:\n```\ncurl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H \"x-elastic-internal-origin: Kibana\" -H \"elastic-api-version: 1\"\n```\n\nBefore:\n\n\nAfter:\n","sha":"6a2aea3311b7567240aa88a83f13ad16beed166e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detection Engine","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"add title to rule gap histogram in the rules dashboard","number":225274,"url":"https://github.com/elastic/kibana/pull/225274","mergeCommit":{"message":"add title to rule gap histogram in the rules dashboard (#225274)\n\n## Summary\nfixes #224518 \nThis PR adds a title to the rule gap histogram in the rules dashboard.\n\n## How was this tested?\nI added the title to the JSON file and then updated the dashboard by\ncalling:\n```\ncurl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H \"x-elastic-internal-origin: Kibana\" -H \"elastic-api-version: 1\"\n```\n\nBefore:\n\n\nAfter:\n","sha":"6a2aea3311b7567240aa88a83f13ad16beed166e"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225274","number":225274,"mergeCommit":{"message":"add title to rule gap histogram in the rules dashboard (#225274)\n\n## Summary\nfixes #224518 \nThis PR adds a title to the rule gap histogram in the rules dashboard.\n\n## How was this tested?\nI added the title to the JSON file and then updated the dashboard by\ncalling:\n```\ncurl -X POST http://localhost:5601/internal/detection_engine/health/_setup -u elastic:changeme -H 'kbn-xsrf: 123' -H \"x-elastic-internal-origin: Kibana\" -H \"elastic-api-version: 1\"\n```\n\nBefore:\n\n\nAfter:\n","sha":"6a2aea3311b7567240aa88a83f13ad16beed166e"}}]}] BACKPORT--> Co-authored-by: Edgar Santos <edgar.santos@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #224518
This PR adds a title to the rule gap histogram in the rules dashboard.
How was this tested?
I added the title to the JSON file and then updated the dashboard by calling:
Before:
After:
