[ska] relocate x-pack/test/cases_api_integration by dmlemeshko · Pull Request #225056 · elastic/kibana

dmlemeshko · 2025-06-24T11:21:33Z

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR is mostly about moving tests from x-pack/test/cases_api_integration and updating related imports

Before:

x-pack/test/
     | - cases_api_integration/

After:

x-pack/platform/test/
     | - cases_api_integration/
 
x-pack/solutions/security/test/
     | - cases_api_integration/

…ocs'

…eshko/kibana into ska/relocate-cases_api_integration

…apping'

…fix'

kibanamachine · 2025-06-24T13:07:16Z

Cloud deployments require a Github label, please add ci:cloud-deploy or ci:cloud-redeploy and trigger the job through the checkbox again.

…eshko/kibana into ska/relocate-cases_api_integration

…fix'

dmlemeshko · 2025-06-24T16:12:37Z

x-pack/platform/test/cases_api_integration/common/users.ts

+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+


copied to simplify imports. we will remove original files in the follow-up with more tests relocated

…api_integration

…fix'

csr · 2025-06-25T09:56:17Z

x-pack/solutions/security/test/cases_api_integration/common/lib/alerts.ts

+  getQueryAlertIds,
+} from '@kbn/test-suites-xpack/common/utils/security_solution';
+
+export const createSecuritySolutionAlerts = async (


Nice to see the reduced scope here. I noticed these utilities were previously located in x-pack/platform/test/cases_api_integration/common/lib/alerts.ts and have now been moved to the dedicated Security cases_api_integration plugin.

gsoldevila · 2025-06-25T10:29:05Z

package.json

    "@kbn/observability-alert-details": "link:x-pack/solutions/observability/packages/alert-details",
    "@kbn/observability-alerting-test-data": "link:x-pack/solutions/observability/packages/alerting-test-data",
-    "@kbn/observability-fixtures-plugin": "link:x-pack/test/cases_api_integration/common/plugins/observability",
+    "@kbn/observability-fixtures-plugin": "link:x-pack/platform/test/cases_api_integration/common/plugins/observability",


It seems odd to have a plugin that is called observabilityFixtures categorised inside platform.

I could not find if / how the platform code depends on this one, the only thing I've seen is that it registers a Kibana feature. This fixture is then referenced / used in a bunch of places.

@jonathan-buttner is there a strong reason for naming this "Observability"? or could that have been any other project type?

Cases exists in Observability, Security, and the Stack management page. I believe this fixtures plugin handles testings some observability specific functionality.

By the looks of it, the observabilityFixture and securitySolutionFixture could be renamed into solution1Fixture and solution2Fixture and everything would continue to work, correct?

The point I'm trying to make is that cases is a generic platform plugin, and we have a bunch of FTR tests testing it, which are also defined at platform level (explicitly relocated under a /platform/ folder with this PR), so we want those tests (and the test data) to remain "solution-agnostic" as much as possible.

On the other hand, if these are truly Observability-specific fixtures that are needed only to test things that are specific to the Observability solution, then maybe it'd make sense to move those tests and fixtures under x-pack/solutions/observability/test (so that in the future, they are tested only for oblt projects).

Or maybe it's a combination of both, and there's a subset of tests that belongs to each category?

That being said, I don't want to block the PR on this. It can be addressed as a follow-up discussion / task.

denar50

LGTM! Code owners review for the files owned by @elastic/security-detection-engine

gsoldevila

LGTM from core standpoint (3 kibana.jsonc files moved without changes)

…api_integration

elasticmachine · 2025-06-25T17:05:29Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d51535b

Failed CI Steps

FTR Configs #27

Test Failures

[job] [logs] FTR Configs #27 / Stateful Observability - Deployment-agnostic API integration tests SyntheticsAPITests EnableDefaultAlerting deletes (and recreates) the default rule when settings are updated

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`@kbn/test-suites-xpack`	17	15	-2
`@kbn/test-suites-xpack-platform`	5	6	+1
`@kbn/test-suites-xpack-security`	1	2	+1
total			-0

ESLint disabled line counts

id	before	after	diff
`@kbn/test-suites-xpack`	340	220	-120
`@kbn/test-suites-xpack-platform`	356	466	+110
`@kbn/test-suites-xpack-security`	47	51	+4
total			-6

Total ESLint disabled count

id	before	after	diff
`@kbn/test-suites-xpack`	357	235	-122
`@kbn/test-suites-xpack-platform`	361	472	+111
`@kbn/test-suites-xpack-security`	48	53	+5
total			-6

History

💚 Build #312619 succeeded d1b8881
💚 Build #312501 succeeded c4d6838
💔 Build #312280 failed d41a846
💔 Build #312183 failed 1175c4b
💔 Build #312161 failed f602d0e
💔 Build #312133 failed ff94f0f

cc @dmlemeshko

## Summary Part of elastic/kibana-team#1503 This PR is mostly about moving tests from x-pack/test/cases_api_integration and updating related imports Before: ``` x-pack/test/ | - cases_api_integration/ ``` After: ``` x-pack/platform/test/ | - cases_api_integration/ x-pack/solutions/security/test/ | - cases_api_integration/ ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bb7cce6) # Conflicts: # .buildkite/ftr_platform_stateful_configs.yml # .github/CODEOWNERS # x-pack/platform/test/cases_api_integration/common/lib/api/index.ts # x-pack/platform/test/cases_api_integration/security_and_spaces/config_trial_common.ts # x-pack/platform/test/cases_api_integration/security_and_spaces/tests/common/comments/get_all_comments.ts # x-pack/platform/test/cases_api_integration/security_and_spaces/tests/common/index_common_trial/index.ts # x-pack/platform/test/cases_api_integration/security_and_spaces/tests/common/user_actions/get_all_user_actions.ts # x-pack/platform/test/cases_api_integration/security_and_spaces/tests/trial/cases/user_actions/get_all_user_actions.ts # x-pack/platform/test/cases_api_integration/security_and_spaces/tests/trial/index.ts # x-pack/platform/test/cases_api_integration/spaces_only/tests/common/comments/get_all_comments.ts # x-pack/solutions/security/test/cases_api_integration/security_and_spaces/tests/common/comments/delete_comment.ts # x-pack/test/cases_api_integration/security_and_spaces/config_trial_common.ts # x-pack/test/functional_with_es_ssl/apps/cases/group2/attachment_framework.ts # x-pack/test/spaces_api_integration/security_and_spaces/copy_to_space_config_trial.ts

dmlemeshko · 2025-06-26T15:32:43Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…25491) # Backport This will backport the following commits from `main` to `8.19`: - [[ska] relocate x-pack/test/cases_api_integration (#225056)](#225056)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

dmlemeshko and others added 10 commits June 24, 2025 13:18

move platform tests

b6f3304

uncomment plugins

9264c47

Merge branch 'main' into ska/relocate-cases_api_integration

cf0a22d

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

a10ca56

…ocs'

quick check fixes

b0820e7

Merge branch 'ska/relocate-cases_api_integration' of github.com:dmlem…

ab185d3

…eshko/kibana into ska/relocate-cases_api_integration

Merge branch 'main' into ska/relocate-cases_api_integration

4fca808

[CI] Auto-commit changed files from 'node scripts/styled_components_m…

4782f31

…apping'

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

c12b5a6

…fix'

Merge branch 'main' into ska/relocate-cases_api_integration

41e3f86

dmlemeshko and others added 8 commits June 24, 2025 16:07

relocate security solution cases tests

6cb7244

Merge branch 'ska/relocate-cases_api_integration' of github.com:dmlem…

bca210e

…eshko/kibana into ska/relocate-cases_api_integration

Merge branch 'main' into ska/relocate-cases_api_integration

ff94f0f

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

8b9b1bb

import type

f347462

Merge branch 'main' into ska/relocate-cases_api_integration

c082a37

Update CODEOWNERS

f602d0e

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

d6fa6ac

…fix'

dmlemeshko self-assigned this Jun 24, 2025

Merge branch 'main' into ska/relocate-cases_api_integration

1175c4b

dmlemeshko commented Jun 24, 2025

View reviewed changes

dmlemeshko added 3 commits June 24, 2025 20:40

update tests order

b7bf5aa

fix hooks

d3ec1b0

Merge remote-tracking branch 'upstream/main' into ska/relocate-cases_…

d41a846

…api_integration

dmlemeshko marked this pull request as ready for review June 24, 2025 19:05

dmlemeshko requested review from a team as code owners June 24, 2025 19:05

dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.1.0 v8.19.0 labels Jun 24, 2025

jbudz approved these changes Jun 24, 2025

View reviewed changes

Merge branch 'main' into ska/relocate-cases_api_integration

dafa834

cnasikas approved these changes Jun 25, 2025

View reviewed changes

adcoelho approved these changes Jun 25, 2025

View reviewed changes

dmlemeshko and others added 2 commits June 25, 2025 11:14

Merge branch 'main' into ska/relocate-cases_api_integration

2f74624

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

c4d6838

…fix'

csr self-requested a review June 25, 2025 08:30

csr reviewed Jun 25, 2025

View reviewed changes

csr approved these changes Jun 25, 2025

View reviewed changes

gsoldevila reviewed Jun 25, 2025

View reviewed changes

denar50 approved these changes Jun 25, 2025

View reviewed changes

Merge branch 'main' into ska/relocate-cases_api_integration

d1b8881

gsoldevila approved these changes Jun 25, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into ska/relocate-cases_…

43cd919

…api_integration

dmlemeshko enabled auto-merge (squash) June 25, 2025 15:00

Merge branch 'main' into ska/relocate-cases_api_integration

d51535b

dmlemeshko merged commit bb7cce6 into elastic:main Jun 25, 2025
13 checks passed

This was referenced Jun 25, 2025

[Lens] Add internal CRUD api routes #223296

Merged

[Security Solution] Adds ability to revert prebuilt rules to their base version #223301

Merged

[Oblt Onboarding] Add more errors logging for Auto Detect flow #222948

Merged

dmlemeshko mentioned this pull request Jun 26, 2025

[8.19] [ska] relocate x-pack/test/cases_api_integration (#225056) #225491

Merged

kibanamachine mentioned this pull request Jun 26, 2025

Upgrade parcel/watcher to 2.5.1 #225512

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ska] relocate x-pack/test/cases_api_integration#225056

[ska] relocate x-pack/test/cases_api_integration#225056
dmlemeshko merged 28 commits intoelastic:mainfrom
dmlemeshko:ska/relocate-cases_api_integration

dmlemeshko commented Jun 24, 2025 •

edited

Loading

Uh oh!

kibanamachine commented Jun 24, 2025

Uh oh!

dmlemeshko Jun 24, 2025 •

edited

Loading

Uh oh!

csr Jun 25, 2025

Uh oh!

gsoldevila Jun 25, 2025

Uh oh!

jonathan-buttner Jun 25, 2025

Uh oh!

gsoldevila Jun 25, 2025 •

edited

Loading

Uh oh!

denar50 left a comment

Uh oh!

gsoldevila left a comment

Uh oh!

Uh oh!

elasticmachine commented Jun 25, 2025

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

dmlemeshko commented Jun 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

dmlemeshko commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

kibanamachine commented Jun 24, 2025

Uh oh!

dmlemeshko Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csr Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

gsoldevila Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

gsoldevila Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

denar50 left a comment

Choose a reason for hiding this comment

Uh oh!

gsoldevila left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jun 25, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

dmlemeshko commented Jun 26, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

dmlemeshko commented Jun 24, 2025 •

edited

Loading

dmlemeshko Jun 24, 2025 •

edited

Loading

gsoldevila Jun 25, 2025 •

edited

Loading