Skip to content

[Data Streams] Fix forward-compatibility api test failures#224795

Merged
SoniaSanzV merged 3 commits intoelastic:mainfrom
SoniaSanzV:ds_api_tests
Jun 25, 2025
Merged

[Data Streams] Fix forward-compatibility api test failures#224795
SoniaSanzV merged 3 commits intoelastic:mainfrom
SoniaSanzV:ds_api_tests

Conversation

@SoniaSanzV
Copy link
Copy Markdown
Contributor

@SoniaSanzV SoniaSanzV commented Jun 23, 2025

Fixes #223990

Summary

This PR fixes the forward-compatibility test for index mode, which failed because the index mode was added to Get Data Streams API in 8.19 and 9.1 (see elastic/elasticsearch#122486), so if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as "Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate file, and only run it for Es versions 8.19 or 9.1+.

This was also fixed for functional tests in #223129

@SoniaSanzV SoniaSanzV self-assigned this Jun 23, 2025
@SoniaSanzV SoniaSanzV added the Feature:Index Management Index and index templates UI label Jun 23, 2025
@SoniaSanzV SoniaSanzV requested a review from a team as a code owner June 23, 2025 06:58
@SoniaSanzV SoniaSanzV added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 23, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Copy Markdown
Contributor

@damian-polewski damian-polewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SoniaSanzV SoniaSanzV enabled auto-merge (squash) June 25, 2025 11:21
@SoniaSanzV SoniaSanzV merged commit 493ca9f into elastic:main Jun 25, 2025
10 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15875644979

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @SoniaSanzV

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 224795

Questions ?

Please refer to the Backport tool documentation

@SoniaSanzV SoniaSanzV deleted the ds_api_tests branch June 26, 2025 12:57
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 27, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224795 locally
cc: @SoniaSanzV

SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this pull request Jun 27, 2025
…24795)

Fixes elastic#223990

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.

This was also fixed for functional tests in
elastic#223129

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 493ca9f)

# Conflicts:
#	x-pack/platform/test/api_integration/apis/management/index_management/data_streams.ts
@SoniaSanzV
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @SoniaSanzV

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @SoniaSanzV

SoniaSanzV added a commit that referenced this pull request Jul 2, 2025
…24795) (#225641)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Data Streams] Fix forward-compatibility api test failures
(#224795)](#224795)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-06-25T11:55:46Z","message":"[Data
Streams] Fix forward-compatibility api test failures (#224795)\n\nFixes
https://github.com/elastic/kibana/issues/223990\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or 9.1+.\n\nThis was also fixed for
functional tests
in\nhttps://github.com//pull/223129\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"493ca9f1061ab1e451741c6875107d8d16953d23","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana Management","release_note:skip","backport
missing","backport:version","v9.1.0","v8.19.0"],"title":"[Data Streams]
Fix forward-compatibility api test
failures","number":224795,"url":"https://github.com/elastic/kibana/pull/224795","mergeCommit":{"message":"[Data
Streams] Fix forward-compatibility api test failures (#224795)\n\nFixes
https://github.com/elastic/kibana/issues/223990\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or 9.1+.\n\nThis was also fixed for
functional tests
in\nhttps://github.com//pull/223129\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"493ca9f1061ab1e451741c6875107d8d16953d23"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224795","number":224795,"mergeCommit":{"message":"[Data
Streams] Fix forward-compatibility api test failures (#224795)\n\nFixes
https://github.com/elastic/kibana/issues/223990\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or 9.1+.\n\nThis was also fixed for
functional tests
in\nhttps://github.com//pull/223129\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"493ca9f1061ab1e451741c6875107d8d16953d23"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Damian Polewski <125268832+damian-polewski@users.noreply.github.com>
Co-authored-by: Damian Polewski <damian.polewski@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.19.0 v9.1.0

Projects

None yet

5 participants