Update redux, react-redux and corresponding types#22442
Merged
weltenwort merged 1 commit intoelastic:masterfrom Aug 29, 2018
Merged
Update redux, react-redux and corresponding types#22442weltenwort merged 1 commit intoelastic:masterfrom
weltenwort merged 1 commit intoelastic:masterfrom
Conversation
Member
Author
|
I tagged this with |
Contributor
💚 Build Succeeded |
|
cc @azasypkin |
stacey-gammon
approved these changes
Aug 28, 2018
stacey-gammon
left a comment
There was a problem hiding this comment.
LGTM. Pulled and tested briefly but relying on ci to catch any nuanced redux changes that may break current implementations.
azasypkin
approved these changes
Aug 28, 2018
| "react-toggle": "4.0.2", | ||
| "reactcss": "1.2.3", | ||
| "redux": "3.7.2", | ||
| "redux": "4.0.0", |
Contributor
There was a problem hiding this comment.
optional nit: we try to use "caret" versions for all dependencies we add and all dependencies we update since we started to use yarn.lock. But I see that it's used without caret in x-pack, so feel free to keep it as is, or update to "caret" versions in both package.json files.
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Aug 29, 2018
weltenwort
added a commit
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
reduxto 4.0.0, which ships with built-in TypeScript typings. This allows to update thereact-reduxpackage to 5.0.7 as well in order to resolve typing conflicts between Kibana and x-pack.Let me know if the changes break any conventions established around redux and TypeScript in Kibana core.