[dashboard] remove url_field_formatter functional test#223448
Merged
nreese merged 2 commits intoelastic:mainfrom Jun 13, 2025
Merged
[dashboard] remove url_field_formatter functional test#223448nreese merged 2 commits intoelastic:mainfrom
nreese merged 2 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]
|
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jun 11, 2025
sphilipse
approved these changes
Jun 13, 2025
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 13, 2025
Part of elastic#192910 url_field_formatter functional test was [skipped](elastic#193293) in Sept 2024. Instead of removing `.skip`, the entire test should be removed for the following reasons 1) It does not test dashboard code. The test verifies rendering of legacy visualize table on a dashboard and discover table (in the discover app). Both of these are not our area of responsibility. 2) the test case is better covered by unit tests. (cherry picked from commit 03af622)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 13, 2025
… (#223917) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] remove url_field_formatter functional test (#223448)](#223448) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-13T13:30:35Z","message":"[dashboard] remove url_field_formatter functional test (#223448)\n\nPart of https://github.com/elastic/kibana/issues/192910\n\nurl_field_formatter functional test was\n[skipped](#193293) in Sept 2024.\nInstead of removing `.skip`, the entire test should be removed for the\nfollowing reasons\n1) It does not test dashboard code. The test verifies rendering of\nlegacy visualize table on a dashboard and discover table (in the\ndiscover app). Both of these are not our area of responsibility.\n2) the test case is better covered by unit tests.","sha":"03af622492d6aad7583db67def9f615219ed7031","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard] remove url_field_formatter functional test","number":223448,"url":"https://github.com/elastic/kibana/pull/223448","mergeCommit":{"message":"[dashboard] remove url_field_formatter functional test (#223448)\n\nPart of https://github.com/elastic/kibana/issues/192910\n\nurl_field_formatter functional test was\n[skipped](#193293) in Sept 2024.\nInstead of removing `.skip`, the entire test should be removed for the\nfollowing reasons\n1) It does not test dashboard code. The test verifies rendering of\nlegacy visualize table on a dashboard and discover table (in the\ndiscover app). Both of these are not our area of responsibility.\n2) the test case is better covered by unit tests.","sha":"03af622492d6aad7583db67def9f615219ed7031"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223448","number":223448,"mergeCommit":{"message":"[dashboard] remove url_field_formatter functional test (#223448)\n\nPart of https://github.com/elastic/kibana/issues/192910\n\nurl_field_formatter functional test was\n[skipped](#193293) in Sept 2024.\nInstead of removing `.skip`, the entire test should be removed for the\nfollowing reasons\n1) It does not test dashboard code. The test verifies rendering of\nlegacy visualize table on a dashboard and discover table (in the\ndiscover app). Both of these are not our area of responsibility.\n2) the test case is better covered by unit tests.","sha":"03af622492d6aad7583db67def9f615219ed7031"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
Part of elastic#192910 url_field_formatter functional test was [skipped](elastic#193293) in Sept 2024. Instead of removing `.skip`, the entire test should be removed for the following reasons 1) It does not test dashboard code. The test verifies rendering of legacy visualize table on a dashboard and discover table (in the discover app). Both of these are not our area of responsibility. 2) the test case is better covered by unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #192910
url_field_formatter functional test was skipped in Sept 2024. Instead of removing
.skip, the entire test should be removed for the following reasons