Skip to content

[dashboard] remove url_field_formatter functional test#223448

Merged
nreese merged 2 commits intoelastic:mainfrom
nreese:remove_url_field_formatter_test
Jun 13, 2025
Merged

[dashboard] remove url_field_formatter functional test#223448
nreese merged 2 commits intoelastic:mainfrom
nreese:remove_url_field_formatter_test

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Jun 11, 2025

Part of #192910

url_field_formatter functional test was skipped in Sept 2024. Instead of removing .skip, the entire test should be removed for the following reasons

  1. It does not test dashboard code. The test verifies rendering of legacy visualize table on a dashboard and discover table (in the discover app). Both of these are not our area of responsibility.
  2. the test case is better covered by unit tests.

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Jun 11, 2025

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Jun 11, 2025

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@nreese nreese marked this pull request as ready for review June 11, 2025 19:49
@nreese nreese requested review from a team as code owners June 11, 2025 19:49
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 11, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese merged commit 03af622 into elastic:main Jun 13, 2025
20 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15635781911

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 13, 2025
Part of elastic#192910

url_field_formatter functional test was
[skipped](elastic#193293) in Sept 2024.
Instead of removing `.skip`, the entire test should be removed for the
following reasons
1) It does not test dashboard code. The test verifies rendering of
legacy visualize table on a dashboard and discover table (in the
discover app). Both of these are not our area of responsibility.
2) the test case is better covered by unit tests.

(cherry picked from commit 03af622)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 13, 2025
… (#223917)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[dashboard] remove url_field_formatter functional test
(#223448)](#223448)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-06-13T13:30:35Z","message":"[dashboard]
remove url_field_formatter functional test (#223448)\n\nPart of
https://github.com/elastic/kibana/issues/192910\n\nurl_field_formatter
functional test
was\n[skipped](#193293) in Sept
2024.\nInstead of removing `.skip`, the entire test should be removed
for the\nfollowing reasons\n1) It does not test dashboard code. The test
verifies rendering of\nlegacy visualize table on a dashboard and
discover table (in the\ndiscover app). Both of these are not our area of
responsibility.\n2) the test case is better covered by unit
tests.","sha":"03af622492d6aad7583db67def9f615219ed7031","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard]
remove url_field_formatter functional
test","number":223448,"url":"https://github.com/elastic/kibana/pull/223448","mergeCommit":{"message":"[dashboard]
remove url_field_formatter functional test (#223448)\n\nPart of
https://github.com/elastic/kibana/issues/192910\n\nurl_field_formatter
functional test
was\n[skipped](#193293) in Sept
2024.\nInstead of removing `.skip`, the entire test should be removed
for the\nfollowing reasons\n1) It does not test dashboard code. The test
verifies rendering of\nlegacy visualize table on a dashboard and
discover table (in the\ndiscover app). Both of these are not our area of
responsibility.\n2) the test case is better covered by unit
tests.","sha":"03af622492d6aad7583db67def9f615219ed7031"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223448","number":223448,"mergeCommit":{"message":"[dashboard]
remove url_field_formatter functional test (#223448)\n\nPart of
https://github.com/elastic/kibana/issues/192910\n\nurl_field_formatter
functional test
was\n[skipped](#193293) in Sept
2024.\nInstead of removing `.skip`, the entire test should be removed
for the\nfollowing reasons\n1) It does not test dashboard code. The test
verifies rendering of\nlegacy visualize table on a dashboard and
discover table (in the\ndiscover app). Both of these are not our area of
responsibility.\n2) the test case is better covered by unit
tests.","sha":"03af622492d6aad7583db67def9f615219ed7031"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
Part of elastic#192910

url_field_formatter functional test was
[skipped](elastic#193293) in Sept 2024.
Instead of removing `.skip`, the entire test should be removed for the
following reasons
1) It does not test dashboard code. The test verifies rendering of
legacy visualize table on a dashboard and discover table (in the
discover app). Both of these are not our area of responsibility.
2) the test case is better covered by unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants