[Security Solution] Implement prebuilt rules import test plan#223421
Merged
maximpn merged 17 commits intoelastic:mainfrom Jun 24, 2025
Merged
[Security Solution] Implement prebuilt rules import test plan#223421maximpn merged 17 commits intoelastic:mainfrom
maximpn merged 17 commits intoelastic:mainfrom
Conversation
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8365[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/configs/ess_air_gapped.config.ts: 100/100 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8366[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/configs/ess_basic_license.config.ts: 100/100 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8367[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/configs/serverless_essentials_tier.config.ts: 100/100 tests passed. |
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
jbudz
approved these changes
Jun 12, 2025
Contributor
jbudz
left a comment
There was a problem hiding this comment.
.buildkite/ftr_security_configs.yml LGTM
dplumlee
reviewed
Jun 18, 2025
| overwrite: boolean; | ||
| } | ||
|
|
||
| export async function importRules({ |
Contributor
There was a problem hiding this comment.
Should some of these non-assertion utils go in x-pack/test/security_solution_api_integration/test_suites/detections_response/utils/rules/prebuilt_rules (or the above rules/ folder) to maintain the test file/helper file structure we have in the rest of the folders?
Contributor
Author
There was a problem hiding this comment.
Yes. It makes sense. I've moved import rules utilities to x-pack/test/security_solution_api_integration/test_suites/detections_response/utils/rules since these aren't prebuilt rules specific.
| immutable: true, | ||
| rule_source: { | ||
| type: 'external', | ||
| is_customized: false, |
Contributor
There was a problem hiding this comment.
Is this supposed to be true or are we intentionally setting this as false? The test case name would imply this should be true, no? This applies here and a few other places in the rest of this file
Contributor
Author
There was a problem hiding this comment.
A good catch. It's a misprint and definitely it should be true. Though rule_source.is_customized value in the import payload doesn't impact the imported value since we recalculate it anyway. I set it for consistency or if we start take it into account so we have the coverage.
| CURRENT_PREBUILT_RULE_VERSION + 1, | ||
| ]) { | ||
| it(`imports a prebuilt rule with a missing base version where curr version = ${version} and available version = ${CURRENT_PREBUILT_RULE_VERSION}`, async () => { | ||
| const VERSION = CURRENT_PREBUILT_RULE_VERSION - 1; |
Contributor
There was a problem hiding this comment.
Is this supposed to be based on version? We don't use it anywhere in the actual test besides the title
Contributor
Author
There was a problem hiding this comment.
Yes. Thanks for noticing!
650243a to
a6b879e
Compare
Contributor
Author
|
@dplumlee thanks for reviewing the test plan implementation 🙏 I've addressed your comments and added a couple of Cypress tests. Could you have a look? |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
…c#223421) **Addresses:** elastic#202079 ## Summary This PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md). Prior existing tests were superseded by the new ones. ## Discovered issues It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking - elastic#223099 - elastic#223280 - elastic#223253 ## Extra changes Some diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. ## Flaky test runner - ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations) - ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations) - ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations) (cherry picked from commit 87c8b88)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
…c#223421) **Addresses:** elastic#202079 ## Summary This PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md). Prior existing tests were superseded by the new ones. ## Discovered issues It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking - elastic#223099 - elastic#223280 - elastic#223253 ## Extra changes Some diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. ## Flaky test runner - ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations) - ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations) - ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations) (cherry picked from commit 87c8b88)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
…c#223421) **Addresses:** elastic#202079 ## Summary This PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md). Prior existing tests were superseded by the new ones. ## Discovered issues It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking - elastic#223099 - elastic#223280 - elastic#223253 ## Extra changes Some diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. ## Flaky test runner - ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations) - ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations) - ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations) (cherry picked from commit 87c8b88)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 3, 2025
…c#223421) **Addresses:** elastic#202079 ## Summary This PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md). Prior existing tests were superseded by the new ones. ## Discovered issues It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking - elastic#223099 - elastic#223280 - elastic#223253 ## Extra changes Some diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. ## Flaky test runner - ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations) - ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations) - ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations) (cherry picked from commit 87c8b88)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
maximpn
added a commit
to maximpn/kibana
that referenced
this pull request
Jul 4, 2025
…c#223421) **Addresses:** elastic#202079 ## Summary This PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md). Prior existing tests were superseded by the new ones. ## Discovered issues It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking - elastic#223099 - elastic#223280 - elastic#223253 ## Extra changes Some diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. ## Flaky test runner - ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations) - ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations) - ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations) (cherry picked from commit 87c8b88) # Conflicts: # .buildkite/ftr_security_stateful_configs.yml # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/configs/ess_air_gapped.config.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/import/import_with_installing_package.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/index.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/customization_enabled/index.ts
maximpn
added a commit
to maximpn/kibana
that referenced
this pull request
Jul 4, 2025
…c#223421) **Addresses:** elastic#202079 ## Summary This PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md). Prior existing tests were superseded by the new ones. ## Discovered issues It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking - elastic#223099 - elastic#223280 - elastic#223253 ## Extra changes Some diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. ## Flaky test runner - ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations) - ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations) - ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations) (cherry picked from commit 87c8b88) # Conflicts: # .buildkite/ftr_security_stateful_configs.yml # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/configs/ess_air_gapped.config.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/import/import_with_installing_package.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/common/index.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/customization_enabled/index.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 4, 2025
…223421) (#226507) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Implement prebuilt rules import test plan (#223421)](#223421) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-24T12:24:10Z","message":"[Security Solution] Implement prebuilt rules import test plan (#223421)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nThis PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md).\n\nPrior existing tests were superseded by the new ones.\n\n## Discovered issues\n\nIt turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking\n\n- https://github.com/elastic/kibana/issues/223099https://github.com/elastic/kibana/issues/223099\n- https://github.com/elastic/kibana/issues/223280\n- https://github.com/elastic/kibana/issues/223253\n\n## Extra changes\n\nSome diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. \n\n## Flaky test runner\n\n- ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations)\n- ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations)\n- ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations)","sha":"87c8b882c238acd38c39704cacce29b8d022c4d5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","impact:high","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.0.4"],"title":"[Security Solution] Implement prebuilt rules import test plan","number":223421,"url":"https://github.com/elastic/kibana/pull/223421","mergeCommit":{"message":"[Security Solution] Implement prebuilt rules import test plan (#223421)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nThis PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md).\n\nPrior existing tests were superseded by the new ones.\n\n## Discovered issues\n\nIt turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking\n\n- https://github.com/elastic/kibana/issues/223099https://github.com/elastic/kibana/issues/223099\n- https://github.com/elastic/kibana/issues/223280\n- https://github.com/elastic/kibana/issues/223253\n\n## Extra changes\n\nSome diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. \n\n## Flaky test runner\n\n- ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations)\n- ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations)\n- ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations)","sha":"87c8b882c238acd38c39704cacce29b8d022c4d5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223421","number":223421,"mergeCommit":{"message":"[Security Solution] Implement prebuilt rules import test plan (#223421)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nThis PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md).\n\nPrior existing tests were superseded by the new ones.\n\n## Discovered issues\n\nIt turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking\n\n- https://github.com/elastic/kibana/issues/223099https://github.com/elastic/kibana/issues/223099\n- https://github.com/elastic/kibana/issues/223280\n- https://github.com/elastic/kibana/issues/223253\n\n## Extra changes\n\nSome diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. \n\n## Flaky test runner\n\n- ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations)\n- ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations)\n- ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations)","sha":"87c8b882c238acd38c39704cacce29b8d022c4d5"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/225072","number":225072,"state":"MERGED","mergeCommit":{"sha":"2ccfccfc6c48365bdec9ee45b0f75b250724375f","message":"[8.19] [Security Solution] Implement prebuilt rules import test plan (#223421) (#225072)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Security Solution] Implement prebuilt rules import test plan\n(#223421)](https://github.com/elastic/kibana/pull/223421)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226448","number":226448,"state":"MERGED","mergeCommit":{"sha":"108331c351b831b2e2e40f080d60a73dc127254d","message":"[9.0] [Security Solution] Implement prebuilt rules import test plan (#223421) (#226448)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Implement prebuilt rules import test plan\n(#223421)](https://github.com/elastic/kibana/pull/223421)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}},{"url":"https://github.com/elastic/kibana/pull/226449","number":226449,"branch":"8.18","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 4, 2025
…223421) (#226508) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Implement prebuilt rules import test plan (#223421)](#223421) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-24T12:24:10Z","message":"[Security Solution] Implement prebuilt rules import test plan (#223421)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nThis PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md).\n\nPrior existing tests were superseded by the new ones.\n\n## Discovered issues\n\nIt turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking\n\n- https://github.com/elastic/kibana/issues/223099https://github.com/elastic/kibana/issues/223099\n- https://github.com/elastic/kibana/issues/223280\n- https://github.com/elastic/kibana/issues/223253\n\n## Extra changes\n\nSome diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. \n\n## Flaky test runner\n\n- ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations)\n- ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations)\n- ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations)","sha":"87c8b882c238acd38c39704cacce29b8d022c4d5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","impact:high","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0","v9.2.0","v8.18.4","v9.0.4"],"title":"[Security Solution] Implement prebuilt rules import test plan","number":223421,"url":"https://github.com/elastic/kibana/pull/223421","mergeCommit":{"message":"[Security Solution] Implement prebuilt rules import test plan (#223421)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nThis PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md).\n\nPrior existing tests were superseded by the new ones.\n\n## Discovered issues\n\nIt turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking\n\n- https://github.com/elastic/kibana/issues/223099https://github.com/elastic/kibana/issues/223099\n- https://github.com/elastic/kibana/issues/223280\n- https://github.com/elastic/kibana/issues/223253\n\n## Extra changes\n\nSome diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. \n\n## Flaky test runner\n\n- ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations)\n- ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations)\n- ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations)","sha":"87c8b882c238acd38c39704cacce29b8d022c4d5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223421","number":223421,"mergeCommit":{"message":"[Security Solution] Implement prebuilt rules import test plan (#223421)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202079\n\n## Summary\n\nThis PR implement prebuilt rules import [test plan](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/prebuilt_rule_import.md).\n\nPrior existing tests were superseded by the new ones.\n\n## Discovered issues\n\nIt turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking\n\n- https://github.com/elastic/kibana/issues/223099https://github.com/elastic/kibana/issues/223099\n- https://github.com/elastic/kibana/issues/223280\n- https://github.com/elastic/kibana/issues/223253\n\n## Extra changes\n\nSome diff like in `alert_threat_enrichments.cy.ts` has been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage. \n\n## Flaky test runner\n\n- ✅ [`detection_engine_security` package related prebuilt rules import integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8365) (100 iterations)\n- ✅ [prebuilt rules import ECH integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8366) (100 iterations)\n- ✅ [prebuilt rules import Serverless integration tests](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8367) (100 iterations)","sha":"87c8b882c238acd38c39704cacce29b8d022c4d5"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/225072","number":225072,"state":"MERGED","mergeCommit":{"sha":"2ccfccfc6c48365bdec9ee45b0f75b250724375f","message":"[8.19] [Security Solution] Implement prebuilt rules import test plan (#223421) (#225072)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Security Solution] Implement prebuilt rules import test plan\n(#223421)](https://github.com/elastic/kibana/pull/223421)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226449","number":226449,"state":"MERGED","mergeCommit":{"sha":"832b2097ad985af7e17e7d60d726816ca4d6323b","message":"[8.18] [Security Solution] Implement prebuilt rules import test plan (#223421) (#226449)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [[Security Solution] Implement prebuilt rules import test plan\n(#223421)](https://github.com/elastic/kibana/pull/223421)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226448","number":226448,"state":"MERGED","mergeCommit":{"sha":"108331c351b831b2e2e40f080d60a73dc127254d","message":"[9.0] [Security Solution] Implement prebuilt rules import test plan (#223421) (#226448)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Implement prebuilt rules import test plan\n(#223421)](https://github.com/elastic/kibana/pull/223421)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}}]}] BACKPORT--> --------- Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
maximpn
added a commit
that referenced
this pull request
Sep 15, 2025
…ersion tests matching the test scenario (#234735) **Relates to:** #223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 15, 2025
…ersion tests matching the test scenario (elastic#234735) **Relates to:** elastic#223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](elastic#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import. (cherry picked from commit 10533eb)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 15, 2025
…ersion tests matching the test scenario (elastic#234735) **Relates to:** elastic#223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](elastic#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import. (cherry picked from commit 10533eb)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 15, 2025
…ersion tests matching the test scenario (elastic#234735) **Relates to:** elastic#223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](elastic#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import. (cherry picked from commit 10533eb)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 15, 2025
…ersion tests matching the test scenario (elastic#234735) **Relates to:** elastic#223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](elastic#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import. (cherry picked from commit 10533eb)
kibanamachine
added a commit
that referenced
this pull request
Sep 15, 2025
…base version tests matching the test scenario (#234735) (#235114) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)](#234735) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-09-15T16:36:35Z","message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6","v8.18.7"],"title":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario","number":234735,"url":"https://github.com/elastic/kibana/pull/234735","mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234735","number":234735,"mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Sep 15, 2025
… base version tests matching the test scenario (#234735) (#235112) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)](#234735) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-09-15T16:36:35Z","message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6","v8.18.7"],"title":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario","number":234735,"url":"https://github.com/elastic/kibana/pull/234735","mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234735","number":234735,"mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Sep 15, 2025
…base version tests matching the test scenario (#234735) (#235113) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)](#234735) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-09-15T16:36:35Z","message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6","v8.18.7"],"title":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario","number":234735,"url":"https://github.com/elastic/kibana/pull/234735","mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234735","number":234735,"mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
banderror
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2025
…ersion tests matching the test scenario (elastic#234735) **Relates to:** elastic#223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](elastic#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import. (cherry picked from commit 10533eb)
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2025
… base version tests matching the test scenario (#234735) (#235111) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)](#234735) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-09-15T16:36:35Z","message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6","v8.18.7"],"title":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario","number":234735,"url":"https://github.com/elastic/kibana/pull/234735","mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234735","number":234735,"mergeCommit":{"message":"[Security Solution] Make importing prebuilt rules with missing base version tests matching the test scenario (#234735)\n\n**Relates to:** https://github.com/elastic/kibana/pull/223421\n\n## Summary\n\nThis PR makes little adjustments to [Importing Prebuilt\nRules](#223421) with missing base\nversion test scenario implementation to make it matching test scenario\nsteps. In particular it makes sure an installed prebuilt rule gets\ncustomized before testing import.","sha":"10533ebfa440c6ac91166cc1d6d33b72d7102dc9"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
…ersion tests matching the test scenario (elastic#234735) **Relates to:** elastic#223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](elastic#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import.
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
…ersion tests matching the test scenario (#234735) **Relates to:** #223421 ## Summary This PR makes little adjustments to [Importing Prebuilt Rules](#223421) with missing base version test scenario implementation to make it matching test scenario steps. In particular it makes sure an installed prebuilt rule gets customized before testing import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #202079
Summary
This PR implement prebuilt rules import test plan.
Prior existing tests were superseded by the new ones.
Discovered issues
It turned out that the current implementation behaves slightly differently than described the test plan. Failed test scenarios are skipped and the following tickets have been created for tracking
Extra changes
Some diff like in
alert_threat_enrichments.cy.tshas been caused by disabling errors swallowing upon rule creation. It's important to have tests properly preparing the testing environment to reduce chances of test dependencies and flakiness. In particular some prebuilt rules import test scenarios require custom rules to be created. Swallowing rule creation errors reduces tests coverage.Flaky test runner
detection_engine_securitypackage related prebuilt rules import integration tests (100 iterations)