[Cloud Security] Cloud Asset Discovery onboarding E2E tests (AWS/GCP/Azure)#223310
[Cloud Security] Cloud Asset Discovery onboarding E2E tests (AWS/GCP/Azure)#223310seanrathier merged 13 commits intoelastic:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new E2E tests for the Cloud Asset Discovery onboarding for AWS and extends existing test helper methods. Key changes include:
- Adding new Cypress scripts for asset inventory tests in package.json.
- Introducing a new navigation URL constant for the asset inventory integration.
- Creating several new helper functions and comprehensive E2E tests in asset_inventory_onboarding_aws.cy.ts.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| x-pack/test/security_solution_cypress/package.json | Added Cypress script for asset inventory integration tests |
| x-pack/test/security_solution_cypress/cypress/urls/navigation.ts | Added new URL constant for asset inventory integration |
| x-pack/test/security_solution_cypress/cypress/helpers/common.ts | Added new helper functions for common assertions |
| x-pack/test/security_solution_cypress/cypress/e2e/asset_inventory/constants.ts | Added constants to support asset inventory tests |
| x-pack/test/security_solution_cypress/cypress/e2e/asset_inventory/asset_inventory_onboarding_aws.cy.ts | Added comprehensive AWS onboarding tests for asset inventory |
Comments suppressed due to low confidence (4)
x-pack/test/security_solution_cypress/cypress/urls/navigation.ts:104
- For consistency with other URL constants, consider prefixing ASSET_INVENTORY_INTEGRATION_URL with a '/' to ensure uniformity in route paths.
export const ASSET_INVENTORY_INTEGRATION_URL = 'app/fleet/integrations/cloud_asset_inventory/add-integration';
x-pack/test/security_solution_cypress/cypress/e2e/asset_inventory/asset_inventory_onboarding_aws.cy.ts:144
- [nitpick] Consider enabling the assertion for SECRET_KEY to verify that the secret key input is correctly processed, or remove the commented code if it is no longer required.
// checkInputValue(SECRET_KEY, testSecretKey);
x-pack/test/security_solution_cypress/cypress/e2e/asset_inventory/asset_inventory_onboarding_aws.cy.ts:185
- [nitpick] Consider enabling the assertion for TEMPORARY_KEY_SECRET_KEY to ensure that the temporary secret key value is being handled as expected, or remove the commented code if unneeded.
// checkInputValue(TEMPORARY_KEY_SECRET_KEY, testSecretKey);
x-pack/test/security_solution_cypress/cypress/e2e/asset_inventory/asset_inventory_onboarding_aws.cy.ts:224
- [nitpick] Consider enabling the secret key assertion in the shared credentials test to ensure comprehensive validation of the integration configuration, or remove the commented line if it is redundant.
// checkInputValue(TEMPORARY_KEY_SECRET_KEY, testSecretKey);
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
a5cdae8 to
20d3247
Compare
537f74e to
3d650ef
Compare
8ac1d51 to
eb29551
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8374[✅] Asset Inventory - Cypress: 25/25 tests passed. |
azasypkin
left a comment
There was a problem hiding this comment.
Changes in config/serverless.security.yml LGTM.
That being said, enabling fleet.agentless functionality in serverless, which might potentially be a significant change in available functionality, doesn't really correspond to the PR title "Cloud Asset Discovery onboarding E2E tests - AWS/GCP" that implies the change is test-only.
|
I've updated the title and added more context about the config change. |
58f75f1 to
425e4c1
Compare
serverless.security.ymlThere was a problem hiding this comment.
Great work on these onboarding E2E tests!
As a suggestion, consider using our Cypress design patterns—specifically, moving UI selectors into a /screens folder and reusable actions into /tasks. This makes tests easier to maintain and scale as the suite grows.
You can see screens examples here.
And tasks examples here
Let me know if you want any pointers—happy to help!
There was a problem hiding this comment.
@vgomez-el I updated the locations of the tests to screens and tasks
8cb3ef1 to
3799641
Compare
💚 Build Succeeded
Metrics [docs]
History
|
Summary
This PR adds end-to-end (E2E) tests for the Cloud Asset Discovery onboarding flow across AWS, Azure, and GCP. It also extends test utilities and updates Serverless Security configurations to support agentless integration.
Key changes:
Introduces new E2E test suites for AWS and GCP onboarding:
asset_inventory_onboarding_aws.cy.tsasset_inventory_onboarding_gcp.cy.tsasset_inventory_onboarding_azure.cy.tsAdds new test helper functions to support the onboarding flows.
Enables the agentless integration option in the security_solution_cypress/serverless_config.ts, required for enabling agentless support in the CI for Cypress Security Serverless E2E tests.
@serverlessyarn serverless-securitywill display the agentless option in agentless-enabled integrations.BuildKite Logs
Checklist
Related Issues