[Security Solution] Actualize prebuilt rule customization test plan#222188
Merged
maximpn merged 3 commits intoelastic:mainfrom Jun 20, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
0b2b8a9 to
18dfdca
Compare
nikitaindik
reviewed
Jun 7, 2025
Contributor
nikitaindik
left a comment
There was a problem hiding this comment.
Nice job refining it, @maximpn! I've taken a look and posted a few comments. Please check it out.
| And should bring the user to the prebuilt rule edit page when clicked on | ||
| ``` | ||
|
|
||
| #### **Scenario: User can bulk edit prebuilt rules from rules management page** |
Contributor
There was a problem hiding this comment.
We have separate scenarios for editing a customized and non-cust. prebuilt rules:
- User can edit a customized prebuilt rule from the rule edit page
- User can edit a non-customized prebuilt rule from the rule edit page
Do we want to treat bulk actions the same way? Like:
- User can bulk edit prebuilt rules that weren't customized
- User can bulk edit prebuilt rules that were previosly customized
wdyt?
Contributor
Author
There was a problem hiding this comment.
Ideally, bulk editing would require 3 scenarios to test all the cases
- bulk edit non-customized prebuilt rules
- bulk edit customized prebuilt rules
- bulk edit a mix of customized and non-customized prebuilt rules
But it's sufficient to have only the last one to reduce maintainability costs. So I've updated the test scenario accordingly.
| @@ -246,20 +272,74 @@ Examples: | |||
| **Automation**: 1 integration test. | |||
Contributor
There was a problem hiding this comment.
Should we test this with different endpoints: single update, single patch, bulk update?
| @@ -293,7 +373,7 @@ Then the Modified badge should NOT be present on the page | |||
| **Automation**: 1 cypress test. | |||
Contributor
There was a problem hiding this comment.
We need to change the last "modified" to "customized" in scenario title for consistency with other scenarios.
"Modified badge should appear on the rule management table when prebuilt rule is modified customized"
| And the "Modified" badge should NOT be present in the table row | ||
| ``` | ||
|
|
||
| #### **Scenario: User should be able to see only customized rules in the rule updates table** |
Contributor
There was a problem hiding this comment.
Suggested change
| #### **Scenario: User should be able to see only customized rules in the rule updates table** | |
| #### **Scenario: User should be able to filter by customized rules in the rule updates table** |
For consistency with scenario below
| And a button to proceed with applying the action only to custom rules should be displayed | ||
| ``` | ||
|
|
||
| #### **Scenario: User can't edit prebuilt rules via bulk edit API under an insufficient license** |
Contributor
There was a problem hiding this comment.
Do we then also want an integration test for a single rule edit? Or do we consider it covered by a Cypress test?
836c452 to
182f335
Compare
182f335 to
1ebfca1
Compare
Contributor
Author
|
Hi @nikitaindik, I've addressed your comments. Could you have a look? |
nikitaindik
approved these changes
Jun 18, 2025
Contributor
nikitaindik
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback! LGTM now. 👍
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 20, 2025
…lastic#222188) **Addresses:** elastic#202068 ## Summary This PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature. ## Details The changes include - Adding an extra test scenario for prebuilt rule customization via public API - Fixing a scenario under Licensing section - Fixing wording to make scenarios simpler (cherry picked from commit 98aaf50)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 20, 2025
… plan (#222188) (#224727) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Actualize prebuilt rule customization test plan (#222188)](#222188) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-20T15:16:59Z","message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Actualize prebuilt rule customization test plan","number":222188,"url":"https://github.com/elastic/kibana/pull/222188","mergeCommit":{"message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222188","number":222188,"mergeCommit":{"message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
…lastic#222188) **Addresses:** elastic#202068 ## Summary This PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature. ## Details The changes include - Adding an extra test scenario for prebuilt rule customization via public API - Fixing a scenario under Licensing section - Fixing wording to make scenarios simpler
21 tasks
maximpn
added a commit
to maximpn/kibana
that referenced
this pull request
Jul 7, 2025
…lastic#222188) **Addresses:** elastic#202068 ## Summary This PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature. ## Details The changes include - Adding an extra test scenario for prebuilt rule customization via public API - Fixing a scenario under Licensing section - Fixing wording to make scenarios simpler (cherry picked from commit 98aaf50)
maximpn
added a commit
to maximpn/kibana
that referenced
this pull request
Jul 7, 2025
…lastic#222188) **Addresses:** elastic#202068 ## Summary This PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature. ## Details The changes include - Adding an extra test scenario for prebuilt rule customization via public API - Fixing a scenario under Licensing section - Fixing wording to make scenarios simpler (cherry picked from commit 98aaf50)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maximpn
added a commit
that referenced
this pull request
Jul 7, 2025
… plan (#222188) (#226783) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Actualize prebuilt rule customization test plan (#222188)](#222188) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-20T15:16:59Z","message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Actualize prebuilt rule customization test plan","number":222188,"url":"https://github.com/elastic/kibana/pull/222188","mergeCommit":{"message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222188","number":222188,"mergeCommit":{"message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224727","number":224727,"state":"MERGED","mergeCommit":{"sha":"296c3b0a4d5ed79611260674a917f08cb726fec3","message":"[8.19] [Security Solution] Actualize prebuilt rule customization test plan (#222188) (#224727)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Security Solution] Actualize prebuilt rule customization test plan\n(#222188)](https://github.com/elastic/kibana/pull/222188)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}}]}] BACKPORT-->
maximpn
added a commit
that referenced
this pull request
Jul 7, 2025
…plan (#222188) (#226781) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Actualize prebuilt rule customization test plan (#222188)](#222188) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-20T15:16:59Z","message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Actualize prebuilt rule customization test plan","number":222188,"url":"https://github.com/elastic/kibana/pull/222188","mergeCommit":{"message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222188","number":222188,"mergeCommit":{"message":"[Security Solution] Actualize prebuilt rule customization test plan (#222188)\n\n**Addresses:** https://github.com/elastic/kibana/issues/202068\n\n## Summary\n\nThis PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.\n\n## Details\n\nThe changes include\n\n- Adding an extra test scenario for prebuilt rule customization via public API\n- Fixing a scenario under Licensing section\n- Fixing wording to make scenarios simpler","sha":"98aaf50be2e002e645ac1cd081bfaba2e04714a3"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224727","number":224727,"state":"MERGED","mergeCommit":{"sha":"296c3b0a4d5ed79611260674a917f08cb726fec3","message":"[8.19] [Security Solution] Actualize prebuilt rule customization test plan (#222188) (#224727)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Security Solution] Actualize prebuilt rule customization test plan\n(#222188)](https://github.com/elastic/kibana/pull/222188)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}}]}] BACKPORT-->
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.1 |
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #202068
Summary
This PR actualizes prebuilt rule customization test plan with the current feature state and desired test coverage we expect for prebuilt rule customization sub-feature.
Details
The changes include