Skip to content

translate tutorials(osquery_logs, php_fpm_metrics, postgresql_logs, p…#22124

Merged
pavel06081991 merged 3 commits intoelastic:masterfrom
pavel06081991:feature/tutorial-translations-part5
Aug 24, 2018
Merged

translate tutorials(osquery_logs, php_fpm_metrics, postgresql_logs, p…#22124
pavel06081991 merged 3 commits intoelastic:masterfrom
pavel06081991:feature/tutorial-translations-part5

Conversation

@pavel06081991
Copy link
Copy Markdown
Contributor

#21957
translate tutorials(osquery_logs, php_fpm_metrics, postgresql_logs, postgresql_metrics, prometheus_metrics, rabbitmq_metrics, redis_logs)

…ostgresql_metrics, prometheus_metrics, rabbitmq_metrics, redis_logs)
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@pavel06081991 pavel06081991 added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Project:i18n :Sharing and removed Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// labels Aug 20, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@yankouskia yankouskia requested a review from tsullivan August 22, 2018 12:06
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a duplicate string ID

shortDescription: i18n.translate('kbn.server.tutorials.phpFpmMetrics.shortDescription', {
defaultMessage: 'Fetch internal metrics from PHP-FPM.',
}),
longDescription: i18n.translate('kbn.server.tutorials.phpFpmMetrics.shortDescription', {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbn.server.tutorials.phpFpmMetrics.longDescription

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thanks

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel06081991 pavel06081991 merged commit a1372dc into elastic:master Aug 24, 2018
@pavel06081991 pavel06081991 deleted the feature/tutorial-translations-part5 branch August 24, 2018 08:48
pavel06081991 added a commit to pavel06081991/kibana that referenced this pull request Aug 24, 2018
elastic#22124)

translate tutorials(osquery_logs, php_fpm_metrics, postgresql_logs, postgresql_metrics, prometheus_metrics, rabbitmq_metrics, redis_logs)
# Conflicts:
#	src/core_plugins/kibana/server/tutorials/postgresql_logs/index.js
pavel06081991 added a commit that referenced this pull request Aug 24, 2018
#22124) (#22350)

translate tutorials(osquery_logs, php_fpm_metrics, postgresql_logs, postgresql_metrics, prometheus_metrics, rabbitmq_metrics, redis_logs)
# Conflicts:
#	src/core_plugins/kibana/server/tutorials/postgresql_logs/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants