translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubern…#22122
Merged
pavel06081991 merged 3 commits intoelastic:masterfrom Aug 24, 2018
Merged
Conversation
…etes_metrics, logstash_logs, logstash_metrics, memcached_metrics)
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
yankouskia
approved these changes
Aug 22, 2018
tsullivan
requested changes
Aug 23, 2018
Member
tsullivan
left a comment
There was a problem hiding this comment.
Found a duplicated string ID.
Is it possible to have the framework throw an error if this happens?
| shortDescription: i18n.translate('kbn.server.tutorials.memcachedMetrics.shortDescription', { | ||
| defaultMessage: 'Fetch internal metrics from the Memcached server.', | ||
| }), | ||
| longDescription: i18n.translate('kbn.server.tutorials.memcachedMetrics.shortDescription', { |
Member
There was a problem hiding this comment.
kbn.server.tutorials.memcachedMetrics.longDescription
Contributor
Author
There was a problem hiding this comment.
fixed. thanks!
Contributor
Author
|
@tsullivan I believe we do not need to throw errors. Soon we will have such validations like duplicating ids in our CI pipeline. So we will not be able to merge pull request if we have duplicating ids |
Contributor
💚 Build Succeeded |
pavel06081991
added a commit
to pavel06081991/kibana
that referenced
this pull request
Aug 24, 2018
elastic#22122) translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubernetes_metrics, logstash_logs, logstash_metrics, memcached_metrics) # Conflicts: # src/core_plugins/kibana/server/tutorials/logstash_logs/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21957
translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubernetes_metrics, logstash_logs, logstash_metrics, memcached_metrics)