Skip to content

translate tutorials(elasticsearch_metrics, etcd_metrics, golang_metri…#22121

Merged
pavel06081991 merged 2 commits intoelastic:masterfrom
pavel06081991:feature/tutorial-translations-part2
Aug 24, 2018
Merged

translate tutorials(elasticsearch_metrics, etcd_metrics, golang_metri…#22121
pavel06081991 merged 2 commits intoelastic:masterfrom
pavel06081991:feature/tutorial-translations-part2

Conversation

@pavel06081991
Copy link
Copy Markdown
Contributor

#21957
translate tutorials(elasticsearch_metrics, etcd_metrics, golang_metrics, haprozy_metrics, iis_logs)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@pavel06081991 pavel06081991 added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Project:i18n :Sharing and removed Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// labels Aug 20, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@yankouskia yankouskia requested a review from tsullivan August 22, 2018 12:04
defaultMessage: 'The `elasticsearch` Metricbeat module fetches internal metrics from Elasticsearch. \
[Learn more]({learnMoreLink}).',
values: {
learnMoreLink: '{config.docs.beats.metricbeat}/metricbeat-module-elasticsearch.html',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this link always lead to the EN version of the Elastic site?
https://www.elastic.co/guide/en/beats/metricbeat/6.3/metricbeat-module-elasticsearch.html?

Answer is not stopping this PR. I'm just curious if the i18n framework can change a URL part based on locale

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azasypkin maybe you could help with clarification?

Copy link
Copy Markdown
Contributor

@azasypkin azasypkin Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a high chance that the set of locales we support in Kibana and have documentation for will be different so I'd not rely on anything "automatic" here, but we can add context field where we ask localizers to ping us and check whether we have docs for the locale they are currently working on so that every time we generate these labels for vendor to translate they will see that context field and can get back to us and clarify. For that to work we also will have to construct this link differently so that localizers can have access to this guide/en/beats part.

Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel06081991 pavel06081991 merged commit 74d8dbd into elastic:master Aug 24, 2018
@pavel06081991 pavel06081991 deleted the feature/tutorial-translations-part2 branch August 24, 2018 08:49
pavel06081991 added a commit to pavel06081991/kibana that referenced this pull request Aug 24, 2018
elastic#22121)

translate tutorials(elasticsearch_metrics, etcd_metrics, golang_metrics, haprozy_metrics, iis_logs)
# Conflicts:
#	src/core_plugins/kibana/server/tutorials/iis_logs/index.js
pavel06081991 added a commit that referenced this pull request Aug 24, 2018
#22121) (#22352)

translate tutorials(elasticsearch_metrics, etcd_metrics, golang_metrics, haprozy_metrics, iis_logs)
# Conflicts:
#	src/core_plugins/kibana/server/tutorials/iis_logs/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants